### TL;DR Improved the test stability for the turbo renderer by using reactive state observation instead of arbitrary timeouts. (https://github.com/toeverything/AFFiNE/actions/runs/14729729312/job/41340918866?pr=12071) ### What changed? - Replaced `wait(FRAME)` and other timeout-based waits with reactive state observation using RxJS - Added `filter` import from `rxjs/operators` - Updated test assertions to properly wait for specific renderer states (`ready`, `pending`, `zooming`) - Made tests more deterministic by waiting for specific state transitions rather than arbitrary time periods <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Improved test reliability by replacing fixed-duration waits with reactive waits based on renderer state changes, ensuring tests are synchronized with actual state transitions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
140 lines
4.2 KiB
TypeScript
140 lines
4.2 KiB
TypeScript
/**
|
|
* Please refer to integration-test/README.md for commands to run tests.
|
|
*/
|
|
import { ParagraphLayoutHandlerExtension } from '@blocksuite/affine/blocks/paragraph';
|
|
import { noop } from '@blocksuite/affine/global/utils';
|
|
import {
|
|
TurboRendererConfigFactory,
|
|
ViewportTurboRendererExtension,
|
|
} from '@blocksuite/affine-gfx-turbo-renderer';
|
|
import { firstValueFrom } from 'rxjs';
|
|
import { filter } from 'rxjs/operators';
|
|
import { afterEach, beforeEach, describe, expect, test } from 'vitest';
|
|
|
|
import { wait } from '../utils/common.js';
|
|
import { addSampleNotes } from '../utils/doc-generator.js';
|
|
import {
|
|
createPainterWorker,
|
|
getRenderer,
|
|
setupEditor,
|
|
} from '../utils/setup.js';
|
|
|
|
const FRAME = 16;
|
|
|
|
describe('viewport turbo renderer', () => {
|
|
let cleanup: () => void;
|
|
|
|
beforeEach(async () => {
|
|
cleanup = await setupEditor('edgeless', [
|
|
ParagraphLayoutHandlerExtension,
|
|
TurboRendererConfigFactory({
|
|
painterWorkerEntry: createPainterWorker,
|
|
}),
|
|
ViewportTurboRendererExtension,
|
|
]);
|
|
return cleanup;
|
|
});
|
|
|
|
afterEach(() => cleanup?.());
|
|
|
|
test('should render 6 notes in viewport', async () => {
|
|
addSampleNotes(doc, 6);
|
|
const renderer = getRenderer();
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'ready')));
|
|
|
|
const notes = document.querySelectorAll('affine-edgeless-note');
|
|
expect(notes.length).toBe(6);
|
|
});
|
|
|
|
test('should access turbo renderer instance', async () => {
|
|
const renderer = getRenderer();
|
|
expect(renderer).toBeDefined();
|
|
expect(renderer instanceof ViewportTurboRendererExtension).toBe(true);
|
|
expect(renderer.canvas).toBeInstanceOf(HTMLCanvasElement);
|
|
});
|
|
|
|
test('initial state should be pending', async () => {
|
|
const renderer = getRenderer();
|
|
expect(renderer.state$.value).toBe('pending');
|
|
});
|
|
|
|
test('zooming should change internal state and populate optimized block ids', async () => {
|
|
const renderer = getRenderer();
|
|
addSampleNotes(doc, 1);
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'ready')));
|
|
expect(renderer.optimizedBlockIds.length).toBe(0);
|
|
|
|
renderer.viewport.zooming$.next(true);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'zooming')));
|
|
|
|
const canUseCache = renderer.canUseBitmapCache();
|
|
expect(canUseCache).toBe(false);
|
|
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
expect(renderer.optimizedBlockIds.length).toBe(1);
|
|
|
|
renderer.viewport.zooming$.next(false);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'ready')));
|
|
|
|
expect(renderer.state$.value).toBe('ready');
|
|
expect(renderer.optimizedBlockIds.length).toBe(0);
|
|
});
|
|
|
|
test('state transitions between pending and ready', async () => {
|
|
const renderer = getRenderer();
|
|
|
|
addSampleNotes(doc, 1);
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'pending')));
|
|
expect(renderer.state$.value).toBe('pending');
|
|
|
|
renderer.viewport.zooming$.next(false);
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
await firstValueFrom(renderer.state$.pipe(filter(s => s === 'ready')));
|
|
|
|
expect(renderer.state$.value).toBe('ready');
|
|
});
|
|
|
|
test('initial layout cache data should be null', () => {
|
|
const renderer = getRenderer();
|
|
expect(renderer.layoutCacheData).toBeNull();
|
|
});
|
|
|
|
test('invalidation should reset layout cache data to null', async () => {
|
|
const renderer = getRenderer();
|
|
addSampleNotes(doc, 1);
|
|
await wait(100);
|
|
|
|
const _cache = renderer.layoutCache;
|
|
noop(_cache);
|
|
expect(renderer.layoutCacheData).not.toBeNull();
|
|
|
|
addSampleNotes(doc, 1);
|
|
await wait(100);
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
|
|
expect(renderer.layoutCacheData).toBeNull();
|
|
});
|
|
|
|
test('accessing layoutCache getter should populate cache data', async () => {
|
|
const renderer = getRenderer();
|
|
addSampleNotes(doc, 1);
|
|
await renderer.refresh();
|
|
await wait(FRAME);
|
|
expect(renderer.layoutCacheData).toBeNull();
|
|
|
|
const _cache = renderer.layoutCache;
|
|
noop(_cache);
|
|
expect(renderer.layoutCacheData).not.toBeNull();
|
|
expect(renderer.layoutCache?.roots.length).toBeGreaterThan(0);
|
|
});
|
|
});
|