luulam/9router
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(providers): clear stale locks after validation (#3830)

Browse Source 
Clear stale connection health state (modelLock_*, backoffLevel,
rateLimitedUntil, errorCode) whenever a connection is explicitly
marked active after successful validation or OAuth re-login.

Closes #3810
This commit is contained in:
Sutarto Jordan Chrisfivo
2026-09-09 10:24:30 +07:00
parent 4ad1e7a4ba
commit 7fee56bacd
2 changed files with 124 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
tests/unit/db-sqlite-vs-lowdb.test.js
View File

@@ -101,6 +101,104 @@ describe("DB SQLite layer — public API parity", () => {
expect(back.providerSpecificData).toEqual({ foo: "bar" });
});
it("providerConnections: successful validation clears stale routing locks", async () => {
const c = await sqliteDb.createProviderConnection({
provider: "health-reset-update",
authType: "oauth",
email: "update@example.com",
accessToken: "old-token",
});
await sqliteDb.updateProviderConnection(c.id, {
testStatus: "unavailable",
lastError: "Access denied",
lastErrorAt: "2026-09-05T00:00:00.000Z",
errorCode: 403,
backoffLevel: 3,
rateLimitedUntil: "2099-01-01T00:00:00.000Z",
modelLock_modelA: "2099-01-01T00:00:00.000Z",
modelLock_modelB: "2099-01-01T00:00:00.000Z",
});
await sqliteDb.updateProviderConnection(c.id, { testStatus: "active" });
const back = await sqliteDb.getProviderConnectionById(c.id);
expect(back).toMatchObject({
testStatus: "active",
lastError: null,
lastErrorAt: null,
errorCode: null,
backoffLevel: 0,
rateLimitedUntil: null,
modelLock_modelA: null,
modelLock_modelB: null,
});
});
it("providerConnections: re-saving valid OAuth credentials clears stale routing locks", async () => {
const existing = await sqliteDb.createProviderConnection({
provider: "health-reset-resave",
authType: "oauth",
email: "resave@example.com",
accessToken: "old-token",
});
await sqliteDb.updateProviderConnection(existing.id, {
testStatus: "unavailable",
lastError: "Access denied",
errorCode: 403,
backoffLevel: 2,
modelLock_modelA: "2099-01-01T00:00:00.000Z",
});
const resaved = await sqliteDb.createProviderConnection({
provider: "health-reset-resave",
authType: "oauth",
email: "resave@example.com",
accessToken: "new-token",
testStatus: "active",
});
expect(resaved.id).toBe(existing.id);
const back = await sqliteDb.getProviderConnectionById(existing.id);
expect(back).toMatchObject({
accessToken: "new-token",
testStatus: "active",
lastError: null,
errorCode: null,
backoffLevel: 0,
modelLock_modelA: null,
});
});
it("providerConnections: active soft warnings survive the health reset", async () => {
const c = await sqliteDb.createProviderConnection({
provider: "health-reset-warning",
authType: "oauth",
email: "warning@example.com",
});
await sqliteDb.updateProviderConnection(c.id, {
testStatus: "unavailable",
lastError: "Old failure",
modelLock_modelA: "2099-01-01T00:00:00.000Z",
});
const warningAt = "2026-09-06T00:00:00.000Z";
await sqliteDb.updateProviderConnection(c.id, {
testStatus: "active",
lastError: "Connected, but credits are exhausted",
lastErrorAt: warningAt,
});
const back = await sqliteDb.getProviderConnectionById(c.id);
expect(back).toMatchObject({
testStatus: "active",
lastError: "Connected, but credits are exhausted",
lastErrorAt: warningAt,
errorCode: null,
backoffLevel: 0,
modelLock_modelA: null,
});
});
it("providerConnections: GitHub OAuth uses account identity as fallback name", async () => {
const c = await sqliteDb.createProviderConnection({
provider: "github",