From d1e98d9a6076524f227a4de074d6a3cdf6dc276f Mon Sep 17 00:00:00 2001
From: Rex <177378174+anki1kr@users.noreply.github.com>
Date: Fri, 26 Jun 2026 10:50:20 +0700
Subject: [PATCH] fix(codebuddy): only send reasoning params when client
 requests reasoning

Forcing reasoning_effort:"medium" + reasoning_summary:"auto" on plain
requests tripped CodeBuddy's content filter and returned an error (#2071).
Make reasoning params opt-in: only set reasoning_summary when the client
sent an explicit reasoning_effort; none/off still drops it.

Fixes #2071

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 open-sse/executors/codebuddy-cn.js           |  8 +++--
 tests/unit/codebuddy-reasoning-optin.test.js | 37 ++++++++++++++++++++
 2 files changed, 43 insertions(+), 2 deletions(-)
 create mode 100644 tests/unit/codebuddy-reasoning-optin.test.js

diff --git a/open-sse/executors/codebuddy-cn.js b/open-sse/executors/codebuddy-cn.js
index 46e51951..5f37d015 100644
--- a/open-sse/executors/codebuddy-cn.js
+++ b/open-sse/executors/codebuddy-cn.js
@@ -25,10 +25,14 @@ export class CodeBuddyExecutor extends DefaultExecutor {
     const eff = transformed.reasoning_effort;
     if (eff === "none" || eff === "off") {
       delete transformed.reasoning_effort; // gateway has no "none" — just omit
-    } else {
-      if (!eff) transformed.reasoning_effort = "medium";
+    } else if (eff) {
+      // Client explicitly asked for reasoning — mirror the CLI's reasoning_summary
+      // so CodeBuddy surfaces the model's reasoning.
       transformed.reasoning_summary = "auto";
     }
+    // No reasoning requested: leave both unset. Forcing reasoning_effort:"medium"
+    // + reasoning_summary on plain requests makes CodeBuddy trip its content
+    // filter and return an error (#2071).
     return transformed;
   }
 }
diff --git a/tests/unit/codebuddy-reasoning-optin.test.js b/tests/unit/codebuddy-reasoning-optin.test.js
new file mode 100644
index 00000000..1bfaf15b
--- /dev/null
+++ b/tests/unit/codebuddy-reasoning-optin.test.js
@@ -0,0 +1,37 @@
+// #2071 — CodeBuddy forced reasoning_effort:"medium" + reasoning_summary:"auto"
+// on requests where the client never asked for reasoning, tripping CodeBuddy's
+// content filter ("model return error"). Reasoning params must be opt-in.
+import { describe, it, expect } from "vitest";
+import { CodeBuddyExecutor } from "../../open-sse/executors/codebuddy-cn.js";
+
+describe("CodeBuddyExecutor reasoning params are opt-in (#2071)", () => {
+  const exec = new CodeBuddyExecutor();
+
+  it("does NOT force reasoning when the client did not request it", () => {
+    const out = exec.transformRequest("glm-5.2", { messages: [{ role: "user", content: "hi" }] }, false, {});
+    expect(out.reasoning_effort).toBeUndefined();
+    expect(out.reasoning_summary).toBeUndefined();
+  });
+
+  it("mirrors reasoning_summary:auto when the client explicitly requested reasoning", () => {
+    const out = exec.transformRequest(
+      "glm-5.2",
+      { messages: [{ role: "user", content: "hi" }], reasoning_effort: "high" },
+      false,
+      {}
+    );
+    expect(out.reasoning_effort).toBe("high");
+    expect(out.reasoning_summary).toBe("auto");
+  });
+
+  it("omits reasoning_effort for none/off and adds no reasoning_summary", () => {
+    const out = exec.transformRequest(
+      "glm-5.2",
+      { messages: [{ role: "user", content: "hi" }], reasoning_effort: "none" },
+      false,
+      {}
+    );
+    expect(out.reasoning_effort).toBeUndefined();
+    expect(out.reasoning_summary).toBeUndefined();
+  });
+});