Fix bug Tunnel

src/mitm/manager.js

@@ -2,22 +2,52 @@ const { spawn, exec } = require("child_process");
 const path = require("path");
 const fs = require("fs");
 const os = require("os");
+const net = require("net");
+const crypto = require("crypto");
 const { addDNSEntry, removeDNSEntry, checkDNSEntry } = require("./dns/dnsConfig");
 
 const IS_WIN = process.platform === "win32";
 const { generateCert } = require("./cert/generate");
 const { installCert } = require("./cert/install");
 
-// Store server process
+const MITM_PORT = 443;
+const PID_FILE = path.join(os.homedir(), ".9router", "mitm", ".mitm.pid");
+
+// Resolve server.js path robustly:
+// __dirname is unreliable inside Next.js bundles, so we use DATA_DIR env or
+// fall back to locating the file relative to the app's source root.
+function resolveServerPath() {
+  // 1. Explicit override via env (useful for packaged/standalone builds)
+  if (process.env.MITM_SERVER_PATH) return process.env.MITM_SERVER_PATH;
+
+  // 2. Try sibling of this file (works in dev where __dirname is real)
+  const sibling = path.join(__dirname, "server.js");
+  if (fs.existsSync(sibling)) return sibling;
+
+  // 3. Fallback: resolve from process.cwd() → src/mitm/server.js
+  const fromCwd = path.join(process.cwd(), "src", "mitm", "server.js");
+  if (fs.existsSync(fromCwd)) return fromCwd;
+
+  // 4. Standalone build: app root is parent of .next
+  const fromNext = path.join(process.cwd(), "..", "src", "mitm", "server.js");
+  if (fs.existsSync(fromNext)) return fromNext;
+
+  return fromCwd; // best guess
+}
+
+const SERVER_PATH = resolveServerPath();
+
+const ENCRYPT_ALGO = "aes-256-gcm";
+const ENCRYPT_SALT = "9router-mitm-pwd";
+
+// Store server process in-memory
 let serverProcess = null;
 let serverPid = null;
-// Persist across Next.js hot reloads
+
+// Persist sudo password across Next.js hot reloads (in-memory only)
 function getCachedPassword() { return globalThis.__mitmSudoPassword || null; }
 function setCachedPassword(pwd) { globalThis.__mitmSudoPassword = pwd; }
 
-// server.js is in same directory as this file
-const PID_FILE = path.join(os.homedir(), ".9router", "mitm", ".mitm.pid");
-
 // Check if a PID is alive
 function isProcessAlive(pid) {
   try {
@@ -34,7 +64,193 @@ function killProcess(pid, force = false) {
     const flag = force ? "/F " : "";
     exec(`taskkill ${flag}/PID ${pid}`, () => {});
   } else {
-    process.kill(pid, force ? "SIGKILL" : "SIGTERM");
+    // Use pkill to kill entire process group (catches sudo + child node process)
+    const sig = force ? "SIGKILL" : "SIGTERM";
+    exec(`pkill -${sig} -P ${pid} 2>/dev/null; kill -${sig} ${pid} 2>/dev/null`, () => {});
+  }
+}
+
+/** Derive a 32-byte encryption key from machineId */
+function deriveKey() {
+  try {
+    const { machineIdSync } = require("node-machine-id");
+    const raw = machineIdSync();
+    return crypto.createHash("sha256").update(raw + ENCRYPT_SALT).digest();
+  } catch {
+    // Fallback: fixed key derived from salt (less secure but functional)
+    return crypto.createHash("sha256").update(ENCRYPT_SALT).digest();
+  }
+}
+
+/** Encrypt sudo password with AES-256-GCM */
+function encryptPassword(plaintext) {
+  const key = deriveKey();
+  const iv = crypto.randomBytes(12);
+  const cipher = crypto.createCipheriv(ENCRYPT_ALGO, key, iv);
+  const encrypted = Buffer.concat([cipher.update(plaintext, "utf8"), cipher.final()]);
+  const tag = cipher.getAuthTag();
+  // Store as hex: iv:tag:ciphertext
+  return `${iv.toString("hex")}:${tag.toString("hex")}:${encrypted.toString("hex")}`;
+}
+
+/** Decrypt sudo password */
+function decryptPassword(stored) {
+  try {
+    const [ivHex, tagHex, dataHex] = stored.split(":");
+    if (!ivHex || !tagHex || !dataHex) return null;
+    const key = deriveKey();
+    const decipher = crypto.createDecipheriv(ENCRYPT_ALGO, key, Buffer.from(ivHex, "hex"));
+    decipher.setAuthTag(Buffer.from(tagHex, "hex"));
+    return decipher.update(Buffer.from(dataHex, "hex")) + decipher.final("utf8");
+  } catch {
+    return null;
+  }
+}
+
+// DB hooks — injected from ESM context (initializeApp / route handlers)
+// to avoid webpack bundling issues with dynamic imports in CJS modules.
+let _getSettings = null;
+let _updateSettings = null;
+
+/** Called once from ESM context to inject DB access functions */
+function initDbHooks(getSettingsFn, updateSettingsFn) {
+  _getSettings = getSettingsFn;
+  _updateSettings = updateSettingsFn;
+}
+
+/** Save encrypted sudo password + mitmEnabled to db */
+async function saveMitmSettings(enabled, password) {
+  if (!_updateSettings) {
+    console.log("[MITM] DB hooks not initialized, skipping save");
+    return;
+  }
+  try {
+    const updates = { mitmEnabled: enabled };
+    if (password) updates.mitmSudoEncrypted = encryptPassword(password);
+    await _updateSettings(updates);
+  } catch (e) {
+    console.log("[MITM] Failed to save settings:", e.message);
+  }
+}
+
+/** Load and decrypt sudo password from db */
+async function loadEncryptedPassword() {
+  if (!_getSettings) return null;
+  try {
+    const settings = await _getSettings();
+    if (!settings.mitmSudoEncrypted) return null;
+    return decryptPassword(settings.mitmSudoEncrypted);
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Check if port 443 is available
+ * Returns: "free" | "in-use" | "no-permission"
+ */
+function checkPort443Free() {
+  return new Promise((resolve) => {
+    const tester = net.createServer();
+    tester.once("error", (err) => {
+      if (err.code === "EADDRINUSE") resolve("in-use");
+      else resolve("no-permission"); // EACCES or other → port free but needs sudo
+    });
+    tester.once("listening", () => { tester.close(() => resolve("free")); });
+    tester.listen(MITM_PORT, "127.0.0.1");
+  });
+}
+
+/**
+ * Get PID and process name currently holding port 443
+ * Returns { pid, name } or null if port is free / cannot determine
+ */
+function getPort443Owner() {
+  return new Promise((resolve) => {
+    const cmd = IS_WIN
+      ? `netstat -ano | findstr ":443 "`
+      // Only match TCP processes actually LISTEN-ing on port 443 (not outbound UDP/QUIC)
+      : `lsof -i TCP:${MITM_PORT} -n -P -sTCP:LISTEN`;
+
+    exec(cmd, (err, stdout) => {
+      if (err || !stdout.trim()) return resolve(null);
+
+      let pid = null;
+
+      if (IS_WIN) {
+        // netstat line: "  TCP  0.0.0.0:443  0.0.0.0:0  LISTENING  1234"
+        for (const line of stdout.split("\n")) {
+          const match = line.match(/LISTENING\s+(\d+)/i);
+          if (match) { pid = parseInt(match[1], 10); break; }
+        }
+      } else {
+        // lsof line: "node  1234  user  ..."
+        for (const line of stdout.split("\n").slice(1)) {
+          const parts = line.trim().split(/\s+/);
+          if (parts.length >= 2) { pid = parseInt(parts[1], 10); break; }
+        }
+      }
+
+      if (!pid || isNaN(pid)) return resolve(null);
+
+      // Get process name by PID
+      const nameCmd = IS_WIN
+        ? `tasklist /FI "PID eq ${pid}" /FO CSV /NH`
+        : `ps -p ${pid} -o comm=`;
+
+      exec(nameCmd, (e2, out2) => {
+        let name = "unknown";
+        if (!e2 && out2.trim()) {
+          if (IS_WIN) {
+            // CSV: "node.exe","1234",...
+            const m = out2.match(/"([^"]+)"/);
+            if (m) name = m[1];
+          } else {
+            name = out2.trim();
+          }
+        }
+        resolve({ pid, name });
+      });
+    });
+  });
+}
+
+/**
+ * Kill any leftover MITM server process (from previous failed start)
+ * Uses sudo to kill the node process that was spawned with sudo
+ */
+async function killLeftoverMitm(sudoPassword) {
+  // Kill in-memory process if still alive
+  if (serverProcess && !serverProcess.killed) {
+    try { serverProcess.kill("SIGKILL"); } catch { /* ignore */ }
+    serverProcess = null;
+    serverPid = null;
+  }
+
+  // Kill from PID file
+  try {
+    if (fs.existsSync(PID_FILE)) {
+      const savedPid = parseInt(fs.readFileSync(PID_FILE, "utf-8").trim(), 10);
+      if (savedPid && isProcessAlive(savedPid)) {
+        killProcess(savedPid, true);
+        await new Promise(r => setTimeout(r, 500));
+      }
+      fs.unlinkSync(PID_FILE);
+    }
+  } catch { /* ignore */ }
+
+  // Also kill any node process running server.js via sudo (belt-and-suspenders)
+  if (!IS_WIN && SERVER_PATH) {
+    try {
+      const escaped = SERVER_PATH.replace(/'/g, "'\\''");
+      if (sudoPassword) {
+        const { execWithPassword } = require("./dns/dnsConfig");
+        await execWithPassword(`pkill -SIGKILL -f "${escaped}" 2>/dev/null || true`, sudoPassword).catch(() => {});
+      } else {
+        exec(`pkill -SIGKILL -f "${escaped}" 2>/dev/null || true`, () => {});
+      }
+      await new Promise(r => setTimeout(r, 500));
+    } catch { /* ignore */ }
   }
 }
 
@@ -42,7 +258,6 @@ function killProcess(pid, force = false) {
  * Get MITM status
  */
 async function getMitmStatus() {
-  // Check in-memory process first, then fallback to PID file
   let running = serverProcess !== null && !serverProcess.killed;
   let pid = serverPid;
 
@@ -54,7 +269,6 @@ async function getMitmStatus() {
           running = true;
           pid = savedPid;
         } else {
-          // Stale PID file, clean up
           fs.unlinkSync(PID_FILE);
         }
       }
@@ -63,10 +277,7 @@ async function getMitmStatus() {
     }
   }
 
-  // Check DNS configuration (cross-platform via dnsConfig)
   const dnsConfigured = checkDNSEntry();
-
-  // Check cert
   const certDir = path.join(os.homedir(), ".9router", "mitm");
   const certExists = fs.existsSync(path.join(certDir, "server.crt"));
 
@@ -79,109 +290,133 @@ async function getMitmStatus() {
  * @param {string} sudoPassword - Sudo password for DNS/cert operations
  */
 async function startMitm(apiKey, sudoPassword) {
-  // Check if already running
+  // Check orphan process from PID file before spawning
+  if (!serverProcess || serverProcess.killed) {
+    try {
+      if (fs.existsSync(PID_FILE)) {
+        const savedPid = parseInt(fs.readFileSync(PID_FILE, "utf-8").trim(), 10);
+        if (savedPid && isProcessAlive(savedPid)) {
+          // Orphan MITM process still alive — reuse it
+          serverPid = savedPid;
+          console.log(`[MITM] Reusing existing process PID ${savedPid}`);
+          await saveMitmSettings(true, sudoPassword);
+          if (sudoPassword) setCachedPassword(sudoPassword);
+          return { running: true, pid: savedPid };
+        } else {
+          fs.unlinkSync(PID_FILE);
+        }
+      }
+    } catch {
+      // Ignore stale PID file errors
+    }
+  }
+
   if (serverProcess && !serverProcess.killed) {
     throw new Error("MITM proxy is already running");
   }
-  
+
+  // Kill any leftover MITM server from a previous failed start attempt
+  await killLeftoverMitm(sudoPassword);
+
+  // Check port 443 availability BEFORE modifying system
+  const portStatus = await checkPort443Free();
+  if (portStatus === "in-use") {
+    const owner = await getPort443Owner();
+    let ownerDesc = "another process";
+    if (owner) {
+      const shortName = owner.name.includes("/")
+        ? owner.name.split("/").filter(Boolean).pop()
+        : owner.name;
+      ownerDesc = `"${shortName}" (PID ${owner.pid})`;
+    }
+    throw new Error(
+      `Port 443 is already in use by ${ownerDesc}. Stop that process first, then retry.`
+    );
+  }
+
   // 1. Generate SSL certificate if not exists
   const certPath = path.join(os.homedir(), ".9router", "mitm", "server.crt");
   if (!fs.existsSync(certPath)) {
     console.log("Generating SSL certificate...");
     await generateCert();
   }
-  
+
   // 2. Install certificate to system keychain
-  await installCert(sudoPassword, certPath);
-  
+  // Skip if db flag says installed AND cert file still exists (same cert in keychain)
+  const settings = _getSettings ? await _getSettings().catch(() => ({})) : {};
+  const certAlreadyInstalled = settings.mitmCertInstalled && fs.existsSync(certPath);
+  if (!certAlreadyInstalled) {
+    await installCert(sudoPassword, certPath);
+    if (_updateSettings) await _updateSettings({ mitmCertInstalled: true }).catch(() => {});
+  }
+
   // 3. Add DNS entry
   console.log("Adding DNS entry...");
   await addDNSEntry(sudoPassword);
-  
-  // 4. Start MITM server (port 443 requires elevated privileges)
+
+  // 4. Spawn MITM server with sudo (port 443 requires root on macOS/Linux)
   console.log("Starting MITM server...");
-  const serverPath = path.join(process.cwd(), "src/mitm/server.js");
 
   if (IS_WIN) {
-    // Windows: spawn via powershell elevated to bind port 443
     const nodePath = process.execPath;
-    const envArgs = `$env:ROUTER_API_KEY='${apiKey}'; $env:NODE_ENV='production'; & '${nodePath}' '${serverPath}'`;
+    const envArgs = `$env:ROUTER_API_KEY='${apiKey}'; $env:NODE_ENV='production'; & '${nodePath}' '${SERVER_PATH}'`;
     serverProcess = spawn("powershell", [
       "-Command",
       `Start-Process powershell -ArgumentList '-NoProfile','-Command','${envArgs.replace(/'/g, "''")}' -Verb RunAs -PassThru`
-    ], {
-      detached: false,
-      stdio: ["ignore", "pipe", "pipe"]
-    });
+    ], { detached: false, stdio: ["ignore", "pipe", "pipe"] });
   } else {
-    serverProcess = spawn("node", [serverPath], {
-      env: {
-        ...process.env,
-        ROUTER_API_KEY: apiKey,
-        NODE_ENV: "production"
-      },
-      detached: false,
-      stdio: ["ignore", "pipe", "pipe"]
-    });
+    // sudo -S: read password from stdin, -E: preserve env vars
+    // Pass ROUTER_API_KEY inline via env=... wrapper to avoid sudo stripping env
+    const inlineCmd = `ROUTER_API_KEY='${apiKey}' NODE_ENV='production' '${process.execPath}' '${SERVER_PATH}'`;
+    serverProcess = spawn(
+      "sudo", ["-S", "-E", "sh", "-c", inlineCmd],
+      { detached: false, stdio: ["pipe", "pipe", "pipe"] }
+    );
+    // Write password then close stdin so sudo proceeds
+    serverProcess.stdin.write(`${sudoPassword}\n`);
+    serverProcess.stdin.end();
   }
-  
+
   serverPid = serverProcess.pid;
-  
-  // Save PID to file
   fs.writeFileSync(PID_FILE, String(serverPid));
-  
-  // Log server output
+
+  let startError = null;
   serverProcess.stdout.on("data", (data) => {
     console.log(`[MITM Server] ${data.toString().trim()}`);
   });
-  
   serverProcess.stderr.on("data", (data) => {
-    console.error(`[MITM Server Error] ${data.toString().trim()}`);
+    const msg = data.toString().trim();
+    // Capture meaningful errors (ignore sudo password prompt noise)
+    if (msg && !msg.includes("Password:") && !msg.includes("password for")) {
+      console.error(`[MITM Server Error] ${msg}`);
+      startError = msg;
+    }
   });
-  
   serverProcess.on("exit", (code) => {
     console.log(`MITM server exited with code ${code}`);
     serverProcess = null;
     serverPid = null;
-    
-    // Remove PID file
-    try {
-      fs.unlinkSync(PID_FILE);
-    } catch (error) {
-      // Ignore
-    }
+    try { fs.unlinkSync(PID_FILE); } catch { /* ignore */ }
   });
-  
-  // Wait and verify server actually started
+
+  // Wait up to 8s — sudo + Node startup takes longer than plain spawn
   const started = await new Promise((resolve) => {
     let resolved = false;
-    const timeout = setTimeout(() => {
-      if (!resolved) { resolved = true; resolve(true); }
-    }, 2000);
-
-    serverProcess.on("exit", (code) => {
-      clearTimeout(timeout);
-      if (!resolved) { resolved = true; resolve(false); }
-    });
-
-    // Check stderr for error messages
-    serverProcess.stderr.on("data", (data) => {
-      const msg = data.toString().trim();
-      if (msg.includes("Port") && msg.includes("already in use")) {
-        clearTimeout(timeout);
-        if (!resolved) { resolved = true; resolve(false); }
-      }
-    });
+    const done = (val) => { if (!resolved) { resolved = true; resolve(val); } };
+    const timeout = setTimeout(() => done(true), 8000);
+    serverProcess.once("exit", () => { clearTimeout(timeout); done(false); });
   });
 
   if (!started) {
-    throw new Error("MITM server failed to start (port 443 may be in use)");
+    try { await removeDNSEntry(sudoPassword); } catch { /* best effort */ }
+    const reason = startError || "Check sudo password or port 443 access.";
+    throw new Error(`MITM server failed to start. ${reason}`);
   }
 
-  return {
-    running: true,
-    pid: serverPid
-  };
+  await saveMitmSettings(true, sudoPassword);
+  if (sudoPassword) setCachedPassword(sudoPassword);
+
+  return { running: true, pid: serverPid };
 }
 
 /**
@@ -189,19 +424,15 @@ async function startMitm(apiKey, sudoPassword) {
  * @param {string} sudoPassword - Sudo password for DNS cleanup
  */
 async function stopMitm(sudoPassword) {
-  // 1. Kill server process (in-memory or from PID file)
   const proc = serverProcess;
   if (proc && !proc.killed) {
     console.log("Stopping MITM server...");
     killProcess(proc.pid, false);
     await new Promise(resolve => setTimeout(resolve, 1000));
-    if (isProcessAlive(proc.pid)) {
-      killProcess(proc.pid, true);
-    }
+    if (isProcessAlive(proc.pid)) killProcess(proc.pid, true);
     serverProcess = null;
     serverPid = null;
   } else {
-    // Fallback: kill by PID file
     try {
       if (fs.existsSync(PID_FILE)) {
         const savedPid = parseInt(fs.readFileSync(PID_FILE, "utf-8").trim(), 10);
@@ -209,33 +440,22 @@ async function stopMitm(sudoPassword) {
           console.log(`Killing MITM server (PID: ${savedPid})...`);
           killProcess(savedPid, false);
           await new Promise(resolve => setTimeout(resolve, 1000));
-          if (isProcessAlive(savedPid)) {
-            killProcess(savedPid, true);
-          }
+          if (isProcessAlive(savedPid)) killProcess(savedPid, true);
         }
       }
-    } catch {
-      // Ignore
-    }
+    } catch { /* ignore */ }
     serverProcess = null;
     serverPid = null;
   }
-  
-  // 2. Remove DNS entry
+
   console.log("Removing DNS entry...");
   await removeDNSEntry(sudoPassword);
-  
-  // 3. Remove PID file
-  try {
-    fs.unlinkSync(PID_FILE);
-  } catch (error) {
-    // Ignore
-  }
-  
-  return {
-    running: false,
-    pid: null
-  };
+
+  try { fs.unlinkSync(PID_FILE); } catch { /* ignore */ }
+
+  await saveMitmSettings(false, null);
+
+  return { running: false, pid: null };
 }
 
 module.exports = {
@@ -243,5 +463,7 @@ module.exports = {
   startMitm,
   stopMitm,
   getCachedPassword,
-  setCachedPassword
+  setCachedPassword,
+  loadEncryptedPassword,
+  initDbHooks,
 };

src/mitm/server.js

@@ -23,10 +23,16 @@ if (!API_KEY) {
 
 // Load SSL certificates
 const certDir = path.join(os.homedir(), ".9router", "mitm");
-const sslOptions = {
-  key: fs.readFileSync(path.join(certDir, "server.key")),
-  cert: fs.readFileSync(path.join(certDir, "server.crt"))
-};
+let sslOptions;
+try {
+  sslOptions = {
+    key: fs.readFileSync(path.join(certDir, "server.key")),
+    cert: fs.readFileSync(path.join(certDir, "server.crt"))
+  };
+} catch (e) {
+  console.error(`❌ SSL cert not found in ${certDir}: ${e.message}`);
+  process.exit(1);
+}
 
 // Chat endpoints that should be intercepted
 const CHAT_URL_PATTERNS = [":generateContent", ":streamGenerateContent"];
@@ -146,12 +152,10 @@ async function intercept(req, res, bodyBuffer, mappedModel) {
       throw new Error(`9Router ${response.status}: ${errText}`);
     }
 
-    res.writeHead(200, {
-      "Content-Type": "text/event-stream",
-      "Cache-Control": "no-cache",
-      "Connection": "keep-alive",
-      "X-Accel-Buffering": "no"
-    });
+    const ct = response.headers.get("content-type") || "application/json";
+    const resHeaders = { "Content-Type": ct, "Cache-Control": "no-cache", "Connection": "keep-alive" };
+    if (ct.includes("text/event-stream")) resHeaders["X-Accel-Buffering"] = "no";
+    res.writeHead(200, resHeaders);
 
     const reader = response.body.getReader();
     const decoder = new TextDecoder();