feat(opencode-go): add muse-spark-1.3-contributor and fix parallel tool calls on Responses paths (#3819)
- Add muse-spark-1.3-contributor as responses-only model on OpenCode Go with dedicated executor - Key Responses→chat streaming tool calls by item_id to prevent parallel tool calls merging into index 0 - Standardize tool coercions and call_id clamping in Responses API translation
This commit is contained in:
Sina Sadeghi
@@ -27,6 +27,7 @@ describe("OpenCode Go model catalog", () => {
|
||||
"mimo-v2.5", "mimo-v2.5-pro",
|
||||
"minimax-m3", "minimax-m2.7", "minimax-m2.5",
|
||||
"qwen3.7-max", "qwen3.7-plus", "qwen3.6-plus",
|
||||
"muse-spark-1.3-contributor",
|
||||
]);
|
||||
});
|
||||
});
|
||||
|
||||
165
tests/unit/opencode-go-muse-spark-responses.test.js
Normal file
165
tests/unit/opencode-go-muse-spark-responses.test.js
Normal file
@@ -0,0 +1,165 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { PROVIDER_MODELS, getModelTargetFormat, getModelSupportedFormats } from "../../open-sse/config/providerModels.js";
|
||||
import { PROVIDERS } from "../../open-sse/config/providers.js";
|
||||
import { resolveTransport } from "../../open-sse/services/provider.js";
|
||||
import { getCapabilitiesForModel } from "../../open-sse/providers/capabilities.js";
|
||||
import { getThinkingLevels } from "../../open-sse/providers/thinkingLevels.js";
|
||||
import { getExecutor } from "../../open-sse/executors/index.js";
|
||||
import { OpenCodeGoExecutor } from "../../open-sse/executors/opencode-go.js";
|
||||
import { FORMATS } from "../../open-sse/translator/formats.js";
|
||||
import "../translator/registerAll.js";
|
||||
import { translateRequest } from "../../open-sse/translator/index.js";
|
||||
|
||||
const MODEL = "muse-spark-1.3-contributor";
|
||||
const PROVIDER = "opencode-go";
|
||||
|
||||
// Mirror of chatCore's per-model transport guard
|
||||
function pickTransport(provider, sourceFormat, alias, model) {
|
||||
const supported = getModelSupportedFormats(alias, model);
|
||||
const rt = resolveTransport(provider, sourceFormat);
|
||||
return supported?.includes(sourceFormat) ? rt : null;
|
||||
}
|
||||
|
||||
describe("ocg/muse-spark-1.3-contributor catalog", () => {
|
||||
it("is registered responses-only", () => {
|
||||
const entry = (PROVIDER_MODELS["opencode-go"] || []).find((m) => m.id === MODEL);
|
||||
expect(entry).toBeDefined();
|
||||
expect(entry.targetFormat).toBe("openai-responses");
|
||||
expect(getModelSupportedFormats("opencode-go", MODEL)).toEqual(["openai-responses"]);
|
||||
expect(getModelTargetFormat("ocg", MODEL)).toBe(FORMATS.OPENAI_RESPONSES);
|
||||
expect(getModelTargetFormat("opencode-go", MODEL)).toBe(FORMATS.OPENAI_RESPONSES);
|
||||
});
|
||||
|
||||
it("never takes the sourceFormat-matched transport (always translates)", () => {
|
||||
expect(pickTransport(PROVIDER, "openai", "opencode-go", MODEL)).toBeNull();
|
||||
expect(pickTransport(PROVIDER, "claude", "opencode-go", MODEL)).toBeNull();
|
||||
expect(pickTransport(PROVIDER, "openai-responses", "opencode-go", MODEL)?.baseUrl)
|
||||
.toBe("https://opencode.ai/zen/go/v1/responses");
|
||||
});
|
||||
|
||||
it("advertises reasoning via the shared muse-spark pattern", () => {
|
||||
expect(getCapabilitiesForModel(PROVIDER, MODEL)).toMatchObject({
|
||||
vision: true,
|
||||
reasoning: true,
|
||||
thinkingFormat: "openai",
|
||||
});
|
||||
expect(getThinkingLevels(PROVIDER, MODEL)).toContain("xhigh");
|
||||
});
|
||||
});
|
||||
|
||||
describe("OpenCodeGoExecutor routing + sanitization", () => {
|
||||
it("is wired for opencode-go and routes muse-spark to /responses", () => {
|
||||
expect(getExecutor("opencode-go")).toBeInstanceOf(OpenCodeGoExecutor);
|
||||
const ex = new OpenCodeGoExecutor();
|
||||
expect(ex.buildUrl(MODEL)).toBe("https://opencode.ai/zen/go/v1/responses");
|
||||
// Even a stale runtimeTransport must not drag muse-spark onto chat/messages
|
||||
expect(ex.buildUrl(MODEL, true, 0, {
|
||||
runtimeTransport: { baseUrl: "https://opencode.ai/zen/go/v1/chat/completions" },
|
||||
})).toBe("https://opencode.ai/zen/go/v1/responses");
|
||||
});
|
||||
|
||||
it("leaves non-muse models on the default/runtime transport", () => {
|
||||
const ex = new OpenCodeGoExecutor();
|
||||
expect(ex.buildUrl("kimi-k2.6")).toBe("https://opencode.ai/zen/go/v1/chat/completions");
|
||||
expect(ex.buildUrl("minimax-m3", true, 0, {
|
||||
runtimeTransport: { baseUrl: "https://opencode.ai/zen/go/v1/messages" },
|
||||
})).toBe("https://opencode.ai/zen/go/v1/messages");
|
||||
});
|
||||
|
||||
it("normalizes caps + reasoning and coerces tool items exactly once", () => {
|
||||
const ex = new OpenCodeGoExecutor();
|
||||
const args = { path: "a\"b\nc\\d", emoji: "🚀 ü", nested: { q: "x'y\"z" } };
|
||||
const body = {
|
||||
model: MODEL,
|
||||
input: [
|
||||
{ type: "message", role: "user", content: [{ type: "input_text", text: "hi" }] },
|
||||
{ type: "function_call", call_id: "x".repeat(100), name: "read", arguments: args },
|
||||
{ type: "function_call", call_id: "bad", name: " ", arguments: "{}" },
|
||||
{ type: "function_call", call_id: "frag", name: "exec", arguments: "{not json" },
|
||||
{ type: "function_call_output", call_id: "c1", output: { ok: true, text: "héllo \"w\"" } },
|
||||
{ type: "function_call_output", call_id: "c2", output: null },
|
||||
],
|
||||
tools: [
|
||||
{ type: "function", function: { name: "read", description: "r", parameters: { type: "object", properties: {} } } },
|
||||
{ type: "function", function: { name: " ", parameters: {} } },
|
||||
],
|
||||
max_tokens: 2048,
|
||||
reasoning_effort: "high",
|
||||
};
|
||||
const out = ex.transformRequest(MODEL, body, true, {});
|
||||
expect(out.max_output_tokens).toBe(2048);
|
||||
expect(out.max_tokens).toBeUndefined();
|
||||
expect(out.reasoning).toEqual({ effort: "high", summary: "auto" });
|
||||
expect(out.stream).toBe(true);
|
||||
expect(out.store).toBe(false);
|
||||
// nameless declaration dropped, nameless call dropped
|
||||
expect(out.tools.map((t) => t.name)).toEqual(["read"]);
|
||||
const calls = out.input.filter((i) => i.type === "function_call");
|
||||
expect(calls.map((c) => c.name)).toEqual(["read", "exec"]);
|
||||
// overlong id clamped, object args stringified exactly once
|
||||
expect(calls[0].call_id).toHaveLength(64);
|
||||
expect(JSON.parse(calls[0].arguments)).toEqual(args);
|
||||
// invalid fragment coerced, never double-encoded
|
||||
expect(calls[1].arguments).toBe("{}");
|
||||
const outputs = out.input.filter((i) => i.type === "function_call_output");
|
||||
expect(JSON.parse(outputs[0].output)).toEqual({ ok: true, text: "héllo \"w\"" });
|
||||
expect(outputs[1].output).toBe("");
|
||||
});
|
||||
});
|
||||
|
||||
describe("chat/claude clients translate to Responses without breaking tools", () => {
|
||||
const tricky = { cmd: "echo \"hi\"\nnewline\ttab\\slash", emoji: "🎉 café naïve", nested: { a: [1, "x'y"] } };
|
||||
|
||||
it("openai chat → responses keeps arguments parseable", () => {
|
||||
const translated = translateRequest(
|
||||
FORMATS.OPENAI,
|
||||
FORMATS.OPENAI_RESPONSES,
|
||||
MODEL,
|
||||
{
|
||||
model: `ocg/${MODEL}`,
|
||||
messages: [
|
||||
{ role: "system", content: [{ type: "text", text: "sys one" }, { type: "text", text: "sys two" }] },
|
||||
{ role: "user", content: "run it" },
|
||||
{
|
||||
role: "assistant", content: null,
|
||||
tool_calls: [{ id: "call_1", type: "function", function: { name: "exec", arguments: tricky } }],
|
||||
},
|
||||
{ role: "tool", tool_call_id: "call_1", content: tricky },
|
||||
],
|
||||
tools: [{ type: "function", function: { name: "exec", description: "e", parameters: { type: "object", properties: {} } } }],
|
||||
},
|
||||
true, {}, PROVIDER,
|
||||
);
|
||||
expect(translated.instructions).toBe("sys one\nsys two");
|
||||
const fc = translated.input.find((i) => i.type === "function_call");
|
||||
expect(JSON.parse(fc.arguments)).toEqual(tricky);
|
||||
const fco = translated.input.find((i) => i.type === "function_call_output");
|
||||
expect(JSON.parse(fco.output)).toEqual(tricky);
|
||||
});
|
||||
|
||||
it("claude messages → responses double-hop keeps tool input intact", () => {
|
||||
const viaOpenAI = translateRequest(FORMATS.CLAUDE, FORMATS.OPENAI, MODEL, {
|
||||
system: "be terse",
|
||||
messages: [
|
||||
{ role: "user", content: [{ type: "text", text: "go" }] },
|
||||
{
|
||||
role: "assistant",
|
||||
content: [
|
||||
{ type: "text", text: "calling" },
|
||||
{ type: "tool_use", id: "tu_1", name: "exec", input: tricky },
|
||||
],
|
||||
},
|
||||
{
|
||||
role: "user",
|
||||
content: [{ type: "tool_result", tool_use_id: "tu_1", content: [{ type: "text", text: JSON.stringify(tricky) }] }],
|
||||
},
|
||||
],
|
||||
tools: [{ name: "exec", description: "e", input_schema: { type: "object", properties: {} } }],
|
||||
}, true, {}, PROVIDER);
|
||||
const translated = translateRequest(FORMATS.OPENAI, FORMATS.OPENAI_RESPONSES, MODEL, viaOpenAI, true, {}, PROVIDER);
|
||||
const fc = translated.input.find((i) => i.type === "function_call");
|
||||
expect(JSON.parse(fc.arguments)).toEqual(tricky);
|
||||
const fco = translated.input.find((i) => i.type === "function_call_output");
|
||||
expect(JSON.parse(fco.output)).toEqual(tricky);
|
||||
});
|
||||
});
|
||||
140
tests/unit/responses-parallel-tool-calls.test.js
Normal file
140
tests/unit/responses-parallel-tool-calls.test.js
Normal file
@@ -0,0 +1,140 @@
|
||||
// Parallel function_calls from a Responses upstream must stay on separate
|
||||
// chat tool_calls indices. Regression: response/openai-responses.js attributed
|
||||
// every arguments delta to the positional toolCallIndex (advanced only on
|
||||
// output_item.done), so all-added-then-deltas ordering concatenated N JSON
|
||||
// payloads into index 0 and clients failed with InputValidationError.
|
||||
import { describe, expect, it } from "vitest";
|
||||
import "../translator/registerAll.js";
|
||||
import { openaiResponsesToOpenAIResponse } from "../../open-sse/translator/response/openai-responses.js";
|
||||
import { initState, translateResponse } from "../../open-sse/translator/index.js";
|
||||
import { FORMATS } from "../../open-sse/translator/formats.js";
|
||||
|
||||
const added = (id, call_id, name, type = "function_call") => ({
|
||||
type: "response.output_item.added",
|
||||
item: { id, type, call_id, name, arguments: "" },
|
||||
});
|
||||
const delta = (item_id, text) => ({
|
||||
type: "response.function_call_arguments.delta",
|
||||
item_id,
|
||||
delta: text,
|
||||
});
|
||||
const done = (id, call_id, name) => ({
|
||||
type: "response.output_item.done",
|
||||
item: { id, type: "function_call", call_id, name },
|
||||
});
|
||||
|
||||
// Reassemble translated chunks the way an OpenAI client accumulator does.
|
||||
function accumulate(calls, chunks) {
|
||||
for (const chunk of chunks) {
|
||||
if (!chunk) continue;
|
||||
for (const tc of chunk.choices?.[0]?.delta?.tool_calls || []) {
|
||||
const slot = (calls[tc.index] ??= { id: null, name: "", args: "" });
|
||||
if (tc.id) slot.id = tc.id;
|
||||
if (tc.function?.name) slot.name = tc.function.name;
|
||||
if (tc.function?.arguments) slot.args += tc.function.arguments;
|
||||
}
|
||||
}
|
||||
return calls;
|
||||
}
|
||||
|
||||
function runStream(events) {
|
||||
const state = {};
|
||||
const chunks = [];
|
||||
for (const ev of events) {
|
||||
const out = openaiResponsesToOpenAIResponse(ev, state);
|
||||
if (out) chunks.push(out);
|
||||
}
|
||||
const flush = openaiResponsesToOpenAIResponse(null, state);
|
||||
if (flush) chunks.push(flush);
|
||||
return { state, chunks };
|
||||
}
|
||||
|
||||
const PAYLOADS = [
|
||||
'{"file_path":"/docs/PRODUCT.md"}',
|
||||
'{"file_path":"/docs/ROADMAP.md"}',
|
||||
'{"file_path":"/docs/openapi.custom.yaml"}',
|
||||
'{"file_path":"/docs/.gitignore"}',
|
||||
];
|
||||
|
||||
function hostileOrdering() {
|
||||
const events = PAYLOADS.map((_, i) => added(`fc_${i}`, `call_${i}`, "read_file"));
|
||||
// Interleaved deltas AFTER all addeds — the ordering that used to merge all
|
||||
// four payloads into index 0.
|
||||
PAYLOADS.forEach((p, i) => events.push(delta(`fc_${i}`, p.slice(0, 20)), delta(`fc_${i}`, p.slice(20))));
|
||||
PAYLOADS.forEach((_, i) => events.push(done(`fc_${i}`, `call_${i}`, "read_file")));
|
||||
return events;
|
||||
}
|
||||
|
||||
describe("responses parallel tool calls keep their own index", () => {
|
||||
it("all-added-then-deltas ordering yields 4 separately parseable calls", () => {
|
||||
const { chunks } = runStream(hostileOrdering());
|
||||
const calls = accumulate({}, chunks);
|
||||
expect(Object.keys(calls)).toHaveLength(4);
|
||||
PAYLOADS.forEach((p, i) => {
|
||||
expect(calls[i].id).toBe(`call_${i}`);
|
||||
expect(calls[i].name).toBe("read_file");
|
||||
expect(JSON.parse(calls[i].args)).toEqual(JSON.parse(p));
|
||||
});
|
||||
});
|
||||
|
||||
it("sequential ordering still yields indices 0,1 in order", () => {
|
||||
const events = [
|
||||
added("fc_0", "call_0", "read_file"),
|
||||
delta("fc_0", PAYLOADS[0]),
|
||||
done("fc_0", "call_0", "read_file"),
|
||||
added("fc_1", "call_1", "read_file"),
|
||||
delta("fc_1", PAYLOADS[1]),
|
||||
done("fc_1", "call_1", "read_file"),
|
||||
];
|
||||
const { chunks } = runStream(events);
|
||||
const calls = accumulate({}, chunks);
|
||||
expect(Object.keys(calls)).toEqual(["0", "1"]);
|
||||
expect(JSON.parse(calls[0].args)).toEqual(JSON.parse(PAYLOADS[0]));
|
||||
expect(JSON.parse(calls[1].args)).toEqual(JSON.parse(PAYLOADS[1]));
|
||||
});
|
||||
|
||||
it("done carrying full arguments (no deltas) emits them once", () => {
|
||||
const state = {};
|
||||
const out1 = openaiResponsesToOpenAIResponse(added("fc_9", "call_9", "read_file"), state);
|
||||
const out2 = openaiResponsesToOpenAIResponse({
|
||||
type: "response.output_item.done",
|
||||
item: { id: "fc_9", type: "function_call", call_id: "call_9", name: "read_file", arguments: PAYLOADS[0] },
|
||||
}, state);
|
||||
const calls = accumulate({}, [out1, out2]);
|
||||
expect(JSON.parse(calls[0].args)).toEqual(JSON.parse(PAYLOADS[0]));
|
||||
});
|
||||
|
||||
it("deltas without item_id fall back to the most recent call (legacy behavior)", () => {
|
||||
const events = [
|
||||
added("fc_0", "call_0", "read_file"),
|
||||
{ type: "response.function_call_arguments.delta", delta: PAYLOADS[0] },
|
||||
done("fc_0", "call_0", "read_file"),
|
||||
];
|
||||
const { chunks } = runStream(events);
|
||||
const calls = accumulate({}, chunks);
|
||||
expect(JSON.parse(calls[0].args)).toEqual(JSON.parse(PAYLOADS[0]));
|
||||
});
|
||||
});
|
||||
|
||||
describe("responses → claude end-to-end keeps parallel tool_use blocks separate", () => {
|
||||
it("four read_file calls arrive as four parseable tool_use blocks", () => {
|
||||
const state = initState(FORMATS.CLAUDE);
|
||||
const out = [];
|
||||
for (const ev of hostileOrdering()) {
|
||||
for (const r of translateResponse(FORMATS.OPENAI_RESPONSES, FORMATS.CLAUDE, ev, state)) out.push(r);
|
||||
}
|
||||
for (const r of translateResponse(FORMATS.OPENAI_RESPONSES, FORMATS.CLAUDE, null, state)) out.push(r);
|
||||
|
||||
const starts = out.filter((r) => r?.type === "content_block_start" && r?.content_block?.type === "tool_use");
|
||||
expect(starts).toHaveLength(4);
|
||||
const partials = out.filter((r) => r?.delta?.type === "input_json_delta");
|
||||
expect(partials).toHaveLength(4);
|
||||
const bodies = partials.map((r) => JSON.parse(r.delta.partial_json).file_path).sort();
|
||||
expect(bodies).toEqual([
|
||||
"/docs/.gitignore",
|
||||
"/docs/PRODUCT.md",
|
||||
"/docs/ROADMAP.md",
|
||||
"/docs/openapi.custom.yaml",
|
||||
]);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user