Files
9router/tests/unit/commandcode-to-openai.test.js
luulam 9b27ee2611 fix(open-sse): treat CommandCode in-stream error events as request failures
Upstream emits AI SDK v5 {"type":"error"} events inside an HTTP 200 stream.
The translator turned them into fake success content ([CommandCode error: ...]
+ finish_reason stop), so account/model fallback never fired and logs showed
Status: success.

- translator: error events now emit an OpenAI-shaped error chunk (chunk.error)
  instead of content; parseSSEToOpenAIResponse already detects chunk?.error
- executor: peek the first events before committing the response; an early
  error event returns 502 so fallback runs before any byte reaches the client
2026-08-04 23:26:37 +07:00

164 lines
5.4 KiB
JavaScript

/**
* Unit tests for open-sse/translator/response/commandcode-to-openai.js
*
* Verified live against upstream stream (curl, 2026-05-07):
* - tool-input-start: { id, toolName } (id, NOT toolCallId)
* - tool-input-delta: { id, delta } (id, NOT toolCallId; delta, NOT inputTextDelta)
* - tool-input-end: { id }
* - tool-call (final): { toolCallId, toolName, input }
*/
import { describe, it, expect } from "vitest";
import { commandCodeToOpenAIResponse } from "../../open-sse/translator/response/commandcode-to-openai.js";
function feed(events) {
const state = {};
const all = [];
for (const e of events) {
const out = commandCodeToOpenAIResponse(JSON.stringify(e), state);
if (out) for (const c of out) all.push(c);
}
return { state, chunks: all };
}
describe("commandcode-to-openai — text-delta", () => {
it("emits assistant role on first delta then content-only", () => {
const { chunks } = feed([
{ type: "text-delta", text: "Hello" },
{ type: "text-delta", text: " world" },
]);
expect(chunks[0].choices[0].delta.role).toBe("assistant");
expect(chunks[0].choices[0].delta.content).toBe("Hello");
expect(chunks[1].choices[0].delta.role).toBeUndefined();
expect(chunks[1].choices[0].delta.content).toBe(" world");
});
});
describe("commandcode-to-openai — reasoning-delta", () => {
it("maps reasoning-delta to reasoning_content delta", () => {
const { chunks } = feed([{ type: "reasoning-delta", text: "thinking..." }]);
expect(chunks[0].choices[0].delta.reasoning_content).toBe("thinking...");
});
});
describe("commandcode-to-openai — tool-input-* with id field (live schema)", () => {
it("registers tool index using event.id (NOT toolCallId)", () => {
const { chunks } = feed([
{ type: "tool-input-start", id: "call_X", toolName: "Bash" },
{ type: "tool-input-delta", id: "call_X", delta: '{"cmd' },
{ type: "tool-input-delta", id: "call_X", delta: '":"ls"}' },
]);
// First chunk emits tool_calls with id
const startChunk = chunks[0].choices[0].delta.tool_calls[0];
expect(startChunk.id).toBe("call_X");
expect(startChunk.function.name).toBe("Bash");
// Subsequent deltas accumulate arguments
expect(chunks[1].choices[0].delta.tool_calls[0].function.arguments).toBe(
'{"cmd',
);
expect(chunks[2].choices[0].delta.tool_calls[0].function.arguments).toBe(
'":"ls"}',
);
});
it("ignores tool-input-delta when id is unknown (no prior start)", () => {
const { chunks } = feed([
{ type: "tool-input-delta", id: "unknown", delta: "x" },
]);
expect(chunks.length).toBe(0);
});
});
describe("commandcode-to-openai — final tool-call event", () => {
it("does NOT re-emit tool_calls when tool-input-* deltas already fired", () => {
const { chunks } = feed([
{ type: "tool-input-start", id: "call_Y", toolName: "Write" },
{ type: "tool-input-delta", id: "call_Y", delta: '{"file":"a"}' },
{
type: "tool-call",
toolCallId: "call_Y",
toolName: "Write",
input: { file: "a" },
},
]);
// Should be exactly 2 chunks (start + delta), no duplicate from final tool-call
expect(chunks.length).toBe(2);
});
it("emits a consolidated tool_calls when only the final tool-call event arrives", () => {
const { chunks } = feed([
{
type: "tool-call",
toolCallId: "call_Z",
toolName: "Read",
input: { path: "/x" },
},
]);
expect(chunks.length).toBe(1);
const tc = chunks[0].choices[0].delta.tool_calls[0];
expect(tc.id).toBe("call_Z");
expect(tc.function.name).toBe("Read");
expect(tc.function.arguments).toBe(JSON.stringify({ path: "/x" }));
});
});
describe("commandcode-to-openai — finish", () => {
it("emits a final chunk with finish_reason=tool_calls when finishReason is tool-calls", () => {
const { chunks } = feed([
{ type: "tool-input-start", id: "call_F", toolName: "Bash" },
{ type: "tool-input-delta", id: "call_F", delta: "{}" },
{ type: "finish-step", finishReason: "tool-calls" },
{ type: "finish" },
]);
const last = chunks[chunks.length - 1];
expect(last.choices[0].finish_reason).toBe("tool_calls");
});
it("includes usage on the final chunk when totalUsage provided", () => {
const { chunks } = feed([
{ type: "text-delta", text: "hi" },
{
type: "finish-step",
finishReason: "stop",
usage: { inputTokens: 10, outputTokens: 5, totalTokens: 15 },
},
{
type: "finish",
totalUsage: { inputTokens: 10, outputTokens: 5, totalTokens: 15 },
},
]);
const last = chunks[chunks.length - 1];
expect(last.usage).toEqual({
prompt_tokens: 10,
completion_tokens: 5,
total_tokens: 15,
});
});
});
describe("commandcode-to-openai — error event", () => {
it("emits an OpenAI-shaped error chunk instead of fake success content", () => {
const { chunks } = feed([
{ type: "error", error: { type: "server_error", message: "Boom" } },
]);
expect(chunks[0].error).toEqual({ message: "Boom", type: "server_error" });
expect(chunks[0].choices[0].delta.content).toBeUndefined();
expect(chunks[1].choices[0].finish_reason).toBe("stop");
expect(JSON.stringify(chunks)).not.toContain("[CommandCode error:");
});
it("keeps the stream terminal so clients do not hang waiting for more", () => {
const { chunks } = feed([
{ type: "start" },
{
type: "error",
error: { type: "server_error", message: "Network connection lost." },
},
]);
expect(chunks[0].error.message).toBe("Network connection lost.");
expect(chunks[1].choices[0].finish_reason).toBe("stop");
});
});