d06e0d26c6
Codex Responses Lite clients routed to a chat-native OpenAI-compatible provider lost tool use in three places: non-streaming Chat responses leaked the raw chat.completion envelope instead of Responses output items, internal reasoning continuity fields leaked into the outbound Chat body causing some upstreams to reject the request, and the Responses to Chat request translator ignored additional_tools, custom_tool_call, and custom_tool_call_output items entirely. Also fixes apiType (chat vs responses) for openai-compatible nodes being resolved from the immutable provider ID instead of the stored node config, so editing a node's API Type had no runtime effect.
76 lines
3.1 KiB
JavaScript
76 lines
3.1 KiB
JavaScript
// Real Codex CLI requests (OpenAI Responses API: { input:[], instructions }) → providers.
|
|
import { describe, it, expect } from "vitest";
|
|
import "./registerAll.js";
|
|
import { translateRequest } from "../../open-sse/translator/index.js";
|
|
import { FORMATS } from "../../open-sse/translator/formats.js";
|
|
|
|
const R2O = (body) => translateRequest(FORMATS.OPENAI_RESPONSES, FORMATS.OPENAI, "m", body, true, null, null);
|
|
const O2R = (body) => translateRequest(FORMATS.OPENAI, FORMATS.OPENAI_RESPONSES, "m", body, true, null, null);
|
|
|
|
describe("Codex CLI Responses → OpenAI", () => {
|
|
// openai-responses.js:103 — function_call with empty name skipped, can leave tool_calls: []
|
|
// KNOWN BUG: empty tool_calls array is rejected by OpenAI/Codex
|
|
it.fails("assistant has no empty tool_calls array when all names are empty", () => {
|
|
const out = R2O({
|
|
input: [
|
|
{ type: "function_call", call_id: "c1", name: "", arguments: "{}" },
|
|
],
|
|
});
|
|
const asst = out.messages.find((m) => m.role === "assistant" && m.tool_calls);
|
|
expect(asst?.tool_calls?.length ?? 0, "empty tool_calls[] produced").toBeGreaterThan(0);
|
|
});
|
|
|
|
it("function_call arguments end up as a string", () => {
|
|
const out = R2O({
|
|
input: [{ type: "function_call", call_id: "c1", name: "f", arguments: { a: 1 } }],
|
|
});
|
|
const asst = out.messages.find((m) => m.tool_calls);
|
|
expect(typeof asst.tool_calls[0].function.arguments).toBe("string");
|
|
});
|
|
|
|
// openai-responses.js:75-77 — input_image uses file_id as raw url
|
|
// KNOWN BUG
|
|
it.fails("input_image with file_id is not used as a raw url", () => {
|
|
const out = R2O({
|
|
input: [{ type: "message", role: "user", content: [
|
|
{ type: "input_image", file_id: "file-abc" },
|
|
] }],
|
|
});
|
|
const userMsg = out.messages.find((m) => m.role === "user");
|
|
const img = Array.isArray(userMsg?.content) ? userMsg.content.find((c) => c.type === "image_url") : null;
|
|
// A bare file_id is not a valid image URL
|
|
expect(img?.image_url?.url === "file-abc").toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("OpenAI → Codex Responses (reverse)", () => {
|
|
it("maps developer messages to Responses API instructions", () => {
|
|
const out = O2R({
|
|
messages: [
|
|
{ role: "developer", content: "Follow the project rules." },
|
|
{ role: "user", content: "Hello" },
|
|
],
|
|
});
|
|
|
|
expect(out.instructions).toBe("Follow the project rules.");
|
|
expect(out.input).toEqual([
|
|
{ type: "message", role: "user", content: [{ type: "input_text", text: "Hello" }] },
|
|
]);
|
|
});
|
|
|
|
// openai-responses.js:13 — clampCallId NOT applied on Responses→Chat; but here Chat→Responses must clamp
|
|
it("call_id longer than 64 chars is clamped", () => {
|
|
const longId = "call_" + "x".repeat(80);
|
|
const out = O2R({
|
|
messages: [
|
|
{ role: "assistant", content: null, tool_calls: [
|
|
{ id: longId, type: "function", function: { name: "f", arguments: "{}" } },
|
|
] },
|
|
{ role: "tool", tool_call_id: longId, content: "ok" },
|
|
],
|
|
});
|
|
const fc = out.input.find((i) => i.type === "function_call");
|
|
expect(fc.call_id.length).toBeLessThanOrEqual(64);
|
|
});
|
|
});
|