From 051dc4296d66bb347cb0109af7262259ecfc6b5d Mon Sep 17 00:00:00 2001 From: Saul-Mirone Date: Mon, 26 May 2025 08:37:32 +0000 Subject: [PATCH] fix(editor): limit at members list length (#12529) Closes: BS-3009 ## Summary by CodeRabbit - **New Features** - The mention members menu now displays up to three members, with a localized hint indicating the number of additional hidden members. - **Localization** - Added a new translation key for the overflow members hint in the English language pack. - **Chores** - Updated translation completeness statistics for the "es-CL" locale. --- .../core/src/modules/at-menu-config/services/index.ts | 8 ++++++++ packages/frontend/i18n/src/i18n-completenesses.json | 2 +- packages/frontend/i18n/src/i18n.gen.ts | 6 ++++++ packages/frontend/i18n/src/resources/en.json | 1 + 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/frontend/core/src/modules/at-menu-config/services/index.ts b/packages/frontend/core/src/modules/at-menu-config/services/index.ts index 82ff87523..b7472c53b 100644 --- a/packages/frontend/core/src/modules/at-menu-config/services/index.ts +++ b/packages/frontend/core/src/modules/at-menu-config/services/index.ts @@ -594,6 +594,14 @@ export class AtMenuConfigService extends Service { items, loading: this.memberSearchService.isLoading$.signal, hidden, + maxDisplay: 3, + overflowText: computed(() => { + const totalCount = this.memberSearchService.result$.signal.value.length; + const remainingCount = totalCount - 3; + return I18n.t('com.affine.editor.at-menu.more-members-hint', { + count: remainingCount, + }); + }), }; } diff --git a/packages/frontend/i18n/src/i18n-completenesses.json b/packages/frontend/i18n/src/i18n-completenesses.json index 3d1521714..5326f926c 100644 --- a/packages/frontend/i18n/src/i18n-completenesses.json +++ b/packages/frontend/i18n/src/i18n-completenesses.json @@ -6,7 +6,7 @@ "el-GR": 94, "en": 100, "es-AR": 94, - "es-CL": 96, + "es-CL": 95, "es": 94, "fa": 94, "fr": 94, diff --git a/packages/frontend/i18n/src/i18n.gen.ts b/packages/frontend/i18n/src/i18n.gen.ts index 863de408e..7d71fc5cd 100644 --- a/packages/frontend/i18n/src/i18n.gen.ts +++ b/packages/frontend/i18n/src/i18n.gen.ts @@ -7418,6 +7418,12 @@ export function useAFFiNEI18N(): { ["com.affine.editor.at-menu.more-docs-hint"](options: { readonly count: string; }): string; + /** + * `{{count}} more members` + */ + ["com.affine.editor.at-menu.more-members-hint"](options: { + readonly count: string; + }): string; /** * `Journal` */ diff --git a/packages/frontend/i18n/src/resources/en.json b/packages/frontend/i18n/src/resources/en.json index 964584059..5b3b8b1f3 100644 --- a/packages/frontend/i18n/src/resources/en.json +++ b/packages/frontend/i18n/src/resources/en.json @@ -1844,6 +1844,7 @@ "com.affine.editor.at-menu.create-edgeless": "New \"{{name}}\" edgeless", "com.affine.editor.at-menu.import": "Import", "com.affine.editor.at-menu.more-docs-hint": "{{count}} more docs", + "com.affine.editor.at-menu.more-members-hint": "{{count}} more members", "com.affine.editor.at-menu.journal": "Journal", "com.affine.editor.at-menu.date-picker": "Select a specific date", "com.affine.editor.at-menu.mention-members": "Mention Members",