feat(core): remove workspace selectors in settings (#9705)

fix AF-2119

tests/affine-cloud/e2e/workspace.spec.ts

@@ -58,7 +58,7 @@ test('should have pagination in member list', async ({ page }) => {
   );
 
   await openSettingModal(page);
-  await openWorkspaceSettingPanel(page, 'test');
+  await openWorkspaceSettingPanel(page);
 
   await page.waitForTimeout(1000);
 

tests/affine-desktop/e2e/basic.spec.ts

@@ -121,7 +121,7 @@ test('delete workspace', async ({ page }) => {
   // });
   await page.waitForTimeout(1000);
   await clickSideBarSettingButton(page);
-  await page.getByTestId('current-workspace-label').click();
+  await page.getByTestId('workspace-list-item-workspace:preference').click();
   await expect(page.getByTestId('workspace-name-input')).toHaveValue(
     'Delete Me'
   );

tests/affine-desktop/e2e/workspace.spec.ts

@@ -42,7 +42,7 @@ test('export then add', async ({ page, appInfo, workspace }) => {
   const newWorkspaceName = 'new-test-name';
 
   // goto workspace setting
-  await page.getByTestId('workspace-list-item').click();
+  await page.getByTestId('workspace-list-item-workspace:preference').click();
   const input = page.getByTestId('workspace-name-input');
   await expect(input).toBeVisible();
 

tests/affine-local/e2e/local-first-avatar.spec.ts

@@ -24,7 +24,7 @@ test('should create a page with a local first avatar and remove it', async ({
     .nth(1)
     .click({ position: { x: 10, y: 10 } });
   await page.getByTestId('settings-modal-trigger').click();
-  await page.getByTestId('current-workspace-label').click();
+  await page.getByTestId('workspace-list-item-workspace:preference').click();
   await page
     .getByTestId('upload-avatar')
     .setInputFiles(ProjectRoot.join('tests', 'fixtures', 'blue.png').value);
@@ -61,7 +61,7 @@ test('should create a page with a local first avatar and remove it', async ({
 
   // Click remove button to remove workspace avatar
   await page.getByTestId('settings-modal-trigger').click();
-  await page.getByTestId('current-workspace-label').click();
+  await page.getByTestId('workspace-list-item-workspace:preference').click();
   await page.getByTestId('workspace-setting-avatar').hover();
   await page.getByTestId('workspace-setting-remove-avatar-button').click();
   await page.mouse.click(0, 0);

tests/affine-local/e2e/local-first-delete-workspace.spec.ts

@@ -26,7 +26,7 @@ test('Create new workspace, then delete it', async ({ page, workspace }) => {
     'Test Workspace'
   );
   await openSettingModal(page);
-  await openWorkspaceSettingPanel(page, 'Test Workspace');
+  await openWorkspaceSettingPanel(page);
   await page.getByTestId('delete-workspace-button').click();
   await expect(
     page.locator('.affine-notification-center').first()
@@ -64,7 +64,7 @@ test('Delete last workspace', async ({ page }) => {
     node => node.textContent
   );
   await openSettingModal(page);
-  await openWorkspaceSettingPanel(page, currentWorkspaceName as string);
+  await openWorkspaceSettingPanel(page);
   await page.getByTestId('delete-workspace-button').click();
   await page
     .getByTestId('delete-workspace-input')

tests/affine-local/e2e/settings.spec.ts

@@ -10,7 +10,6 @@ import {
   openSettingModal,
   openShortcutsPanel,
 } from '@affine-test/kit/utils/setting';
-import { createLocalWorkspace } from '@affine-test/kit/utils/workspace';
 import { expect } from '@playwright/test';
 
 test('Open settings modal', async ({ page }) => {
@@ -104,21 +103,3 @@ test('Open experimental features panel', async ({ page }) => {
   const settings = page.getByTestId('experimental-settings');
   await expect(settings).toBeVisible();
 });
-
-test('Different workspace should have different name in the setting panel', async ({
-  page,
-}) => {
-  await openHomePage(page);
-  await waitForEditorLoad(page);
-  await createLocalWorkspace({ name: 'New Workspace 2' }, page);
-  await createLocalWorkspace({ name: 'New Workspace 3' }, page);
-  await openSettingModal(page);
-  await page.getByTestId('current-workspace-label').click();
-  await expect(page.getByTestId('workspace-name-input')).toHaveValue(
-    'New Workspace 3'
-  );
-  await page.getByText('New Workspace 2').click();
-  await expect(page.getByTestId('workspace-name-input')).toHaveValue(
-    'New Workspace 2'
-  );
-});

tests/kit/src/utils/cloud.ts

@@ -282,7 +282,7 @@ export async function loginUserDirectly(
 
 export async function enableCloudWorkspace(page: Page) {
   await clickSideBarSettingButton(page);
-  await page.getByTestId('current-workspace-label').click();
+  await page.getByTestId('workspace-list-item-workspace:preference').click();
   await page.getByTestId('publish-enable-affine-cloud-button').click();
   await page.getByTestId('confirm-enable-affine-cloud-button').click();
   // wait for upload and delete local workspace

tests/kit/src/utils/properties.ts

@@ -149,9 +149,6 @@ export const expectPropertyOrdering = async (
 
 export const openWorkspaceProperties = async (page: Page) => {
   await page.getByTestId('slider-bar-workspace-setting-button').click();
-  await page
-    .locator('[data-testid="workspace-list-item"] .setting-name')
-    .click();
   await page.getByTestId('workspace-list-item-workspace:properties').click();
 };
 

tests/kit/src/utils/setting.ts

@@ -38,11 +38,11 @@ export async function confirmExperimentalPrompt(page: Page) {
   await page.getByTestId('experimental-confirm-button').click();
 }
 
-export async function openWorkspaceSettingPanel(
-  page: Page,
-  workspaceName: string
-) {
-  await page.getByTestId('settings-sidebar').getByText(workspaceName).click();
+export async function openWorkspaceSettingPanel(page: Page) {
+  await page
+    .getByTestId('settings-sidebar')
+    .getByTestId('workspace-list-item-workspace:preference')
+    .click();
 }
 
 export async function clickUserInfoCard(page: Page) {