luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: infinite call of useEffect on 404 page (#913)

Browse Source
This commit is contained in:
JimmFly
2023-02-09 11:29:53 +08:00
committed by GitHub
parent 5323f659c8
commit 0ccaf2bc45
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/app/src/components/quick-search/index.tsx
View File

@@ -40,7 +40,6 @@ export const QuickSearch = ({ open, onClose }: TransitionsModalProps) => {
// Add ‘⌘+K’ shortcut keys as switches // Add ‘⌘+K’ shortcut keys as switches
useEffect(() => { useEffect(() => {
if (router.pathname.startsWith('/404')) { if (router.pathname.startsWith('/404')) {
triggerQuickSearchModal(false);
return; return;
} }
const down = (e: KeyboardEvent) => { const down = (e: KeyboardEvent) => {
@@ -59,7 +58,7 @@ export const QuickSearch = ({ open, onClose }: TransitionsModalProps) => {
document.addEventListener('keydown', down, { capture: true }); document.addEventListener('keydown', down, { capture: true });
return () => return () =>
document.removeEventListener('keydown', down, { capture: true }); document.removeEventListener('keydown', down, { capture: true });
}, [open, router.pathname, triggerQuickSearchModal]); }, [open, router, triggerQuickSearchModal]);
useEffect(() => { useEffect(() => {
if (router.pathname.startsWith('/public-workspace')) { if (router.pathname.startsWith('/public-workspace')) {
@@ -68,6 +67,12 @@ export const QuickSearch = ({ open, onClose }: TransitionsModalProps) => {
return setIsPublic(false); return setIsPublic(false);
} }
}, [router]); }, [router]);
useEffect(() => {
if (router.pathname.startsWith('/404')) {
return onClose();
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
return ( return (
<Modal <Modal