luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: add key 'Move to Trash' (#1391)

Browse Source
This commit is contained in:
Himself65
2023-03-07 14:21:59 -06:00
committed by GitHub
parent 3b8f7536f3
commit 1362584880
6 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
apps/web/src/components/blocksuite/block-suite-page-list/page-list/OperationCell.tsx
View File

@@ -57,12 +57,13 @@ export const OperationCell: React.FC<OperationCellProps> = ({
{t('Open in new tab')} {t('Open in new tab')}
</MenuItem> </MenuItem>
<MenuItem <MenuItem
data-testid="move-to-trash"
onClick={() => { onClick={() => {
setOpen(true); setOpen(true);
}} }}
icon={<DeleteTemporarilyIcon />} icon={<DeleteTemporarilyIcon />}
> >
{t('Delete')} {t('Move to Trash')}
</MenuItem> </MenuItem>
</> </>
); );

1
packages/i18n/src/resources/en.json
View File

@@ -43,6 +43,7 @@
"Delete permanently?": "Delete permanently?", "Delete permanently?": "Delete permanently?",
"will be moved to Trash": "{{title}} will be moved to Trash", "will be moved to Trash": "{{title}} will be moved to Trash",
"Favorite": "Favorite", "Favorite": "Favorite",
"Move to Trash": "Move to Trash",
"Moved to Trash": "Moved to Trash", "Moved to Trash": "Moved to Trash",
"Permanently deleted": "Permanently deleted", "Permanently deleted": "Permanently deleted",
"restored": "{{title}} restored", "restored": "{{title}} restored",

2
tests/local-first-delete-page.spec.ts
View File

@@ -25,7 +25,7 @@ test.describe('Local first delete page', () => {
.getByRole('button') .getByRole('button')
.first() .first()
.click(); .click();
const deleteBtn = page.getByRole('button', { name: 'Delete' }); const deleteBtn = page.getByTestId('move-to-trash');
await deleteBtn.click(); await deleteBtn.click();
const confirmTip = page.getByText('Delete page?'); const confirmTip = page.getByText('Delete page?');
expect(confirmTip).not.toBeUndefined(); expect(confirmTip).not.toBeUndefined();

2
tests/local-first-restore-page.spec.ts
View File

@@ -25,7 +25,7 @@ test.describe('Local first delete page', () => {
.getByRole('button') .getByRole('button')
.first() .first()
.click(); .click();
const deleteBtn = page.getByRole('button', { name: 'Delete' }); const deleteBtn = page.getByTestId('move-to-trash');
await deleteBtn.click(); await deleteBtn.click();
const confirmTip = page.getByText('Delete page?'); const confirmTip = page.getByText('Delete page?');
expect(confirmTip).not.toBeUndefined(); expect(confirmTip).not.toBeUndefined();

2
tests/local-first-show-delete-modal.spec.ts
View File

@@ -46,7 +46,7 @@ test.describe('Local first delete page', () => {
.getByRole('button') .getByRole('button')
.first() .first()
.click(); .click();
const deleteBtn = page.getByRole('button', { name: 'Delete' }); const deleteBtn = page.getByTestId('move-to-trash');
await deleteBtn.click(); await deleteBtn.click();
const confirmTip = page.getByText('Delete page?'); const confirmTip = page.getByText('Delete page?');
expect(confirmTip).not.toBeUndefined(); expect(confirmTip).not.toBeUndefined();

2
tests/local-first-trash-page.spec.ts
View File

@@ -24,7 +24,7 @@ test.describe('Local first trash page', () => {
.getByRole('button') .getByRole('button')
.first() .first()
.click(); .click();
const deleteBtn = page.getByRole('button', { name: 'Delete' }); const deleteBtn = page.getByTestId('move-to-trash');
await deleteBtn.click(); await deleteBtn.click();
const confirmTip = page.getByText('Delete page?'); const confirmTip = page.getByText('Delete page?');
expect(confirmTip).not.toBeUndefined(); expect(confirmTip).not.toBeUndefined();