luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(editor): workaround empty text in insertText (#10049)

Browse Source 
`sentry-5a32bef4f2724b5f8e6f31791cb20feb`
This commit is contained in:
doodlewind
2025-02-10 07:24:26 +00:00
parent d4f0c53a0c
commit 1d1eab8139
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
blocksuite/framework/inline/src/services/text.ts
View File

@@ -1,5 +1,3 @@
import { BlockSuiteError, ErrorCode } from '@blocksuite/global/exceptions';
import type { InlineEditor } from '../inline-editor.js'; import type { InlineEditor } from '../inline-editor.js';
import type { DeltaInsert, InlineRange } from '../types.js'; import type { DeltaInsert, InlineRange } from '../types.js';
import type { BaseTextAttributes } from '../utils/base-attributes.js'; import type { BaseTextAttributes } from '../utils/base-attributes.js';
@@ -70,19 +68,14 @@ export class InlineTextService<TextAttributes extends BaseTextAttributes> {
): void => { ): void => {
if (this.editor.isReadonly) return; if (this.editor.isReadonly) return;
if (!text || !text.length) return;
if (this.editor.attributeService.marks) { if (this.editor.attributeService.marks) {
attributes = { ...attributes, ...this.editor.attributeService.marks }; attributes = { ...attributes, ...this.editor.attributeService.marks };
} }
const normalizedAttributes = const normalizedAttributes =
this.editor.attributeService.normalizeAttributes(attributes); this.editor.attributeService.normalizeAttributes(attributes);
if (!text || !text.length) {
throw new BlockSuiteError(
ErrorCode.InlineEditorError,
'text must not be empty'
);
}
this.transact(() => { this.transact(() => {
this.yText.delete(inlineRange.index, inlineRange.length); this.yText.delete(inlineRange.index, inlineRange.length);
this.yText.insert(inlineRange.index, text, normalizedAttributes); this.yText.insert(inlineRange.index, text, normalizedAttributes);