From 2ae3c3e2cdf97facb75bf359aa5bd51a17923735 Mon Sep 17 00:00:00 2001
From: DarkSky <25152247+darkskygit@users.noreply.github.com>
Date: Thu, 3 Jul 2025 11:45:34 +0800
Subject: [PATCH] feat(server): deprecate blob id provide by client (#12991)

fix AI-287
---
 .../__tests__/__snapshots__/copilot.e2e.ts.md |   2 +-
 .../__snapshots__/copilot.e2e.ts.snap         | Bin 1127 -> 1167 bytes
 .../src/plugins/copilot/context/resolver.ts   |  34 ++++++++----------
 packages/backend/server/src/schema.gql        |   2 +-
 packages/common/graphql/src/schema.ts         |   2 +-
 5 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.md b/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.md
index 1f1840ff6..49f5c10e7 100644
--- a/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.md
+++ b/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.md
@@ -42,7 +42,7 @@ Generated by [AVA](https://avajs.dev).
 
     [
       {
-        blobId: 'fileId1',
+        blobId: 'Ip3vuwzubwJnOlzeKQ0Gc-daDcMc7EOYnIqypOyn4bs',
         chunkSize: 0,
         name: 'sample.pdf',
         status: 'processing',
diff --git a/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.snap b/packages/backend/server/src/__tests__/__snapshots__/copilot.e2e.ts.snap
index a668f573a699d225d4f279147f21570967b177b9..9239165a9356f4027e684914fe98809337c5d236 100644
GIT binary patch
literal 1167
zcmV;A1aSL7RzV<BZeeh9Xm4~Nb~6eC00HvIe>UIUnYIVp*g1?dlDaWC`@n@hI{`61
zQ{!dk86S%X00000000B+n9pw;MHI)sZ+|#Wqc*7u5=c}Ui5~}WQ=5h&MHNyJ5eXFv
z2nkUThw<(>-gtLryE9JWaDxcM4^auh1tCFufdk?Y4xA7d#2<hvu03($0^)#x3-xB#
z!Rs`3lvJfCzIbML-uk`Id+)n5zS5|N%4_M3tHJ~(6l+X3RXg-qT`*n`1v82z!XzEG
z8ki>IaS&+9W8G9nzkb#Cx#1V-EgNI#eyB`V1;C>KPEhGMx#yFFcZl-Q<m4pi2#7!v
zMCWoNrv=~=fOi3WksFs5>&wD3Wc7wqQ&XU$ARBay=m!9Ib;s^;Dn~+Vz9ckg5+}&Y
zub1LLO5vwdYpQtDsFsjAojO!b-T&o=C%+Zkw|92`@7#U+Ap$A{a4NX&47hF;d>HeT
zG(wtue)p1)BH>0bBi2k8fA_m!<RmH-`DC1H9caU)5h1UOaP8s26o!E|tQlydk`Chy
zBa*GG9%k^4&*07bHsX>m36{FIW_IY?)BDZ3s{phCd<Wn<fKn0PVCJ1-3hSY&FZlWN
zk%jooN_%y^U0;1hE{5yk!t>Rqy;DAa%6ry(d~WfgT)5PU7dvvMUaXXHui2KZ7lQRI
zunvmMC69W{k7ypnp_q>SM$sW{xM}O&!Z=Z$&^nMyS$6KtP^T%$=(0u-3cUsPrEm7j
z)m{P+0eF9SCl$-l3VJL{zVa6Q+Fs+kXQ%jl<>|cE?i;K%lW?iMB#8f2XB!!g%lpM)
zc>sdpC}{Uc$C9>`+hIPKMWNgEC@_q-{h%)nCE2p7XT4&p{RUCe06GA^0&oq$I05H|
z_lsMU8}4;|(|eMeA_*_#K_vX*qjfuqc+%O^qusP7hM62AdWE*d{%9ZPwB$Dkc<08F
z4{3;WTPfF1Ddjpr^dljKT_)GHfC&pYZ2`|&z>2lInwQD_(gHRu;3o_C!vap)1rv9u
zg4sg$TCQBJ&Q`0lGmj0RjRkLsB%jmyB1Ua^VhWErQ!T9O=ayfcnipZHDom`1q@$#m
z9?i|#Y_0hG0XLr<#m$+sBe_|b4=T(wxookHYO{t)*s=<`9mz~nut*4#j+M_l(^-=~
zkTq#qu)Fu@|3YWnR}XdOmg<cA9swT^@CgB*6R<f<Z=96xw>`c2HPf33qWdl6dh}v<
zXs5sMwgp_afUhm!ng#qdT!pGOaMlK1wt?4d;K~pcDwF%W4g6^XCmrAk2k@PONom03
zV+Z)m0ls&DpB-SrEtrfQYTfP7x{*St9SrH(Ehb$%7}B->z*{BT?at+k6VcThKWH>W
zBBWuuyK7dGnNBP;<I-m<JPiEqqBv1eoNk`ANq8WQ-rg3!k-e_oylt<mz7utZ<U)Ux
zd2H#wKK-{=RnpQi_X>+r9o~vN3vlzmjzJ&o{TSq?XP@muP8#wlUwOO1n9N|zj|^kW
h`c5JtRTA-V7>T?r=0+yrEAOTl{sGY6VPIwy001}4I-39h

literal 1127
zcmV-t1ep6lRzV<BZeeh9Xm4~Nb~6eC0Ap7`w<*;#y?bt(X5#k>v*{&%AOqBT{ST<I
zZRXwOi64sy00000000B+n9qwGMHI)suYb(WW=M8J6ch{;_~Rh!I-@a%B?u7$8$2io
z;txF3bl2?kPIpzOs%EpJH(eBeU_kVuf+iO|h==vyLA;57fCT>l!IKxogG4W;d%I_y
zp3TlIyCI3}T&AkKUiEvQdhgp+eYw+)RnRjVSA>mhEY_Lns(u`@wqU#+3uYD5!s-FL
z7}+l4X%rdBQ`1$}ynZDNx#cg?TP|jh{isgP0)WQ=oS@oq^3Q6`2SjCSZf*{A1Vo?)
z(V5c7>jAg`;9US;md3Sb+N&b4<P4kh^YfsiAQyCu=tlr|Wo`dB)e~V1Ul9g0hZE$K
z*K27cr3mw`Ghe-FRZmEhcRi}-?*De(lRql%yF0u8PwBq<5CIDWaH_cOjk)ere3%K8
zv_jglfA@-zLUSva73(&`pZ!;iJgs6;c4oOTk+ED_5%ac)*B>5V!Z<RPbt7Yy9x&dq
zLT|0=;R@dID|q9&O}OMMg5~b5+a2n*vENnq6@Wf~PXK%e;FrlO?^Tzu9jo^Fa7eQg
z#o~O}s*IWqx_#MuE_!tfnujV+$&(?^BZenwEEdzSQ+=4R-1g0IV5(IhjEUq*LH^zX
zV~)EZ$1<197PJ?>-7hnD1waDe{mHDVspdpOPPI@4<CrGKch64og(@&*9^E&dM^<xb
z0v)CQ$)Sw`$EE$^Z~_3)WE8Y}q%*oN<#w147EzdfJBcjg{V*DdLrJ!(+C?3>YQI6$
z41fWEuK`>IFiXIhs+5ce<yWPI2bphXPf}7P5yU)7L|C2L^pk|^!Jek}^PHGua*XI@
z+7|MoBb@V;-yq<f>q9=I39{_uTtB0nYlG+~LJqr5zV84H2YA#0o^^mVXLqHplmC?i
zY&yWt4)B))oOCND{zP?hg&dY#z1du9HkVF4F@`o3yeD+or?XXz#&T^d(>&g+j2h)u
zUY%bSajX`YSQC1nq*$EJ&DK(@I{%oPPfg?Isnb)rxv(59Fx%y_#|Em;I!d!u6=fC4
zY*(;E2%EQ6$Onr>kv>oqX`ZmV*XaL3XZ%+Vb>^n(jQ<`19}w^<0bdZXIZ1E4obUHT
zz4^V+n+DPS4oW?GK5M%96W(@!OAhdj16*~0zbC6u(*;huz)LRhnhRW>ph9)>|8#+C
zE^yKVp7emwtC-ZrOg{F2&pqG=5BSvs8h*uO=1}Wyh1N|KLhE2iw{9}&*1?c&-3D)!
zVz+y)9IQpAH(}K22rZ;#CfhYD$?PB%hH)9PH6BM{HYn99N%PIKv6@HHn(b}z8^!DD
z&0F@m8aXW&NS+>zvWzYNqBDByqS8H+@}M#(*Ws<WivTwd>=^XX-j6|ke)icu<m4eg
t5~^S~7;^=T<*8w8S>H({q|ynGCy^-A;@s3ELKWN)!@rqzmvurE006SvC*S}8

diff --git a/packages/backend/server/src/plugins/copilot/context/resolver.ts b/packages/backend/server/src/plugins/copilot/context/resolver.ts
index fa15f8e06..0585d10a3 100644
--- a/packages/backend/server/src/plugins/copilot/context/resolver.ts
+++ b/packages/backend/server/src/plugins/copilot/context/resolver.ts
@@ -1,3 +1,5 @@
+import { createHash } from 'node:crypto';
+
 import {
   Args,
   Context,
@@ -102,8 +104,9 @@ class AddContextFileInput {
   @Field(() => String)
   contextId!: string;
 
-  @Field(() => String)
-  blobId!: string;
+  // @TODO(@darkskygit): remove this after client lower then 0.22 has been disconnected
+  @Field(() => String, { nullable: true, deprecationReason: 'Never used' })
+  blobId!: string | undefined;
 }
 
 @InputType()
@@ -611,8 +614,9 @@ export class CopilotContextResolver {
     if (!this.context.canEmbedding) {
       throw new CopilotEmbeddingUnavailable();
     }
+    const { contextId } = options;
 
-    const lockFlag = `${COPILOT_LOCKER}:context:${options.contextId}`;
+    const lockFlag = `${COPILOT_LOCKER}:context:${contextId}`;
     await using lock = await this.mutex.acquire(lockFlag);
     if (!lock) {
       throw new TooManyRequest('Server is busy');
@@ -623,22 +627,15 @@ export class CopilotContextResolver {
       throw new BlobQuotaExceeded();
     }
 
-    const session = await this.context.get(options.contextId);
+    const session = await this.context.get(contextId);
 
     try {
-      const file = await session.addFile(
-        options.blobId,
-        content.filename,
-        content.mimetype
-      );
-
       const buffer = await readStream(content.createReadStream());
-      await this.storage.put(
-        user.id,
-        session.workspaceId,
-        options.blobId,
-        buffer
-      );
+      const blobId = createHash('sha256').update(buffer).digest('base64url');
+      const { filename, mimetype } = content;
+
+      await this.storage.put(user.id, session.workspaceId, blobId, buffer);
+      const file = await session.addFile(blobId, filename, mimetype);
 
       await this.jobs.addFileEmbeddingQueue({
         userId: user.id,
@@ -655,10 +652,7 @@ export class CopilotContextResolver {
       if (e instanceof UserFriendlyError) {
         throw e;
       }
-      throw new CopilotFailedToModifyContext({
-        contextId: options.contextId,
-        message: e.message,
-      });
+      throw new CopilotFailedToModifyContext({ contextId, message: e.message });
     }
   }
 
diff --git a/packages/backend/server/src/schema.gql b/packages/backend/server/src/schema.gql
index 36f0a5cc5..1e3258a3e 100644
--- a/packages/backend/server/src/schema.gql
+++ b/packages/backend/server/src/schema.gql
@@ -15,7 +15,7 @@ input AddContextDocInput {
 }
 
 input AddContextFileInput {
-  blobId: String!
+  blobId: String
   contextId: String!
 }
 
diff --git a/packages/common/graphql/src/schema.ts b/packages/common/graphql/src/schema.ts
index bec90e146..218b14ed2 100644
--- a/packages/common/graphql/src/schema.ts
+++ b/packages/common/graphql/src/schema.ts
@@ -50,7 +50,7 @@ export interface AddContextDocInput {
 }
 
 export interface AddContextFileInput {
-  blobId: Scalars['String']['input'];
+  blobId?: InputMaybe<Scalars['String']['input']>;
   contextId: Scalars['String']['input'];
 }