refactor: remove React.FC for affine core (#3617)

apps/core/src/layouts/workspace-layout.tsx

@@ -29,7 +29,7 @@ import {
 import { usePassiveWorkspaceEffect } from '@toeverything/infra/__internal__/react';
 import { currentWorkspaceIdAtom } from '@toeverything/infra/atom';
 import { useAtom, useAtomValue, useSetAtom } from 'jotai';
-import type { FC, PropsWithChildren, ReactElement } from 'react';
+import type { PropsWithChildren, ReactElement } from 'react';
 import { lazy, Suspense, useCallback, useMemo } from 'react';
 import { useLocation, useParams } from 'react-router-dom';
 
@@ -69,15 +69,17 @@ function DefaultProvider({ children }: PropsWithChildren) {
   return <>{children}</>;
 }
 
-export const QuickSearch: FC = () => {
+export const QuickSearch = () => {
   const [currentWorkspace] = useCurrentWorkspace();
   const [openQuickSearchModal, setOpenQuickSearchModalAtom] = useAtom(
     openQuickSearchModalAtom
   );
   const blockSuiteWorkspace = currentWorkspace?.blockSuiteWorkspace;
+
   if (!blockSuiteWorkspace) {
     return null;
   }
+
   return (
     <QuickSearchModal
       workspace={currentWorkspace}
@@ -118,39 +120,41 @@ export const CurrentWorkspaceContext = ({
   return <>{children}</>;
 };
 
-export const WorkspaceLayout: FC<PropsWithChildren> =
-  function WorkspacesSuspense({ children }) {
-    const currentWorkspaceId = useAtomValue(currentWorkspaceIdAtom);
-    const jotaiWorkspaces = useAtomValue(rootWorkspacesMetadataAtom);
-    const meta = useMemo(
-      () => jotaiWorkspaces.find(x => x.id === currentWorkspaceId),
-      [currentWorkspaceId, jotaiWorkspaces]
-    );
+export const WorkspaceLayout = function WorkspacesSuspense({
+  children,
+}: PropsWithChildren) {
+  const currentWorkspaceId = useAtomValue(currentWorkspaceIdAtom);
+  const jotaiWorkspaces = useAtomValue(rootWorkspacesMetadataAtom);
+  const meta = useMemo(
+    () => jotaiWorkspaces.find(x => x.id === currentWorkspaceId),
+    [currentWorkspaceId, jotaiWorkspaces]
+  );
 
-    const Provider =
-      (meta && WorkspaceAdapters[meta.flavour].UI.Provider) ?? DefaultProvider;
-    return (
-      <>
-        {/* load all workspaces is costly, do not block the whole UI */}
-        <Suspense fallback={null}>
-          <AllWorkspaceModals />
-          <CurrentWorkspaceContext>
-            {/* fixme(himself65): don't re-render whole modals */}
-            <CurrentWorkspaceModals key={currentWorkspaceId} />
-          </CurrentWorkspaceContext>
-        </Suspense>
+  const Provider =
+    (meta && WorkspaceAdapters[meta.flavour].UI.Provider) ?? DefaultProvider;
+
+  return (
+    <>
+      {/* load all workspaces is costly, do not block the whole UI */}
+      <Suspense fallback={null}>
+        <AllWorkspaceModals />
         <CurrentWorkspaceContext>
-          <Suspense fallback={<WorkspaceFallback />}>
-            <Provider>
-              <WorkspaceLayoutInner>{children}</WorkspaceLayoutInner>
-            </Provider>
-          </Suspense>
+          {/* fixme(himself65): don't re-render whole modals */}
+          <CurrentWorkspaceModals key={currentWorkspaceId} />
         </CurrentWorkspaceContext>
-      </>
-    );
-  };
+      </Suspense>
+      <CurrentWorkspaceContext>
+        <Suspense fallback={<WorkspaceFallback />}>
+          <Provider>
+            <WorkspaceLayoutInner>{children}</WorkspaceLayoutInner>
+          </Provider>
+        </Suspense>
+      </CurrentWorkspaceContext>
+    </>
+  );
+};
 
-export const WorkspaceLayoutInner: FC<PropsWithChildren> = ({ children }) => {
+export const WorkspaceLayoutInner = ({ children }: PropsWithChildren) => {
   const [currentWorkspace] = useCurrentWorkspace();
   const { openPage } = useNavigateHelper();