From 33d57b455a0c74b78e05ff199ab8abd701ae6017 Mon Sep 17 00:00:00 2001 From: forehalo Date: Wed, 19 Mar 2025 12:58:56 +0000 Subject: [PATCH] chore(server): revert access control in sync module (#11011) --- packages/backend/server/src/core/sync/gateway.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/backend/server/src/core/sync/gateway.ts b/packages/backend/server/src/core/sync/gateway.ts index a6d9c5260..b99b601ae 100644 --- a/packages/backend/server/src/core/sync/gateway.ts +++ b/packages/backend/server/src/core/sync/gateway.ts @@ -300,7 +300,8 @@ export class SpaceSyncGateway const adapter = this.selectAdapter(client, spaceType); const id = new DocID(docId, spaceId); - await this.ac.user(user.id).doc(spaceId, id.guid).assert('Doc.Update'); + // TODO(@forehalo): enable after frontend supporting doc revert + // await this.ac.user(user.id).doc(spaceId, id.guid).assert('Doc.Update'); const timestamp = await adapter.push( spaceId, id.guid, @@ -340,8 +341,8 @@ export class SpaceSyncGateway const { spaceType, spaceId, docId, update } = message; const adapter = this.selectAdapter(client, spaceType); - // TODO(@forehalo): change action to 'Doc.Write' after frontend supporting doc revert - await this.ac.user(user.id).doc(spaceId, docId).assert('Doc.Read'); + // TODO(@forehalo): enable after frontend supporting doc revert + // await this.ac.user(user.id).doc(spaceId, docId).assert('Doc.Update'); const timestamp = await adapter.push( spaceId, docId, @@ -512,8 +513,7 @@ abstract class SyncSocketAdapter { updates: Buffer[], editorId: string ) { - // TODO(@forehalo): enable this after 0.19 goes out of life - // this.assertIn(spaceId); + this.assertIn(spaceId); return await this.storage.pushDocUpdates(spaceId, docId, updates, editorId); }