chore: fix eslint in blocksuite (#9232)

This commit is contained in:
Saul-Mirone
2024-12-20 16:48:10 +00:00
parent bfcc53dc1f
commit 3a82da0e5b
269 changed files with 935 additions and 842 deletions

View File

@@ -39,7 +39,7 @@ abstract class PointerControllerBase {
}
class PointerEventForward extends PointerControllerBase {
private _down = (event: PointerEvent) => {
private readonly _down = (event: PointerEvent) => {
const { pointerId } = event;
const pointerState = new PointerEventState({
@@ -54,9 +54,9 @@ class PointerEventForward extends PointerControllerBase {
this._dispatcher.run('pointerDown', createContext(event, pointerState));
};
private _lastStates = new Map<PointerId, PointerEventState>();
private readonly _lastStates = new Map<PointerId, PointerEventState>();
private _move = (event: PointerEvent) => {
private readonly _move = (event: PointerEvent) => {
const { pointerId } = event;
const start = this._startStates.get(pointerId) ?? null;
@@ -74,9 +74,9 @@ class PointerEventForward extends PointerControllerBase {
this._dispatcher.run('pointerMove', createContext(event, state));
};
private _startStates = new Map<PointerId, PointerEventState>();
private readonly _startStates = new Map<PointerId, PointerEventState>();
private _upOrOut = (up: boolean) => (event: PointerEvent) => {
private readonly _upOrOut = (up: boolean) => (event: PointerEvent) => {
const { pointerId } = event;
const start = this._startStates.get(pointerId) ?? null;
@@ -109,7 +109,7 @@ class PointerEventForward extends PointerControllerBase {
}
class ClickController extends PointerControllerBase {
private _down = (event: PointerEvent) => {
private readonly _down = (event: PointerEvent) => {
// disable for secondary pointer
if (event.isPrimary === false) return;
@@ -137,7 +137,7 @@ class ClickController extends PointerControllerBase {
private _pointerDownCount = 0;
private _up = (event: PointerEvent) => {
private readonly _up = (event: PointerEvent) => {
if (!this._downPointerState) return;
if (isFarEnough(this._downPointerState.raw, event)) {
@@ -177,7 +177,7 @@ class ClickController extends PointerControllerBase {
}
class DragController extends PointerControllerBase {
private _down = (event: PointerEvent) => {
private readonly _down = (event: PointerEvent) => {
if (this._nativeDragging) return;
if (!event.isPrimary) {
@@ -209,7 +209,7 @@ class DragController extends PointerControllerBase {
private _lastPointerState: PointerEventState | null = null;
private _move = (event: PointerEvent) => {
private readonly _move = (event: PointerEvent) => {
if (
this._startPointerState === null ||
this._startPointerState.raw.pointerId !== event.pointerId
@@ -243,7 +243,7 @@ class DragController extends PointerControllerBase {
}
};
private _nativeDragEnd = (event: DragEvent) => {
private readonly _nativeDragEnd = (event: DragEvent) => {
this._nativeDragging = false;
const dndEventState = new DndEventState({ event });
this._dispatcher.run(
@@ -254,7 +254,7 @@ class DragController extends PointerControllerBase {
private _nativeDragging = false;
private _nativeDragMove = (event: DragEvent) => {
private readonly _nativeDragMove = (event: DragEvent) => {
const dndEventState = new DndEventState({ event });
this._dispatcher.run(
'nativeDragMove',
@@ -262,7 +262,7 @@ class DragController extends PointerControllerBase {
);
};
private _nativeDragStart = (event: DragEvent) => {
private readonly _nativeDragStart = (event: DragEvent) => {
this._reset();
this._nativeDragging = true;
const dndEventState = new DndEventState({ event });
@@ -272,7 +272,7 @@ class DragController extends PointerControllerBase {
);
};
private _nativeDrop = (event: DragEvent) => {
private readonly _nativeDrop = (event: DragEvent) => {
this._reset();
this._nativeDragging = false;
const dndEventState = new DndEventState({ event });
@@ -282,7 +282,7 @@ class DragController extends PointerControllerBase {
);
};
private _reset = () => {
private readonly _reset = () => {
this._dragging = false;
this._startPointerState = null;
this._lastPointerState = null;
@@ -293,7 +293,7 @@ class DragController extends PointerControllerBase {
private _startPointerState: PointerEventState | null = null;
private _up = (event: PointerEvent) => {
private readonly _up = (event: PointerEvent) => {
if (
!this._startPointerState ||
this._startPointerState.raw.pointerId !== event.pointerId
@@ -358,7 +358,7 @@ class DragController extends PointerControllerBase {
}
abstract class DualDragControllerBase extends PointerControllerBase {
private _down = (event: PointerEvent) => {
private readonly _down = (event: PointerEvent) => {
// Another pointer down
if (
this._startPointerStates.primary !== null &&
@@ -394,7 +394,7 @@ abstract class DualDragControllerBase extends PointerControllerBase {
secondary: null,
};
private _move = (event: PointerEvent) => {
private readonly _move = (event: PointerEvent) => {
if (
this._startPointerStates.primary === null ||
this._startPointerStates.secondary === null
@@ -440,7 +440,7 @@ abstract class DualDragControllerBase extends PointerControllerBase {
};
};
private _reset = () => {
private readonly _reset = () => {
this._startPointerStates = {
primary: null,
secondary: null,
@@ -459,7 +459,7 @@ abstract class DualDragControllerBase extends PointerControllerBase {
secondary: null,
};
private _upOrOut = (event: PointerEvent) => {
private readonly _upOrOut = (event: PointerEvent) => {
const { pointerId } = event;
if (
pointerId === this._startPointerStates.primary?.raw.pointerId ||
@@ -542,7 +542,7 @@ class PanController extends DualDragControllerBase {
export class PointerControl {
private _cachedRect: DOMRect | null = null;
private _getRect = () => {
private readonly _getRect = () => {
if (this._cachedRect === null) {
this._updateRect();
}
@@ -553,9 +553,9 @@ export class PointerControl {
// due to potential performance issues
private _pollingInterval: number | null = null;
private controllers: PointerControllerBase[];
private readonly controllers: PointerControllerBase[];
constructor(private _dispatcher: UIEventDispatcher) {
constructor(private readonly _dispatcher: UIEventDispatcher) {
this.controllers = [
new PointerEventForward(_dispatcher, this._getRect),
new ClickController(_dispatcher, this._getRect),