luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor(core): remove the unused compareDate field from DocDisplayIconOptions (#10095)

Browse Source
This commit is contained in:
L-Sun
2025-02-11 13:26:43 +00:00
parent ba52abe50f
commit 401ce70153
6 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/frontend/core/src/components/root-app-sidebar/journal-button.tsx
View File

@@ -15,11 +15,7 @@ export const AppSidebarJournalButton = () => {
const maybeDocId = location.pathname.split('/')[1]; const maybeDocId = location.pathname.split('/')[1];
const isJournal = !!useLiveData(journalService.journalDate$(maybeDocId)); const isJournal = !!useLiveData(journalService.journalDate$(maybeDocId));
const JournalIcon = useLiveData( const JournalIcon = useLiveData(docDisplayMetaService.icon$(maybeDocId));
docDisplayMetaService.icon$(maybeDocId, {
compareDate: new Date(),
})
);
const Icon = isJournal ? JournalIcon : TodayIcon; const Icon = isJournal ? JournalIcon : TodayIcon;
return ( return (

4
packages/frontend/core/src/desktop/pages/workspace/detail-page/tabs/journal/index.tsx
View File

@@ -61,9 +61,7 @@ const PageItem = ({
}: PageItemProps) => { }: PageItemProps) => {
const i18n = useI18n(); const i18n = useI18n();
const docDisplayMetaService = useService(DocDisplayMetaService); const docDisplayMetaService = useService(DocDisplayMetaService);
const Icon = useLiveData( const Icon = useLiveData(docDisplayMetaService.icon$(docId));
docDisplayMetaService.icon$(docId, { compareDate: new Date() })
);
const title = useLiveData(docDisplayMetaService.title$(docId)); const title = useLiveData(docDisplayMetaService.title$(docId));
return ( return (

4
packages/frontend/core/src/mobile/components/app-tabs/journal.tsx
View File

@@ -16,9 +16,7 @@ export const AppTabJournal = ({ tab }: AppTabCustomFCProps) => {
const maybeDocId = location.pathname.split('/')[1]; const maybeDocId = location.pathname.split('/')[1];
const journalDate = useLiveData(journalService.journalDate$(maybeDocId)); const journalDate = useLiveData(journalService.journalDate$(maybeDocId));
const JournalIcon = useLiveData( const JournalIcon = useLiveData(docDisplayMetaService.icon$(maybeDocId));
docDisplayMetaService.icon$(maybeDocId, { compareDate: new Date() })
);
const handleOpenToday = useCallback(() => { const handleOpenToday = useCallback(() => {
const docId = journalService.ensureJournalByDate(new Date()).id; const docId = journalService.ensureJournalByDate(new Date()).id;

4
packages/frontend/core/src/mobile/pages/workspace/detail/menu/journal-conflicts.tsx
View File

@@ -94,9 +94,7 @@ const DocItem = ({ docRecord }: { docRecord: DocRecord }) => {
const docId = docRecord.id; const docId = docRecord.id;
const i18n = useI18n(); const i18n = useI18n();
const docDisplayMetaService = useService(DocDisplayMetaService); const docDisplayMetaService = useService(DocDisplayMetaService);
const Icon = useLiveData( const Icon = useLiveData(docDisplayMetaService.icon$(docId));
docDisplayMetaService.icon$(docId, { compareDate: new Date() })
);
const title = useLiveData(docDisplayMetaService.title$(docId)); const title = useLiveData(docDisplayMetaService.title$(docId));
return ( return (
<WorkbenchLink aria-label={title} to={`/${docId}`}> <WorkbenchLink aria-label={title} to={`/${docId}`}>

4
packages/frontend/core/src/mobile/pages/workspace/detail/menu/journal-today-activity.tsx
View File

@@ -24,9 +24,7 @@ type Category = 'created' | 'updated';
const DocItem = ({ docId }: { docId: string }) => { const DocItem = ({ docId }: { docId: string }) => {
const docDisplayMetaService = useService(DocDisplayMetaService); const docDisplayMetaService = useService(DocDisplayMetaService);
const Icon = useLiveData( const Icon = useLiveData(docDisplayMetaService.icon$(docId));
docDisplayMetaService.icon$(docId, { compareDate: new Date() })
);
const title = useLiveData(docDisplayMetaService.title$(docId)); const title = useLiveData(docDisplayMetaService.title$(docId));
return ( return (
<WorkbenchLink aria-label={title} to={`/${docId}`}> <WorkbenchLink aria-label={title} to={`/${docId}`}>

1
packages/frontend/core/src/modules/doc-display-meta/services/doc-display-meta.ts
View File

@@ -34,7 +34,6 @@ import type { JournalService } from '../../journal';
type IconType = 'rc' | 'lit'; type IconType = 'rc' | 'lit';
interface DocDisplayIconOptions<T extends IconType> { interface DocDisplayIconOptions<T extends IconType> {
type?: T; type?: T;
compareDate?: Date | Dayjs;
/** /**
* Override the mode detected inside the hook: * Override the mode detected inside the hook:
* by default, it will use the `primaryMode$` of the doc. * by default, it will use the `primaryMode$` of the doc.