diff --git a/apps/electron/README.md b/apps/electron/README.md index e836f6a8e..f4776ccbc 100644 --- a/apps/electron/README.md +++ b/apps/electron/README.md @@ -1,21 +1,17 @@ # AFFiNE Electron App -# ⚠️ NOTE ⚠️ - -Due to PNPM related issues, this project is currently using **yarn 3**. -See https://github.com/electron/forge/issues/2633 - ## Development -``` -# in project root, start web app at :8080 +To run AFFiNE Desktop Client Application locally, run the following commands: + +```sh +# in repo root +yarn install yarn dev -# build octobase-node -yarn workspace @affine/octobase-node build - -# in /apps/electron, start electron app -yarn dev +# in apps/electron +yarn generate-assets +yarn dev # or yarn prod for production build ``` ## Credits diff --git a/packages/component/src/components/share-menu/SharePage.tsx b/packages/component/src/components/share-menu/SharePage.tsx index a4e7dfd7a..50c8bb9f5 100644 --- a/packages/component/src/components/share-menu/SharePage.tsx +++ b/packages/component/src/components/share-menu/SharePage.tsx @@ -1,4 +1,4 @@ -import { getEnvironment } from '@affine/env'; +import { prefixUrl } from '@affine/env'; import { Trans, useTranslation } from '@affine/i18n'; import type { LocalWorkspace } from '@affine/workspace/type'; import { WorkspaceFlavour } from '@affine/workspace/type'; @@ -46,12 +46,7 @@ export const AffineSharePage: FC = props => { const [showDisable, setShowDisable] = useState(false); const { t } = useTranslation(); const sharingUrl = useMemo(() => { - const env = getEnvironment(); - if (env.isBrowser) { - return `${env.origin}/public-workspace/${props.workspace.id}/${props.currentPage.id}`; - } else { - return ''; - } + return `${prefixUrl}public-workspace/${props.workspace.id}/${props.currentPage.id}`; }, [props.workspace.id, props.currentPage.id]); const onClickCreateLink = useCallback(() => { setIsPublic(true);