feat(core): enable new all docs by default (#12404)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Simplified the user interface by always displaying the new All Pages view, removing the feature flag and old page version. - Updated selection interactions to use shift+click on document items instead of checkboxes. - Centralized drag-and-drop functionality in document list items and simplified drag handle behavior. - Generalized new page button component to accept standard HTML attributes. - Changed test ID attributes on new page buttons and list headers to use standard `data-testid`. - **Bug Fixes** - Added stable test identifiers to new page buttons, document list items, menu items, and operation buttons for improved test reliability. - Enabled external drag-and-drop support on the trash button. - **Tests** - Streamlined and updated end-to-end tests to match the new selection flow and UI changes, removing outdated or redundant test cases. - Simplified utility functions and wait conditions in test helpers for better accuracy and maintainability. - Updated selectors in tests to reflect new document item identifiers and centralized page element retrieval using utility functions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -3,6 +3,7 @@ import { openHomePage } from '@affine-test/kit/utils/load-page';
|
||||
import {
|
||||
clickNewPageButton,
|
||||
getBlockSuiteEditorTitle,
|
||||
getPageByTitle,
|
||||
getPageOperationButton,
|
||||
waitForEditorLoad,
|
||||
} from '@affine-test/kit/utils/page-logic';
|
||||
@@ -20,13 +21,11 @@ test('New a page , then delete it in all pages, restore it', async ({
|
||||
await getBlockSuiteEditorTitle(page).fill('this is a new page to restore');
|
||||
const newPageId = getCurrentDocIdFromUrl(page);
|
||||
await page.getByTestId('all-pages').click();
|
||||
const cell = page
|
||||
.getByTestId('virtualized-page-list')
|
||||
.getByText('this is a new page to restore');
|
||||
const cell = await getPageByTitle(page, 'this is a new page to restore');
|
||||
await expect(cell).toBeVisible();
|
||||
|
||||
await getPageOperationButton(page, newPageId).click();
|
||||
const deleteBtn = page.getByTestId('move-to-trash');
|
||||
const deleteBtn = page.getByTestId('doc-list-operation-trash');
|
||||
await deleteBtn.click();
|
||||
const confirmTip = page.getByRole('dialog', { name: 'Delete doc?' });
|
||||
await expect(confirmTip).toBeVisible();
|
||||
@@ -42,8 +41,11 @@ test('New a page , then delete it in all pages, restore it', async ({
|
||||
// stay in trash page
|
||||
expect(page.url()).toBe(trashPage);
|
||||
await page.getByTestId('all-pages').click();
|
||||
const allPages = page.getByTestId('virtualized-page-list');
|
||||
const restoreCell = allPages.getByText('this is a new page to restore');
|
||||
|
||||
const restoreCell = await getPageByTitle(
|
||||
page,
|
||||
'this is a new page to restore'
|
||||
);
|
||||
await expect(restoreCell).toBeVisible();
|
||||
const currentWorkspace = await workspace.current();
|
||||
|
||||
|
||||
Reference in New Issue
Block a user