From 5623d808bf6a82ec56177cd5591339d5bf657acb Mon Sep 17 00:00:00 2001
From: fengmk2 <fengmk2@gmail.com>
Date: Fri, 20 Jun 2025 10:30:53 +0800
Subject: [PATCH] fix(server): set empty embedding on empty doc (#12857)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#### PR Dependency Tree


* **PR #12857** 👈

This tree was auto-generated by
[Charcoal](https://github.com/danerwilliams/charcoal)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Bug Fixes**
- Improved error handling in document embedding jobs to log and skip
errors instead of interrupting the process.
- Enhanced logging with clearer messages about embedding outcomes and
skipped operations.
- Added warnings when documents or summaries are missing during
embedding.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../src/plugins/copilot/embedding/job.ts      | 30 ++++++++++++++-----
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/packages/backend/server/src/plugins/copilot/embedding/job.ts b/packages/backend/server/src/plugins/copilot/embedding/job.ts
index cc9381ddd..632ee5b99 100644
--- a/packages/backend/server/src/plugins/copilot/embedding/job.ts
+++ b/packages/backend/server/src/plugins/copilot/embedding/job.ts
@@ -6,7 +6,6 @@ import {
   BlobNotFound,
   CallMetric,
   CopilotContextFileNotSupported,
-  DocNotFound,
   EventBus,
   JobQueue,
   mapAnyError,
@@ -138,7 +137,7 @@ export class CopilotEmbeddingJob {
     if (enableDocEmbedding) {
       const toBeEmbedDocIds =
         await this.models.copilotWorkspace.findDocsToEmbed(workspaceId);
-      this.logger.debug(
+      this.logger.log(
         `Trigger embedding for ${toBeEmbedDocIds.length} docs in workspace ${workspaceId}`
       );
       for (const docId of toBeEmbedDocIds) {
@@ -342,11 +341,16 @@ export class CopilotEmbeddingJob {
           workspaceId,
           docId
         );
-      this.logger.verbose(
+      this.logger.log(
         `Check if doc ${docId} in workspace ${workspaceId} needs embedding: ${needEmbedding}`
       );
       if (needEmbedding) {
-        if (signal.aborted) return;
+        if (signal.aborted) {
+          this.logger.log(
+            `Doc ${docId} in workspace ${workspaceId} is aborted, skipping embedding.`
+          );
+          return;
+        }
         const fragment = await this.getDocFragment(workspaceId, docId);
         if (fragment) {
           // fast fall for empty doc, journal is easily to create a empty doc
@@ -367,12 +371,21 @@ export class CopilotEmbeddingJob {
                 chunks
               );
             }
+            this.logger.log(
+              `Doc ${docId} in workspace ${workspaceId} has summary, embedding done.`
+            );
           } else {
             // for empty doc, insert empty embedding
+            this.logger.warn(
+              `Doc ${docId} in workspace ${workspaceId} has no summary, fulfilling empty embedding.`
+            );
             await this.fulfillEmptyEmbedding(workspaceId, docId);
           }
         } else if (contextId) {
-          throw new DocNotFound({ spaceId: workspaceId, docId });
+          this.logger.warn(
+            `Doc ${docId} in workspace ${workspaceId} has no fragment, fulfilling empty embedding.`
+          );
+          await this.fulfillEmptyEmbedding(workspaceId, docId);
         }
       }
     } catch (error: any) {
@@ -394,8 +407,11 @@ export class CopilotEmbeddingJob {
         return;
       }
 
-      // passthrough error to job queue
-      throw error;
+      // log error and skip the job
+      this.logger.error(
+        `Error embedding doc ${docId} in workspace ${workspaceId}`,
+        error
+      );
     }
   }
 }