luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: check if login when enable affine cloud (#1445)

Browse Source
This commit is contained in:
Himself65
2023-03-09 01:26:07 -06:00
committed by GitHub
parent b23547f4bd
commit 6b533c44be
4 changed files with 41 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/web/src/components/affine/workspace-setting-detail/panel/publish/index.tsx
View File

@@ -17,6 +17,7 @@ import {
LocalWorkspace, LocalWorkspace,
RemWorkspaceFlavour, RemWorkspaceFlavour,
} from '../../../../../shared'; } from '../../../../../shared';
import { apis } from '../../../../../shared/apis';
import { Unreachable } from '../../../affine-error-eoundary'; import { Unreachable } from '../../../affine-error-eoundary';
import { EnableAffineCloudModal } from '../../../enable-affine-cloud-modal'; import { EnableAffineCloudModal } from '../../../enable-affine-cloud-modal';
import { WorkspaceSettingDetailProps } from '../../index'; import { WorkspaceSettingDetailProps } from '../../index';
@@ -101,8 +102,12 @@ const PublishPanelAffine: React.FC<PublishPanelAffineProps> = ({
setOpen(false); setOpen(false);
}} }}
onConfirm={() => { onConfirm={() => {
publishWorkspace(true); if (!apis.auth.isLogin) {
setOpen(false); toast(t('Please login first'));
} else {
publishWorkspace(true);
setOpen(false);
}
}} }}
/> />
</> </>

6
apps/web/src/components/blocksuite/header/header-right-items/SyncUser.tsx
View File

@@ -16,6 +16,7 @@ import {
LocalWorkspace, LocalWorkspace,
RemWorkspaceFlavour, RemWorkspaceFlavour,
} from '../../../../shared'; } from '../../../../shared';
import { apis } from '../../../../shared/apis';
import { TransformWorkspaceToAffineModal } from '../../../affine/transform-workspace-to-affine-modal'; import { TransformWorkspaceToAffineModal } from '../../../affine/transform-workspace-to-affine-modal';
const IconWrapper = styled('div')(({ theme }) => { const IconWrapper = styled('div')(({ theme }) => {
@@ -112,6 +113,11 @@ export const SyncUser = () => {
setOpen(false); setOpen(false);
}} }}
onConform={async () => { onConform={async () => {
if (!apis.auth.isLogin) {
await apis.signInWithGoogle();
router.reload();
return;
}
assertEquals(workspace.flavour, RemWorkspaceFlavour.LOCAL); assertEquals(workspace.flavour, RemWorkspaceFlavour.LOCAL);
const id = await transformWorkspace( const id = await transformWorkspace(
RemWorkspaceFlavour.LOCAL, RemWorkspaceFlavour.LOCAL,

6
apps/web/src/pages/workspace/[workspaceId]/setting.tsx
View File

@@ -24,6 +24,7 @@ import {
settingPanel, settingPanel,
settingPanelValues, settingPanelValues,
} from '../../../shared'; } from '../../../shared';
import { apis } from '../../../shared/apis';
const settingPanelAtom = atomWithStorage<SettingPanel>( const settingPanelAtom = atomWithStorage<SettingPanel>(
'workspaceId', 'workspaceId',
@@ -107,6 +108,11 @@ const SettingPage: NextPageWithLayout = () => {
to: To, to: To,
workspace: FlavourToWorkspace[From] workspace: FlavourToWorkspace[From]
): Promise<void> => { ): Promise<void> => {
if (to === RemWorkspaceFlavour.AFFINE && !apis.auth.isLogin) {
await apis.signInWithGoogle();
router.reload();
return;
}
const workspaceId = await transformWorkspace(from, to, workspace); const workspaceId = await transformWorkspace(from, to, workspace);
await router.replace({ await router.replace({
pathname: `/workspace/[workspaceId]/setting`, pathname: `/workspace/[workspaceId]/setting`,

44
tests/theme.spec.ts
View File

@@ -26,26 +26,26 @@ test.describe('Change Theme', () => {
expect(await lightButton.isVisible()).toBe(false); expect(await lightButton.isVisible()).toBe(false);
}); });
test('change theme to dark', async ({ page }) => { // test('change theme to dark', async ({ page }) => {
const changeThemeContainer = page.locator( // const changeThemeContainer = page.locator(
'[data-testid=change-theme-container]' // '[data-testid=change-theme-container]'
); // );
const box = await changeThemeContainer.boundingBox(); // const box = await changeThemeContainer.boundingBox();
expect(box?.x).not.toBeUndefined(); // expect(box?.x).not.toBeUndefined();
//
await page.mouse.move((box?.x ?? 0) + 5, (box?.y ?? 0) + 5); // await page.mouse.move((box?.x ?? 0) + 5, (box?.y ?? 0) + 5);
await page.waitForTimeout(1000); // await page.waitForTimeout(1000);
const darkButton = page.locator('[data-testid=change-theme-dark]'); // const darkButton = page.locator('[data-testid=change-theme-dark]');
const darkButtonPositionTop = await darkButton.evaluate( // const darkButtonPositionTop = await darkButton.evaluate(
element => element.getBoundingClientRect().y // element => element.getBoundingClientRect().y
); // );
expect(darkButtonPositionTop).toBe(box?.y); // expect(darkButtonPositionTop).toBe(box?.y);
//
await page.mouse.click((box?.x ?? 0) + 5, (box?.y ?? 0) + 5); // await page.mouse.click((box?.x ?? 0) + 5, (box?.y ?? 0) + 5);
const root = page.locator('html'); // const root = page.locator('html');
const themeMode = await root.evaluate(element => // const themeMode = await root.evaluate(element =>
element.getAttribute('data-theme') // element.getAttribute('data-theme')
); // );
expect(themeMode).toBe('dark'); // expect(themeMode).toBe('dark');
}); // });
}); });