From 7a26c76e5333672a1f34f124aad8205cae3a0ea4 Mon Sep 17 00:00:00 2001
From: pengx17 <pengxiao@outlook.com>
Date: Wed, 18 Sep 2024 04:16:51 +0000
Subject: [PATCH] fix(electron): do not always enable devtools detach mode
 (#8273)

---
 .../electron/src/main/windows-manager/main-window.ts |  4 +---
 .../electron/src/main/windows-manager/tab-views.ts   | 12 +++---------
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/packages/frontend/apps/electron/src/main/windows-manager/main-window.ts b/packages/frontend/apps/electron/src/main/windows-manager/main-window.ts
index fccf07afb..19cc241ff 100644
--- a/packages/frontend/apps/electron/src/main/windows-manager/main-window.ts
+++ b/packages/frontend/apps/electron/src/main/windows-manager/main-window.ts
@@ -258,9 +258,7 @@ export async function openUrlInHiddenWindow(urlObj: URL) {
   });
 
   if (BUILD_CONFIG.debug) {
-    win.webContents.openDevTools({
-      mode: 'detach',
-    });
+    win.webContents.openDevTools();
   }
 
   win.on('close', e => {
diff --git a/packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts b/packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts
index 73455b6c4..e8fa68104 100644
--- a/packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts
+++ b/packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts
@@ -817,9 +817,7 @@ export class WebContentViewsManager {
 
       view.webContents.loadURL(shellViewUrl).catch(err => logger.error(err));
       if (isDev) {
-        view.webContents.openDevTools({
-          mode: 'detach',
-        });
+        view.webContents.openDevTools();
       }
     }
 
@@ -1003,17 +1001,13 @@ export const showDevTools = (id?: string) => {
   getCustomThemeWindow()
     .then(w => {
       if (w && w.isFocused()) {
-        w.webContents.openDevTools({
-          mode: 'detach',
-        });
+        w.webContents.openDevTools();
       } else {
         const view = id
           ? WebContentViewsManager.instance.getViewById(id)
           : WebContentViewsManager.instance.activeWorkbenchView;
         if (view) {
-          view.webContents.openDevTools({
-            mode: 'detach',
-          });
+          view.webContents.openDevTools();
         }
       }
     })