luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(editor): should not update table selection after table is destroyed (#9665)

Browse Source
This commit is contained in:
zzj3720
2025-01-13 10:43:02 +00:00
parent 7e5e6031e8
commit 80f8944188
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
blocksuite/affine/data-view/src/core/group-by/renderer/select-group.ts
View File

@@ -78,7 +78,7 @@ export class SelectGroupView extends BaseGroup<
}; };
get tag() { get tag() {
return this.data.options.find(v => v.id === this.value); return this.data.options?.find(v => v.id === this.value);
} }
protected override render(): unknown { protected override render(): unknown {

9
blocksuite/affine/data-view/src/view-presets/table/pc/controller/selection.ts
View File

@@ -1017,6 +1017,9 @@ export class SelectionElement extends WithDisposable(ShadowlessElement) {
this.disposables.add( this.disposables.add(
effect(() => { effect(() => {
this.startUpdate(this.selection$.value); this.startUpdate(this.selection$.value);
return () => {
this.cancelSelectionUpdate();
};
}) })
); );
} }
@@ -1033,11 +1036,15 @@ export class SelectionElement extends WithDisposable(ShadowlessElement) {
`; `;
} }
startUpdate(selection?: TableViewSelection) { cancelSelectionUpdate() {
if (this.preTask) { if (this.preTask) {
cancelAnimationFrame(this.preTask); cancelAnimationFrame(this.preTask);
this.preTask = 0; this.preTask = 0;
} }
}
startUpdate(selection?: TableViewSelection) {
this.cancelSelectionUpdate();
if ( if (
selection?.selectionType === 'area' && selection?.selectionType === 'area' &&
!this.controller.host.props.view.readonly$.value !this.controller.host.props.view.readonly$.value