luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(electron): do not add * as the default cors headers (#11867)

Browse Source 
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Refactor**
  - Simplified network request header handling and CORS header management for improved maintainability.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
pengx17
2025-04-24 05:09:50 +00:00
parent 814dfab0df
commit 85a21e97f6
1 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/frontend/apps/electron/src/main/protocol.ts
View File

@@ -34,13 +34,8 @@ protocol.registerSchemesAsPrivileged([
}, },
]); ]);
const NETWORK_REQUESTS = ['/api', '/ws', '/socket.io', '/graphql'];
const webStaticDir = join(resourcesPath, 'web-static'); const webStaticDir = join(resourcesPath, 'web-static');
function isNetworkResource(pathname: string) {
return NETWORK_REQUESTS.some(opt => pathname.startsWith(opt));
}
async function handleFileRequest(request: Request) { async function handleFileRequest(request: Request) {
const urlObject = new URL(request.url); const urlObject = new URL(request.url);
@@ -146,8 +141,8 @@ export function registerProtocol() {
delete responseHeaders['access-control-allow-origin']; delete responseHeaders['access-control-allow-origin'];
delete responseHeaders['access-control-allow-headers']; delete responseHeaders['access-control-allow-headers'];
responseHeaders['Access-Control-Allow-Origin'] = ['*']; delete responseHeaders['Access-Control-Allow-Origin'];
responseHeaders['Access-Control-Allow-Headers'] = ['*']; delete responseHeaders['Access-Control-Allow-Headers'];
} }
})() })()
.catch(err => { .catch(err => {
@@ -161,7 +156,6 @@ export function registerProtocol() {
session.defaultSession.webRequest.onBeforeSendHeaders((details, callback) => { session.defaultSession.webRequest.onBeforeSendHeaders((details, callback) => {
const url = new URL(details.url); const url = new URL(details.url);
const pathname = url.pathname;
(async () => { (async () => {
// session cookies are set to file:// on production // session cookies are set to file:// on production
@@ -181,12 +175,6 @@ export function registerProtocol() {
.join('; '); .join('; ');
delete details.requestHeaders['cookie']; delete details.requestHeaders['cookie'];
details.requestHeaders['Cookie'] = cookieString; details.requestHeaders['Cookie'] = cookieString;
// mitigate the issue of the worker not being able to access the origin
if (isNetworkResource(pathname)) {
details.requestHeaders['origin'] = url.origin;
details.requestHeaders['referer'] = url.origin;
}
} }
})() })()
.catch(err => { .catch(err => {