luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(core): should not refetch avatar when url does not change (#5070)

Browse Source 
blob resources are in fact immutable. We do not need to refetch it by swr policies (mount/visibilitychange/etc)
This commit is contained in:
Peng Xiao
2023-11-28 08:01:18 +00:00
parent 0ee2ecc1e9
commit 890e3e4435
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/frontend/hooks/src/use-block-suite-workspace-avatar-url.ts
View File

@@ -2,7 +2,7 @@ import { assertExists } from '@blocksuite/global/utils';
import type { Workspace } from '@blocksuite/store'; import type { Workspace } from '@blocksuite/store';
import reduce from 'image-blob-reduce'; import reduce from 'image-blob-reduce';
import { useCallback, useEffect, useState } from 'react'; import { useCallback, useEffect, useState } from 'react';
import useSWR from 'swr'; import useSWRImmutable from 'swr/immutable';
// validate and reduce image size and return as file // validate and reduce image size and return as file
export const validateAndReduceImage = async (file: File): Promise<File> => { export const validateAndReduceImage = async (file: File): Promise<File> => {
@@ -52,7 +52,7 @@ export function useBlockSuiteWorkspaceAvatarUrl(
if (url !== blockSuiteWorkspace.meta.avatar) { if (url !== blockSuiteWorkspace.meta.avatar) {
set(blockSuiteWorkspace.meta.avatar); set(blockSuiteWorkspace.meta.avatar);
} }
const { data: avatar, mutate } = useSWR(url, { const { data: avatar, mutate } = useSWRImmutable(url, {
fetcher: async avatar => { fetcher: async avatar => {
assertExists(blockSuiteWorkspace); assertExists(blockSuiteWorkspace);
const blobs = blockSuiteWorkspace.blob; const blobs = blockSuiteWorkspace.blob;
@@ -62,8 +62,7 @@ export function useBlockSuiteWorkspaceAvatarUrl(
} }
return null; return null;
}, },
suspense: true, suspense: false,
fallbackData: null,
}); });
const setAvatar = useCallback( const setAvatar = useCallback(