feat(editor): add delete key support for table view (#14119)

This PR allows the user to use the `Delete` key to delete the content of
one or more cells in a Table View. Previously, this was only possible to
do with the `Backspace` key. Both keys can now be used, which is often
the norm in other tools - such as Notion and Excel.

In short, the logic for the `Backspace` key has been moved to a separate
function which is called by keyevents from both the `Backspace` and
`Delete` keys.

Affected files: 
-
blocksuite/affine/data-view/src/view-presets/table/pc-virtual/controller/hotkeys.ts
-
blocksuite/affine/data-view/src/view-presets/table/pc/controller/hotkeys.ts

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Refactor**
* Optimized table hotkey handling logic to consolidate delete and
backspace operations for improved code maintainability.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Daniel Dybing
2025-12-21 20:17:05 +01:00
committed by GitHub
parent 321965a424
commit 8f59509e73
2 changed files with 104 additions and 100 deletions

View File

@@ -20,10 +20,7 @@ export class TableHotkeysController implements ReactiveController {
return this.logic.ui$.value; return this.logic.ui$.value;
} }
hostConnected() { private _handleDeleteOrBackspace() {
this.disposables.add(
this.logic.bindHotkey({
Backspace: () => {
const selection = this.selectionController.selection; const selection = this.selectionController.selection;
if (!selection) { if (!selection) {
return; return;
@@ -35,13 +32,8 @@ export class TableHotkeysController implements ReactiveController {
this.logic.ui$.value?.requestUpdate(); this.logic.ui$.value?.requestUpdate();
return; return;
} }
const { const { focus, rowsSelection, columnsSelection, isEditing, groupKey } =
focus, selection;
rowsSelection,
columnsSelection,
isEditing,
groupKey,
} = selection;
if (focus && !isEditing) { if (focus && !isEditing) {
if (rowsSelection && columnsSelection) { if (rowsSelection && columnsSelection) {
// multi cell // multi cell
@@ -74,6 +66,16 @@ export class TableHotkeysController implements ReactiveController {
} }
} }
} }
}
hostConnected() {
this.disposables.add(
this.logic.bindHotkey({
Backspace: () => {
this._handleDeleteOrBackspace();
},
Delete: () => {
this._handleDeleteOrBackspace();
}, },
Escape: () => { Escape: () => {
const selection = this.selectionController.selection; const selection = this.selectionController.selection;

View File

@@ -18,10 +18,7 @@ export class TableHotkeysController implements ReactiveController {
return this.logic.ui$.value; return this.logic.ui$.value;
} }
hostConnected() { private _handleDeleteOrBackspace() {
this.host?.disposables.add(
this.logic.bindHotkey({
Backspace: () => {
const selection = this.selectionController.selection; const selection = this.selectionController.selection;
if (!selection) { if (!selection) {
return; return;
@@ -33,13 +30,8 @@ export class TableHotkeysController implements ReactiveController {
this.logic.ui$.value?.requestUpdate(); this.logic.ui$.value?.requestUpdate();
return; return;
} }
const { const { focus, rowsSelection, columnsSelection, isEditing, groupKey } =
focus, selection;
rowsSelection,
columnsSelection,
isEditing,
groupKey,
} = selection;
if (focus && !isEditing) { if (focus && !isEditing) {
if (rowsSelection && columnsSelection) { if (rowsSelection && columnsSelection) {
// multi cell // multi cell
@@ -72,6 +64,16 @@ export class TableHotkeysController implements ReactiveController {
} }
} }
} }
}
hostConnected() {
this.host?.disposables.add(
this.logic.bindHotkey({
Backspace: () => {
this._handleDeleteOrBackspace();
},
Delete: () => {
this._handleDeleteOrBackspace();
}, },
Escape: () => { Escape: () => {
const selection = this.selectionController.selection; const selection = this.selectionController.selection;