luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(editor): deactivate editor when selection out of editor (#13490)

Browse Source 
Close
[AI-415](https://linear.app/affine-design/issue/AI-415/code-artifact-复制更好的支持code-block和插入正文)

#### PR Dependency Tree


* **PR #13490** 👈

This tree was auto-generated by
[Charcoal](https://github.com/danerwilliams/charcoal)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Editor now deactivates when text selection moves outside the app,
preventing unintended interactions.
* Better handling when selection changes to external content, reducing
cases where the editor stayed active incorrectly.

* **Stability**
* Improved reliability around selection, focus, and visibility changes
to avoid accidental edits or actions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->


#### PR Dependency Tree


* **PR #13490** 👈

This tree was auto-generated by
[Charcoal](https://github.com/danerwilliams/charcoal)
This commit is contained in:
L-Sun
2025-08-14 14:49:53 +08:00
committed by GitHub
parent 680f3b3006
commit 9d38f79395
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
blocksuite/framework/std/src/event/dispatcher.ts
View File

@@ -226,6 +226,18 @@ export class UIEventDispatcher extends LifeCycleWatcher {
this._setActive(false); this._setActive(false);
} }
}); });
// When the selection is outside the host, the event dispatcher should be inactive
this.disposables.addFromEvent(document, 'selectionchange', () => {
const sel = document.getSelection();
if (!sel || sel.rangeCount === 0) return;
const { anchorNode, focusNode } = sel;
if (
(anchorNode && !this.host.contains(anchorNode)) ||
(focusNode && !this.host.contains(focusNode))
) {
this._setActive(false);
}
});
} }
private _buildEventScopeBySelection(name: EventName) { private _buildEventScopeBySelection(name: EventName) {

2
tests/blocksuite/e2e/link.spec.ts
View File

@@ -241,6 +241,7 @@ test('should keyboard work in link popover', async ({ page }) => {
const toolbar = page.locator('affine-toolbar-widget editor-toolbar'); const toolbar = page.locator('affine-toolbar-widget editor-toolbar');
const linkLocator = page.locator(`text="${linkText}"`); const linkLocator = page.locator(`text="${linkText}"`);
await focusRichText(page);
// hover link // hover link
await linkLocator.hover(); await linkLocator.hover();
// wait for popover delay open // wait for popover delay open
@@ -294,6 +295,7 @@ test('link bar should not be appear when the range is collapsed', async ({
// create auto line-break in span element // create auto line-break in span element
await type(page, 'd'.repeat(67)); await type(page, 'd'.repeat(67));
await page.mouse.click(1, 1); await page.mouse.click(1, 1);
await focusRichText(page);
await waitNextFrame(page); await waitNextFrame(page);
await dragBetweenIndices(page, [1, 1], [1, 66]); await dragBetweenIndices(page, [1, 1], [1, 66]);
await pressCreateLinkShortCut(page); await pressCreateLinkShortCut(page);