test(editor): reduce flaky in turbo renderer test (#11973)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Improved test resource cleanup for the viewport turbo renderer, ensuring proper teardown after each test for more reliable and isolated test execution. - Enhanced stability by preventing errors during cleanup when certain elements or editors are absent. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
@@ -8,7 +8,7 @@ import {
|
|||||||
ViewportTurboRendererExtension,
|
ViewportTurboRendererExtension,
|
||||||
} from '@blocksuite/affine-gfx-turbo-renderer';
|
} from '@blocksuite/affine-gfx-turbo-renderer';
|
||||||
import { firstValueFrom } from 'rxjs';
|
import { firstValueFrom } from 'rxjs';
|
||||||
import { beforeEach, describe, expect, test } from 'vitest';
|
import { afterEach, beforeEach, describe, expect, test } from 'vitest';
|
||||||
|
|
||||||
import { wait } from '../utils/common.js';
|
import { wait } from '../utils/common.js';
|
||||||
import { addSampleNotes } from '../utils/doc-generator.js';
|
import { addSampleNotes } from '../utils/doc-generator.js';
|
||||||
@@ -19,8 +19,10 @@ import {
|
|||||||
} from '../utils/setup.js';
|
} from '../utils/setup.js';
|
||||||
|
|
||||||
describe('viewport turbo renderer', () => {
|
describe('viewport turbo renderer', () => {
|
||||||
|
let cleanup: () => void;
|
||||||
|
|
||||||
beforeEach(async () => {
|
beforeEach(async () => {
|
||||||
const cleanup = await setupEditor('edgeless', [
|
cleanup = await setupEditor('edgeless', [
|
||||||
ParagraphLayoutHandlerExtension,
|
ParagraphLayoutHandlerExtension,
|
||||||
TurboRendererConfigFactory({
|
TurboRendererConfigFactory({
|
||||||
painterWorkerEntry: createPainterWorker,
|
painterWorkerEntry: createPainterWorker,
|
||||||
@@ -30,6 +32,8 @@ describe('viewport turbo renderer', () => {
|
|||||||
return cleanup;
|
return cleanup;
|
||||||
});
|
});
|
||||||
|
|
||||||
|
afterEach(() => cleanup?.());
|
||||||
|
|
||||||
test('should render 6 notes in viewport', async () => {
|
test('should render 6 notes in viewport', async () => {
|
||||||
addSampleNotes(doc, 6);
|
addSampleNotes(doc, 6);
|
||||||
await wait();
|
await wait();
|
||||||
|
|||||||
@@ -129,13 +129,13 @@ export async function setupEditor(
|
|||||||
const appElement = await createEditor(collection, mode, extensions);
|
const appElement = await createEditor(collection, mode, extensions);
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
appElement.remove();
|
appElement?.remove();
|
||||||
cleanup();
|
cleanup();
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export function cleanup() {
|
export function cleanup() {
|
||||||
window.editor.remove();
|
window.editor?.remove();
|
||||||
|
|
||||||
delete (window as any).collection;
|
delete (window as any).collection;
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user