From a5872dff655ca9e5aa58dbe94d9901a5ccc45da0 Mon Sep 17 00:00:00 2001 From: doodlewind <7312949+doodlewind@users.noreply.github.com> Date: Fri, 9 May 2025 09:52:55 +0000 Subject: [PATCH] fix(editor): database scroll regression on mobile safari (#12203) This won't affect desktop behavior, since the `MobileDataViewTable` is a standalone entry different with the default `DataViewTable`. Horizontal scrolling needs to be disabled to prevent Safari render bug. ## Summary by CodeRabbit - **Style** - Updated table view styling on mobile to disable horizontal scrolling, improving stability on iOS Safari. - Removed platform-specific horizontal scrolling behavior for tables on desktop for a consistent experience. --- .../src/view-presets/table/mobile/table-view.ts | 7 ++++++- .../data-view/src/view-presets/table/pc/table-view.ts | 11 ----------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/blocksuite/affine/data-view/src/view-presets/table/mobile/table-view.ts b/blocksuite/affine/data-view/src/view-presets/table/mobile/table-view.ts index 6e410eacb..ce2162780 100644 --- a/blocksuite/affine/data-view/src/view-presets/table/mobile/table-view.ts +++ b/blocksuite/affine/data-view/src/view-presets/table/mobile/table-view.ts @@ -29,7 +29,12 @@ export class MobileDataViewTable extends DataViewBase< position: relative; width: 100%; padding-bottom: 4px; - overflow-x: scroll; + /** + * Disable horizontal scrolling to prevent crashes on iOS Safari + * See https://github.com/toeverything/AFFiNE/pull/12203 + * and https://github.com/toeverything/blocksuite/pull/8784 + */ + overflow-x: hidden; overflow-y: hidden; } diff --git a/blocksuite/affine/data-view/src/view-presets/table/pc/table-view.ts b/blocksuite/affine/data-view/src/view-presets/table/pc/table-view.ts index e80986d30..6f672e20f 100644 --- a/blocksuite/affine/data-view/src/view-presets/table/pc/table-view.ts +++ b/blocksuite/affine/data-view/src/view-presets/table/pc/table-view.ts @@ -54,17 +54,6 @@ const styles = css` overflow-y: hidden; } - /* Disable horizontal scrolling to prevent crashes on iOS Safari */ - affine-edgeless-root .affine-database-block-table { - @media (pointer: coarse) { - overflow: hidden; - } - @media (pointer: fine) { - overflow-x: scroll; - overflow-y: hidden; - } - } - .affine-database-block-table:hover { padding-bottom: 0px; }