From c5b0057778a3c7bfb81db623c4595e9f28cb9667 Mon Sep 17 00:00:00 2001
From: Hana B <158238445+HanaB14@users.noreply.github.com>
Date: Wed, 15 Apr 2026 02:49:41 -0400
Subject: [PATCH] fix(core): resolve remaining untranslated doc title case in
detail page header (#14820)
fix #14735
This PR fixes a remaining desktop case related to #14467.
The previous fix resolved incorrect translation in navigation panels,
but the detail page header tab title was still passing custom document
titles through `i18n.t()`, causing user-defined titles to be
unexpectedly translated.
### Results
https://github.com/user-attachments/assets/4abad3b9-d5d7-442f-b643-6d9ea63fa741
After:
## Summary by CodeRabbit
* **Refactor**
* Updated page title retrieval mechanism in workspace detail page
headers. The title is now sourced directly from the document display
metadata service instead of using the previous derivation method.
---
.../pages/workspace/detail-page/detail-page-header.tsx | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/packages/frontend/core/src/desktop/pages/workspace/detail-page/detail-page-header.tsx b/packages/frontend/core/src/desktop/pages/workspace/detail-page/detail-page-header.tsx
index d8f2834c3..b8e8f1f5a 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/detail-page/detail-page-header.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/detail-page/detail-page-header.tsx
@@ -97,8 +97,7 @@ export function JournalPageHeader({ page, workspace }: PageHeaderProps) {
useDetailPageHeaderResponsive(containerWidth);
const docDisplayMetaService = useService(DocDisplayMetaService);
- const i18n = useI18n();
- const title = i18n.t(useLiveData(docDisplayMetaService.title$(page.id)));
+ const title = useLiveData(docDisplayMetaService.title$(page.id));
return (
@@ -147,8 +146,7 @@ export function NormalPageHeader({ page, workspace }: PageHeaderProps) {
}, []);
const docDisplayMetaService = useService(DocDisplayMetaService);
- const i18n = useI18n();
- const title = i18n.t(useLiveData(docDisplayMetaService.title$(page.id)));
+ const title = useLiveData(docDisplayMetaService.title$(page.id));
const editor = useService(EditorService).editor;
const currentMode = useLiveData(editor.mode$);