luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor(core): side bar resizing (#5280)

Browse Source 
Rewrite sidebar panel using a customized react-resizable-panels version that supports sidebar pixel sizing (not using flex percentages).

Now the left & right sidebar using the same `ResizePanel` impl.

fix https://github.com/toeverything/AFFiNE/issues/5271
fix TOV-163
fix TOV-146
fix TOV-168
fix TOV-109
fix TOV-165
This commit is contained in:
Peng Xiao
2023-12-13 07:52:01 +00:00
parent 2a9a6855f4
commit ce64685176
16 changed files with 406 additions and 386 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/affine-local/e2e/layout.spec.ts
View File

@@ -34,7 +34,10 @@ test('Click resizer can close sidebar', async ({ page }) => {
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).toBeVisible();
await page.getByTestId('app-sidebar-resizer').click();
await page
.getByTestId('app-sidebar-wrapper')
.getByTestId('resize-handle')
.click();
await expect(sliderBarArea).not.toBeInViewport();
});
@@ -44,7 +47,9 @@ test('Drag resizer can resize sidebar', async ({ page }) => {
const sliderBarArea = page.getByTestId('sliderBar-inner');
await expect(sliderBarArea).toBeVisible();
const sliderResizer = page.getByTestId('app-sidebar-resizer');
const sliderResizer = page
.getByTestId('app-sidebar-wrapper')
.getByTestId('resize-handle');
await sliderResizer.hover();
await page.mouse.down();
await page.mouse.move(400, 300, {