From d379143db3bae2cf8e02aa6e36b265086dddc498 Mon Sep 17 00:00:00 2001
From: JimmFly <yangjinfei001@gmail.com>
Date: Thu, 8 May 2025 09:55:23 +0000
Subject: [PATCH] refactor(core): use overcapacityMemberCount for quota
 checking instead of calculating the difference (#12117)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **Bug Fixes**
  - Improved accuracy of member quota warnings by updating the logic that detects when the member limit has been exceeded.
  - Enhanced test reliability by adjusting member list pagination test to better handle confirmation modals.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 packages/frontend/core/src/modules/quota/views/quota-check.tsx | 3 +--
 tests/affine-cloud/e2e/workspace.spec.ts                       | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/packages/frontend/core/src/modules/quota/views/quota-check.tsx b/packages/frontend/core/src/modules/quota/views/quota-check.tsx
index 4ae4f26f1..89aba6366 100644
--- a/packages/frontend/core/src/modules/quota/views/quota-check.tsx
+++ b/packages/frontend/core/src/modules/quota/views/quota-check.tsx
@@ -57,8 +57,7 @@ export const QuotaCheck = ({
     if (workspaceMeta.flavour === 'local' || !quota || isTeam) {
       return;
     }
-    const memberOverflow = quota.memberCount > quota.memberLimit;
-    // remember to use real percent
+    const memberOverflow = quota.overcapacityMemberCount > 0;
     const storageOverflow = usedPercent && usedPercent >= 100;
     const message = getSyncPausedMessage(
       !!isOwner,
diff --git a/tests/affine-cloud/e2e/workspace.spec.ts b/tests/affine-cloud/e2e/workspace.spec.ts
index 372e4c519..27e3313a3 100644
--- a/tests/affine-cloud/e2e/workspace.spec.ts
+++ b/tests/affine-cloud/e2e/workspace.spec.ts
@@ -62,8 +62,6 @@ test('should have pagination in member list', async ({ page }) => {
 
   await page.waitForTimeout(1000);
 
-  await page.getByTestId('confirm-modal-cancel').click();
-
   const firstPageMemberItemCount = await page
     .locator('[data-testid="member-item"]')
     .count();