chore(core): adjust ai onboarding dismiss logic, persist dialog and dismiss once closed (#7417)

This commit is contained in:
CatsJuice
2024-07-04 07:00:17 +00:00
parent b79d13bcc8
commit d6ad7d566f
2 changed files with 86 additions and 58 deletions

View File

@@ -10,7 +10,7 @@ import * as VisuallyHidden from '@radix-ui/react-visually-hidden';
import { assignInlineVars } from '@vanilla-extract/dynamic'; import { assignInlineVars } from '@vanilla-extract/dynamic';
import clsx from 'clsx'; import clsx from 'clsx';
import type { CSSProperties } from 'react'; import type { CSSProperties } from 'react';
import { forwardRef } from 'react'; import { forwardRef, useCallback } from 'react';
import type { IconButtonProps } from '../button'; import type { IconButtonProps } from '../button';
import { IconButton } from '../button'; import { IconButton } from '../button';
@@ -23,12 +23,20 @@ export interface ModalProps extends DialogProps {
title?: React.ReactNode; title?: React.ReactNode;
description?: React.ReactNode; description?: React.ReactNode;
withoutCloseButton?: boolean; withoutCloseButton?: boolean;
/**
* __Click outside__ or __Press `Esc`__ won't close the modal
* @default false
*/
persistent?: boolean;
portalOptions?: DialogPortalProps; portalOptions?: DialogPortalProps;
contentOptions?: DialogContentProps; contentOptions?: DialogContentProps;
overlayOptions?: DialogOverlayProps; overlayOptions?: DialogOverlayProps;
closeButtonOptions?: IconButtonProps; closeButtonOptions?: IconButtonProps;
} }
type PointerDownOutsideEvent = Parameters<
Exclude<DialogContentProps['onPointerDownOutside'], undefined>
>[0];
const getVar = (style: number | string = '', defaultValue = '') => { const getVar = (style: number | string = '', defaultValue = '') => {
return style return style
@@ -48,11 +56,14 @@ export const Modal = forwardRef<HTMLDivElement, ModalProps>(
description, description,
withoutCloseButton = false, withoutCloseButton = false,
modal, modal,
persistent,
portalOptions, portalOptions,
contentOptions: { contentOptions: {
style: contentStyle, style: contentStyle,
className: contentClassName, className: contentClassName,
onPointerDownOutside,
onEscapeKeyDown,
...otherContentOptions ...otherContentOptions
} = {}, } = {},
overlayOptions: { overlayOptions: {
@@ -64,7 +75,8 @@ export const Modal = forwardRef<HTMLDivElement, ModalProps>(
...props ...props
}, },
ref ref
) => ( ) => {
return (
<Dialog.Root modal={modal} {...props}> <Dialog.Root modal={modal} {...props}>
<Dialog.Portal {...portalOptions}> <Dialog.Portal {...portalOptions}>
<Dialog.Overlay <Dialog.Overlay
@@ -73,6 +85,20 @@ export const Modal = forwardRef<HTMLDivElement, ModalProps>(
/> />
<div data-modal={modal} className={clsx(styles.modalContentWrapper)}> <div data-modal={modal} className={clsx(styles.modalContentWrapper)}>
<Dialog.Content <Dialog.Content
onPointerDownOutside={useCallback(
(e: PointerDownOutsideEvent) => {
onPointerDownOutside?.(e);
persistent && e.preventDefault();
},
[onPointerDownOutside, persistent]
)}
onEscapeKeyDown={useCallback(
(e: KeyboardEvent) => {
onEscapeKeyDown?.(e);
persistent && e.preventDefault();
},
[onEscapeKeyDown, persistent]
)}
className={clsx(styles.modalContent, contentClassName)} className={clsx(styles.modalContent, contentClassName)}
style={{ style={{
...assignInlineVars({ ...assignInlineVars({
@@ -120,7 +146,8 @@ export const Modal = forwardRef<HTMLDivElement, ModalProps>(
</div> </div>
</Dialog.Portal> </Dialog.Portal>
</Dialog.Root> </Dialog.Root>
) );
}
); );
Modal.displayName = 'Modal'; Modal.displayName = 'Modal';

View File

@@ -184,10 +184,11 @@ export const AIOnboardingGeneral = () => {
return readyToOpen ? ( return readyToOpen ? (
<Modal <Modal
persistent
open={open} open={open}
onOpenChange={v => { onOpenChange={v => {
showAIOnboardingGeneral$.next(v); showAIOnboardingGeneral$.next(v);
if (!v && isLast) toggleGeneralAIOnboarding(false); if (!v) toggleGeneralAIOnboarding(false);
}} }}
contentOptions={{ className: styles.dialog }} contentOptions={{ className: styles.dialog }}
overlayOptions={{ className: baseStyles.dialogOverlay }} overlayOptions={{ className: baseStyles.dialogOverlay }}