From dc68c2385d9a9d12ca9466d0727a6637c149f7d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=BE=B7=E5=B8=83=E5=8A=B3=E5=A4=96=20=C2=B7=20=E8=B4=BE?=
 =?UTF-8?q?=E8=B4=B5?= <472285740@qq.com>
Date: Thu, 17 Jul 2025 17:16:26 +0800
Subject: [PATCH] fix(core): ai apply ui opt (#13238)

> CLOSE AI-377 AI-372 AI-373 AI-381 AI-378 AI-374 AI-382 AI-375

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Style**
* Improved button styling for tool controls, including hover effects and
consistent padding.
* Updated background colors and border placements for result cards and
headers.

* **New Features**
  * Added tooltips to control buttons for enhanced user guidance.

* **Bug Fixes**
* Improved accessibility by replacing clickable spans with button
elements.
* Updated loading indicators to use a spinner icon for clearer feedback
during actions.

* **Refactor**
* Simplified layout and reduced unnecessary wrapper elements for cleaner
rendering.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../ai/components/ai-tools/doc-edit.ts        | 105 ++++++++++--------
 1 file changed, 58 insertions(+), 47 deletions(-)

diff --git a/packages/frontend/core/src/blocksuite/ai/components/ai-tools/doc-edit.ts b/packages/frontend/core/src/blocksuite/ai/components/ai-tools/doc-edit.ts
index 390485fe6..d222a0095 100644
--- a/packages/frontend/core/src/blocksuite/ai/components/ai-tools/doc-edit.ts
+++ b/packages/frontend/core/src/blocksuite/ai/components/ai-tools/doc-edit.ts
@@ -2,7 +2,7 @@ import track from '@affine/track';
 import { WithDisposable } from '@blocksuite/affine/global/lit';
 import { unsafeCSSVar, unsafeCSSVarV2 } from '@blocksuite/affine/shared/theme';
 import { type EditorHost, ShadowlessElement } from '@blocksuite/affine/std';
-import { AIStarIconWithAnimation } from '@blocksuite/affine-components/icons';
+import { LoadingIcon } from '@blocksuite/affine-components/icons';
 import type { NotificationService } from '@blocksuite/affine-shared/services';
 import {
   CloseIcon,
@@ -83,7 +83,7 @@ export class DocEditTool extends WithDisposable(ShadowlessElement) {
       display: flex;
       flex-direction: column;
       align-items: flex-start;
-      background: ${unsafeCSSVarV2('layer/background/overlayPanel')};
+      background: ${unsafeCSSVar('--affine-overlay-panel-shadow')};
       box-shadow: ${unsafeCSSVar('shadow1')};
       border-radius: 8px;
       width: 100%;
@@ -96,7 +96,6 @@ export class DocEditTool extends WithDisposable(ShadowlessElement) {
 
         width: 100%;
         justify-content: space-between;
-        border-bottom: 1px solid ${unsafeCSSVarV2('layer/insideBorder/border')};
 
         .doc-edit-tool-result-card-header-title {
           display: flex;
@@ -118,9 +117,17 @@ export class DocEditTool extends WithDisposable(ShadowlessElement) {
           padding-right: 8px;
           color: ${unsafeCSSVarV2('text/secondary')};
 
-          span {
-            width: 20px;
-            height: 20px;
+          button {
+            cursor: pointer;
+            padding: 2px;
+            display: flex;
+            align-items: center;
+            justify-content: center;
+            border-radius: 4px;
+          }
+
+          button:hover {
+            background: ${unsafeCSSVar('hoverColor')};
           }
         }
       }
@@ -128,23 +135,27 @@ export class DocEditTool extends WithDisposable(ShadowlessElement) {
       .doc-edit-tool-result-card-content {
         padding: 8px;
         width: 100%;
+        border-top: 1px solid ${unsafeCSSVarV2('layer/insideBorder/border')};
       }
 
       .doc-edit-tool-result-card-footer {
         display: flex;
         justify-content: flex-end;
         align-items: center;
-        padding: 8px;
         gap: 4px;
         width: 100%;
         cursor: pointer;
 
-        .doc-edit-tool-result-reject,
-        .doc-edit-tool-result-accept {
+        button {
           display: flex;
           align-items: center;
           gap: 4px;
-          padding: 8px;
+          padding: 4px;
+          border-radius: 4px;
+        }
+
+        button:hover {
+          background: ${unsafeCSSVar('hoverColor')};
         }
       }
 
@@ -421,55 +432,55 @@ export class DocEditTool extends WithDisposable(ShadowlessElement) {
                     ${docId}
                   </div>
                   <div class="doc-edit-tool-result-card-header-operations">
-                    <span @click=${() => this._toggleCollapse()}
-                      >${this.isCollapsed
-                        ? ExpandFullIcon()
-                        : ExpandCloseIcon()}</span
-                    >
-                    <span @click=${() => this._handleCopy(changedContent)}>
+                    <button @click=${() => this._toggleCollapse()}>
+                      ${this.isCollapsed ? ExpandFullIcon() : ExpandCloseIcon()}
+                      <affine-tooltip>
+                        ${this.isCollapsed ? 'Expand' : 'Collapse'}
+                      </affine-tooltip>
+                    </button>
+                    <button @click=${() => this._handleCopy(changedContent)}>
                       ${CopyIcon()}
-                    </span>
+                      <affine-tooltip>Copy</affine-tooltip>
+                    </button>
                     <button
                       @click=${() => this._handleApply(op, updates)}
                       ?disabled=${this.isBusyForOp(op)}
                     >
                       ${this.applyingMap[op]
-                        ? AIStarIconWithAnimation
-                        : html`Apply`}
+                        ? html`${LoadingIcon()} Applying`
+                        : 'Apply'}
                     </button>
                   </div>
                 </div>
                 <div class="doc-edit-tool-result-card-content">
-                  <div class="doc-edit-tool-result-card-content-title">
-                    ${this.renderBlockDiffs(diffs)}
+                  ${this.renderBlockDiffs(diffs)}
+                  <div class="doc-edit-tool-result-card-footer">
+                    <button
+                      class="doc-edit-tool-result-reject"
+                      @click=${() => this._handleReject(op)}
+                    >
+                      ${CloseIcon({
+                        style: `color: ${unsafeCSSVarV2('icon/secondary')}`,
+                      })}
+                      Reject
+                    </button>
+                    <button
+                      class="doc-edit-tool-result-accept"
+                      @click=${() => this._handleAccept(op, updates)}
+                      ?disabled=${this.isBusyForOp(op)}
+                      style="${this.isBusyForOp(op)
+                        ? 'pointer-events: none; opacity: 0.6;'
+                        : ''}"
+                    >
+                      ${this.acceptingMap[op]
+                        ? html`${LoadingIcon()}`
+                        : DoneIcon({
+                            style: `color: ${unsafeCSSVarV2('icon/activated')}`,
+                          })}
+                      ${this.acceptingMap[op] ? 'Accepting...' : 'Accept'}
+                    </button>
                   </div>
                 </div>
-                <div class="doc-edit-tool-result-card-footer">
-                  <div
-                    class="doc-edit-tool-result-reject"
-                    @click=${() => this._handleReject(op)}
-                  >
-                    ${CloseIcon({
-                      style: `color: ${unsafeCSSVarV2('icon/secondary')}`,
-                    })}
-                    Reject
-                  </div>
-                  <button
-                    class="doc-edit-tool-result-accept"
-                    @click=${() => this._handleAccept(op, updates)}
-                    ?disabled=${this.isBusyForOp(op)}
-                    style="${this.isBusyForOp(op)
-                      ? 'pointer-events: none; opacity: 0.6;'
-                      : ''}"
-                  >
-                    ${this.acceptingMap[op]
-                      ? AIStarIconWithAnimation
-                      : DoneIcon({
-                          style: `color: ${unsafeCSSVarV2('icon/activated')}`,
-                        })}
-                    ${this.acceptingMap[op] ? 'Accepting...' : 'Accept'}
-                  </button>
-                </div>
               </div>
             </div>
           `;