luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(core): use openExternal in electron (#8323)

Browse Source
This commit is contained in:
forehalo
2024-09-20 07:05:12 +00:00
parent 8d4cc6a1db
commit ec7c63019f
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/frontend/core/src/utils/popup.ts
View File

@@ -1,3 +1,8 @@
import { DebugLogger } from '@affine/debug';
import { apis } from '@affine/electron-api';
const logger = new DebugLogger('popup');
export function popupWindow(target: string) { export function popupWindow(target: string) {
target = /^https?:\/\//.test(target) target = /^https?:\/\//.test(target)
? target ? target
@@ -14,5 +19,11 @@ export function popupWindow(target: string) {
url = builder.toString(); url = builder.toString();
} }
return window.open(url, '_blank', `noreferrer noopener`); if (BUILD_CONFIG.isElectron) {
apis?.ui.openExternal(url).catch(e => {
logger.error('Failed to open external URL', e);
});
} else {
window.open(url, '_blank', `noreferrer noopener`);
}
} }