From f6a62fa73728dfdec15342813b75f8552eff7c4f Mon Sep 17 00:00:00 2001 From: zzj3720 <17165520+zzj3720@users.noreply.github.com> Date: Thu, 13 Mar 2025 03:17:48 +0000 Subject: [PATCH] fix(editor): clicking the sorting button results in an error (#10800) --- blocksuite/affine/data-view/src/core/data-view.ts | 8 +++----- blocksuite/affine/data-view/src/core/view/data-view.ts | 4 +--- .../table/pc/header/database-header-column.ts | 3 +-- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/blocksuite/affine/data-view/src/core/data-view.ts b/blocksuite/affine/data-view/src/core/data-view.ts index c183bd17e..60ccf77a0 100644 --- a/blocksuite/affine/data-view/src/core/data-view.ts +++ b/blocksuite/affine/data-view/src/core/data-view.ts @@ -63,9 +63,7 @@ export class DataViewRenderer extends SignalWatcher( } `; - private readonly _view = signal<{ - expose: DataViewInstance; - }>(); + private readonly _view = signal(); @property({ attribute: false }) accessor config!: DataViewRendererConfig; @@ -121,7 +119,7 @@ export class DataViewRenderer extends SignalWatcher( }); focusFirstCell = () => { - this.view?.expose.focusFirstCell(); + this.view?.focusFirstCell(); }; openDetailPanel = (ops: { @@ -224,7 +222,7 @@ export class DataView { private readonly _ref = createRef(); get expose() { - return this._ref.value?.view?.expose; + return this._ref.value?.view; } render(props: DataViewRendererConfig) { diff --git a/blocksuite/affine/data-view/src/core/view/data-view.ts b/blocksuite/affine/data-view/src/core/view/data-view.ts index 2545a3301..109259ee9 100644 --- a/blocksuite/affine/data-view/src/core/view/data-view.ts +++ b/blocksuite/affine/data-view/src/core/view/data-view.ts @@ -44,9 +44,7 @@ type DataViewComponent = UniComponent< { props: DataViewProps; }, - { - expose: DataViewInstance; - } + DataViewInstance >; export interface DataViewRendererConfig { diff --git a/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts b/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts index fd72a699f..94964de40 100644 --- a/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts +++ b/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts @@ -169,8 +169,7 @@ export class DatabaseHeaderColumn extends SignalWatcher( const sortUtils = createSortUtils( sortTrait, - this.closest('affine-data-view-renderer')?.view?.expose.eventTrace ?? - (() => {}) + this.closest('affine-data-view-renderer')?.view?.eventTrace ?? (() => {}) ); const sortList = sortUtils.sortList$.value; const existingIndex = sortList.findIndex(