From fbf590ddd43cee5003ecf3c97325ad57b20199c6 Mon Sep 17 00:00:00 2001
From: EYHN <cneyhn@gmail.com>
Date: Mon, 19 May 2025 09:15:37 +0000
Subject: [PATCH] feat(core): support save and restore display preference in
 all docs (#12315)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **New Features**
  - Display preferences and selected collections are now saved and restored across sessions, providing a persistent and personalized experience in the All Documents page.

- **Refactor**
  - Display settings menus and related components have been updated to use a controlled component pattern, allowing preferences to be managed externally for improved consistency and flexibility.
  - Preference state management has been consolidated, simplifying how display options are handled throughout the interface.
  - Various headers and detail views now accept display preferences and update callbacks as props, enabling external control of display settings.
  - Components previously relying on internal context and reactive streams were refactored to receive explicit props and callbacks for state management.

- **Bug Fixes**
  - Improved collection activation logic to prevent unnecessary updates when the selected collection is already active.
  - Added fallback default view to ensure consistent display in document list items.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../infra/src/framework/react/index.tsx       |  4 +-
 .../core/src/components/explorer/context.ts   | 66 ++++++++++++-----
 .../explorer/display-menu/index.tsx           | 74 ++++++++++++++-----
 .../explorer/display-menu/properties.tsx      | 45 +++++++----
 .../explorer/display-menu/quick-actions.tsx   | 49 ++++++++----
 .../explorer/display-menu/view-toggle.tsx     | 20 ++---
 .../explorer/docs-view/doc-list-item.tsx      |  4 +-
 .../explorer/quick-actions.constants.tsx      |  7 +-
 .../core/src/components/explorer/types.ts     |  7 +-
 .../workspace/all-page/all-page-header.tsx    | 31 +++++++-
 .../pages/workspace/all-page/all-page.tsx     | 54 ++++++++++++--
 .../workspace/all-page/pinned-collections.tsx | 12 ++-
 .../pages/workspace/collection/header.tsx     | 23 +++++-
 .../pages/workspace/collection/index.tsx      | 16 +++-
 .../desktop/pages/workspace/tag/header.tsx    | 18 ++++-
 .../src/desktop/pages/workspace/tag/index.tsx | 19 ++++-
 16 files changed, 344 insertions(+), 105 deletions(-)

diff --git a/packages/common/infra/src/framework/react/index.tsx b/packages/common/infra/src/framework/react/index.tsx
index 4805e37ac..296510d91 100644
--- a/packages/common/infra/src/framework/react/index.tsx
+++ b/packages/common/infra/src/framework/react/index.tsx
@@ -12,9 +12,7 @@ export function useFramework(): FrameworkProvider {
   return useContext(FrameworkProviderContext); // never null, because the default value
 }
 
-export function useService<T extends Service>(
-  identifier: GeneralIdentifier<T>
-): T {
+export function useService<T>(identifier: GeneralIdentifier<T>): T {
   return useContext(FrameworkProviderContext).get(identifier);
 }
 
diff --git a/packages/frontend/core/src/components/explorer/context.ts b/packages/frontend/core/src/components/explorer/context.ts
index 8ab7a2a05..8d58e8ba2 100644
--- a/packages/frontend/core/src/components/explorer/context.ts
+++ b/packages/frontend/core/src/components/explorer/context.ts
@@ -1,19 +1,18 @@
 import { LiveData } from '@toeverything/infra';
 import { createContext } from 'react';
 
-import type { DocListItemView } from './docs-view/doc-list-item';
-import type { ExplorerPreference } from './types';
+import type { ExplorerDisplayPreference } from './types';
 
 export type DocExplorerContextType = {
-  view$: LiveData<DocListItemView>;
   groups$: LiveData<Array<{ key: string; items: string[] }>>;
   collapsedGroups$: LiveData<string[]>;
   selectMode$?: LiveData<boolean>;
   selectedDocIds$: LiveData<string[]>;
   prevCheckAnchorId$?: LiveData<string | null>;
+  displayPreference$: LiveData<ExplorerDisplayPreference>;
 } & {
-  [K in keyof Omit<ExplorerPreference, 'filters'> as `${K}$`]: LiveData<
-    ExplorerPreference[K]
+  [K in keyof ExplorerDisplayPreference as `${K}$`]: LiveData<
+    ExplorerDisplayPreference[K]
   >;
 };
 
@@ -21,24 +20,51 @@ export const DocExplorerContext = createContext<DocExplorerContextType>(
   {} as any
 );
 
-export const createDocExplorerContext = () =>
-  ({
-    view$: new LiveData<DocListItemView>('list'),
+export const createDocExplorerContext = (
+  initialState?: ExplorerDisplayPreference
+) => {
+  const displayPreference$ = new LiveData<ExplorerDisplayPreference>(
+    initialState ?? {}
+  );
+  return {
     groups$: new LiveData<Array<{ key: string; items: string[] }>>([]),
     collapsedGroups$: new LiveData<string[]>([]),
     selectMode$: new LiveData<boolean>(false),
     selectedDocIds$: new LiveData<string[]>([]),
     prevCheckAnchorId$: new LiveData<string | null>(null),
-    groupBy$: new LiveData<ExplorerPreference['groupBy']>(undefined),
-    orderBy$: new LiveData<ExplorerPreference['orderBy']>(undefined),
-    displayProperties$: new LiveData<ExplorerPreference['displayProperties']>(
-      []
+    displayPreference$: displayPreference$,
+    view$: displayPreference$.selector(
+      displayPreference => displayPreference.view
     ),
-    showDocIcon$: new LiveData<ExplorerPreference['showDocIcon']>(true),
-    showDocPreview$: new LiveData<ExplorerPreference['showDocPreview']>(true),
-    quickFavorite$: new LiveData<ExplorerPreference['quickFavorite']>(false),
-    quickSelect$: new LiveData<ExplorerPreference['quickSelect']>(false),
-    quickSplit$: new LiveData<ExplorerPreference['quickSplit']>(false),
-    quickTrash$: new LiveData<ExplorerPreference['quickTrash']>(false),
-    quickTab$: new LiveData<ExplorerPreference['quickTab']>(false),
-  }) satisfies DocExplorerContextType;
+    groupBy$: displayPreference$.selector(
+      displayPreference => displayPreference.groupBy
+    ),
+    orderBy$: displayPreference$.selector(
+      displayPreference => displayPreference.orderBy
+    ),
+    displayProperties$: displayPreference$.selector(
+      displayPreference => displayPreference.displayProperties
+    ),
+    showDocIcon$: displayPreference$.selector(
+      displayPreference => displayPreference.showDocIcon
+    ),
+    showDocPreview$: displayPreference$.selector(
+      displayPreference => displayPreference.showDocPreview
+    ),
+    quickFavorite$: displayPreference$.selector(
+      displayPreference => displayPreference.quickFavorite
+    ),
+    quickSelect$: displayPreference$.selector(
+      displayPreference => displayPreference.quickSelect
+    ),
+    quickSplit$: displayPreference$.selector(
+      displayPreference => displayPreference.quickSplit
+    ),
+    quickTrash$: displayPreference$.selector(
+      displayPreference => displayPreference.quickTrash
+    ),
+    quickTab$: displayPreference$.selector(
+      displayPreference => displayPreference.quickTab
+    ),
+  } satisfies DocExplorerContextType;
+};
diff --git a/packages/frontend/core/src/components/explorer/display-menu/index.tsx b/packages/frontend/core/src/components/explorer/display-menu/index.tsx
index fc2b0f1d4..86df96800 100644
--- a/packages/frontend/core/src/components/explorer/display-menu/index.tsx
+++ b/packages/frontend/core/src/components/explorer/display-menu/index.tsx
@@ -11,63 +11,87 @@ import type {
 } from '@affine/core/modules/collection-rules/types';
 import { useI18n } from '@affine/i18n';
 import { ArrowDownSmallIcon } from '@blocksuite/icons/rc';
-import { useLiveData } from '@toeverything/infra';
 import type React from 'react';
-import { useCallback, useContext } from 'react';
+import { useCallback } from 'react';
 
-import { DocExplorerContext } from '../context';
+import type { ExplorerDisplayPreference } from '../types';
 import { GroupByList, GroupByName } from './group';
 import { OrderByList, OrderByName } from './order';
 import { DisplayProperties } from './properties';
 import { QuickActionsConfig } from './quick-actions';
 import * as styles from './styles.css';
 
-const ExplorerDisplayMenu = () => {
+const ExplorerDisplayMenu = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
   const t = useI18n();
-  const explorerContextValue = useContext(DocExplorerContext);
-  const groupBy = useLiveData(explorerContextValue.groupBy$);
-  const orderBy = useLiveData(explorerContextValue.orderBy$);
 
   const handleGroupByChange = useCallback(
     (groupBy: GroupByParams) => {
-      explorerContextValue.groupBy$?.next(groupBy);
+      onDisplayPreferenceChange({ ...displayPreference, groupBy });
     },
-    [explorerContextValue.groupBy$]
+    [displayPreference, onDisplayPreferenceChange]
   );
 
   const handleOrderByChange = useCallback(
     (orderBy: OrderByParams) => {
-      explorerContextValue.orderBy$?.next(orderBy);
+      onDisplayPreferenceChange({ ...displayPreference, orderBy });
     },
-    [explorerContextValue.orderBy$]
+    [displayPreference, onDisplayPreferenceChange]
   );
 
   return (
     <div className={styles.displayMenuContainer}>
       <MenuSub
-        items={<GroupByList groupBy={groupBy} onChange={handleGroupByChange} />}
+        items={
+          <GroupByList
+            groupBy={displayPreference.groupBy}
+            onChange={handleGroupByChange}
+          />
+        }
       >
         <div className={styles.subMenuSelectorContainer}>
           <span>{t['com.affine.explorer.display-menu.grouping']()}</span>
           <span className={styles.subMenuSelectorSelected}>
-            {groupBy ? <GroupByName groupBy={groupBy} /> : null}
+            {displayPreference.groupBy ? (
+              <GroupByName groupBy={displayPreference.groupBy} />
+            ) : null}
           </span>
         </div>
       </MenuSub>
       <MenuSub
-        items={<OrderByList orderBy={orderBy} onChange={handleOrderByChange} />}
+        items={
+          <OrderByList
+            orderBy={displayPreference.orderBy}
+            onChange={handleOrderByChange}
+          />
+        }
       >
         <div className={styles.subMenuSelectorContainer}>
           <span>{t['com.affine.explorer.display-menu.ordering']()}</span>
           <span className={styles.subMenuSelectorSelected}>
-            {orderBy ? <OrderByName orderBy={orderBy} /> : null}
+            {displayPreference.orderBy ? (
+              <OrderByName orderBy={displayPreference.orderBy} />
+            ) : null}
           </span>
         </div>
       </MenuSub>
       <Divider size="thinner" />
-      <DisplayProperties />
+      <DisplayProperties
+        displayPreference={displayPreference}
+        onDisplayPreferenceChange={onDisplayPreferenceChange}
+      />
       <Divider size="thinner" />
-      <QuickActionsConfig />
+      <QuickActionsConfig
+        displayPreference={displayPreference}
+        onDisplayPreferenceChange={onDisplayPreferenceChange}
+      />
     </div>
   );
 };
@@ -76,14 +100,28 @@ export const ExplorerDisplayMenuButton = ({
   style,
   className,
   menuProps,
+  displayPreference,
+  onDisplayPreferenceChange,
 }: {
   style?: React.CSSProperties;
   className?: string;
   menuProps?: Omit<MenuProps, 'items' | 'children'>;
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
 }) => {
   const t = useI18n();
   return (
-    <Menu items={<ExplorerDisplayMenu />} {...menuProps}>
+    <Menu
+      items={
+        <ExplorerDisplayMenu
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={onDisplayPreferenceChange}
+        />
+      }
+      {...menuProps}
+    >
       <Button
         className={className}
         style={style}
diff --git a/packages/frontend/core/src/components/explorer/display-menu/properties.tsx b/packages/frontend/core/src/components/explorer/display-menu/properties.tsx
index 15c4a28f5..74bd9802b 100644
--- a/packages/frontend/core/src/components/explorer/display-menu/properties.tsx
+++ b/packages/frontend/core/src/components/explorer/display-menu/properties.tsx
@@ -5,11 +5,11 @@ import {
 } from '@affine/core/modules/workspace-property';
 import { useI18n } from '@affine/i18n';
 import { useLiveData, useService } from '@toeverything/infra';
-import { useCallback, useContext, useMemo } from 'react';
+import { useCallback, useMemo } from 'react';
 
 import { WorkspacePropertyName } from '../../properties';
 import { WorkspacePropertyTypes } from '../../workspace-property-types';
-import { DocExplorerContext } from '../context';
+import type { ExplorerDisplayPreference } from '../types';
 import * as styles from './properties.css';
 
 export const filterDisplayProperties = <
@@ -29,17 +29,22 @@ export const filterDisplayProperties = <
     }));
 };
 
-export const DisplayProperties = () => {
+export const DisplayProperties = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
   const t = useI18n();
-  const explorerContextValue = useContext(DocExplorerContext);
   const workspacePropertyService = useService(WorkspacePropertyService);
   const propertyList = useLiveData(workspacePropertyService.properties$);
 
-  const displayProperties = useLiveData(
-    explorerContextValue.displayProperties$
-  );
-  const showIcon = useLiveData(explorerContextValue.showDocIcon$);
-  const showBody = useLiveData(explorerContextValue.showDocPreview$);
+  const displayProperties = displayPreference.displayProperties;
+  const showIcon = displayPreference.showDocIcon ?? false;
+  const showBody = displayPreference.showDocPreview ?? false;
 
   const propertiesGroups = useMemo(
     () => [
@@ -57,9 +62,9 @@ export const DisplayProperties = () => {
 
   const handleDisplayPropertiesChange = useCallback(
     (displayProperties: string[]) => {
-      explorerContextValue.displayProperties$?.next(displayProperties);
+      onDisplayPreferenceChange({ ...displayPreference, displayProperties });
     },
-    [explorerContextValue.displayProperties$]
+    [displayPreference, onDisplayPreferenceChange]
   );
 
   const handlePropertyClick = useCallback(
@@ -74,12 +79,18 @@ export const DisplayProperties = () => {
   );
 
   const toggleIcon = useCallback(() => {
-    explorerContextValue.showDocIcon$?.next(!showIcon);
-  }, [explorerContextValue.showDocIcon$, showIcon]);
+    onDisplayPreferenceChange({
+      ...displayPreference,
+      showDocIcon: !showIcon,
+    });
+  }, [displayPreference, onDisplayPreferenceChange, showIcon]);
 
   const toggleBody = useCallback(() => {
-    explorerContextValue.showDocPreview$?.next(!showBody);
-  }, [explorerContextValue.showDocPreview$, showBody]);
+    onDisplayPreferenceChange({
+      ...displayPreference,
+      showDocPreview: !showBody,
+    });
+  }, [displayPreference, onDisplayPreferenceChange, showBody]);
 
   return (
     <div className={styles.root}>
@@ -94,7 +105,9 @@ export const DisplayProperties = () => {
                 <Button
                   key={property.id}
                   data-show={
-                    displayProperties && displayProperties.includes(property.id)
+                    displayProperties
+                      ? displayProperties.includes(property.id)
+                      : false
                   }
                   onClick={() => handlePropertyClick(property.id)}
                   className={styles.property}
diff --git a/packages/frontend/core/src/components/explorer/display-menu/quick-actions.tsx b/packages/frontend/core/src/components/explorer/display-menu/quick-actions.tsx
index 54d409e79..c5d252945 100644
--- a/packages/frontend/core/src/components/explorer/display-menu/quick-actions.tsx
+++ b/packages/frontend/core/src/components/explorer/display-menu/quick-actions.tsx
@@ -1,12 +1,19 @@
 import { Checkbox, MenuItem, MenuSub } from '@affine/component';
 import { useI18n } from '@affine/i18n';
-import { useLiveData } from '@toeverything/infra';
-import { useCallback, useContext } from 'react';
+import { useCallback } from 'react';
 
-import { DocExplorerContext } from '../context';
 import { type QuickAction, quickActions } from '../quick-actions.constants';
+import type { ExplorerDisplayPreference } from '../types';
 
-export const QuickActionsConfig = () => {
+export const QuickActionsConfig = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
   const t = useI18n();
 
   return (
@@ -14,7 +21,19 @@ export const QuickActionsConfig = () => {
       items={quickActions.map(action => {
         if (action.disabled) return null;
 
-        return <QuickActionItem key={action.key} action={action} />;
+        return (
+          <QuickActionItem
+            key={action.key}
+            action={action}
+            active={displayPreference[`${action.key}`] ?? false}
+            onClick={() => {
+              onDisplayPreferenceChange({
+                ...displayPreference,
+                [action.key]: !displayPreference[action.key],
+              });
+            }}
+          />
+        );
       })}
     >
       {t['com.affine.all-docs.quick-actions']()}
@@ -22,24 +41,28 @@ export const QuickActionsConfig = () => {
   );
 };
 
-const QuickActionItem = ({ action }: { action: QuickAction }) => {
+const QuickActionItem = ({
+  action,
+  active,
+  onClick,
+}: {
+  action: QuickAction;
+  active: boolean;
+  onClick: () => void;
+}) => {
   const t = useI18n();
-  const explorerContextValue = useContext(DocExplorerContext);
-
-  const value = useLiveData(explorerContextValue[`${action.key}$`]);
 
   const handleClick = useCallback(
     (e: React.MouseEvent) => {
       e.stopPropagation();
       e.preventDefault();
-      const value = explorerContextValue[`${action.key}$`]?.value;
-      explorerContextValue[`${action.key}$`]?.next(!value);
+      onClick();
     },
-    [action.key, explorerContextValue]
+    [onClick]
   );
 
   return (
-    <MenuItem prefixIcon={<Checkbox checked={!!value} />} onClick={handleClick}>
+    <MenuItem prefixIcon={<Checkbox checked={active} />} onClick={handleClick}>
       {t.t(action.name)}
     </MenuItem>
   );
diff --git a/packages/frontend/core/src/components/explorer/display-menu/view-toggle.tsx b/packages/frontend/core/src/components/explorer/display-menu/view-toggle.tsx
index 80b4bd4cd..c34fe8d63 100644
--- a/packages/frontend/core/src/components/explorer/display-menu/view-toggle.tsx
+++ b/packages/frontend/core/src/components/explorer/display-menu/view-toggle.tsx
@@ -1,8 +1,6 @@
 import { RadioGroup, type RadioItem } from '@affine/component';
-import { useLiveData } from '@toeverything/infra';
-import { useCallback, useContext } from 'react';
+import { useCallback } from 'react';
 
-import { DocExplorerContext } from '../context';
 import {
   type DocListItemView,
   DocListViewIcon,
@@ -27,16 +25,18 @@ const views = [
   },
 ] satisfies RadioItem[];
 
-export const ViewToggle = () => {
-  const explorerContextValue = useContext(DocExplorerContext);
-
-  const view = useLiveData(explorerContextValue.view$);
-
+export const ViewToggle = ({
+  view,
+  onViewChange,
+}: {
+  view: DocListItemView;
+  onViewChange: (view: DocListItemView) => void;
+}) => {
   const handleViewChange = useCallback(
     (view: DocListItemView) => {
-      explorerContextValue.view$?.next(view);
+      onViewChange(view);
     },
-    [explorerContextValue.view$]
+    [onViewChange]
   );
 
   return (
diff --git a/packages/frontend/core/src/components/explorer/docs-view/doc-list-item.tsx b/packages/frontend/core/src/components/explorer/docs-view/doc-list-item.tsx
index 8b46c7aaa..908fb87f7 100644
--- a/packages/frontend/core/src/components/explorer/docs-view/doc-list-item.tsx
+++ b/packages/frontend/core/src/components/explorer/docs-view/doc-list-item.tsx
@@ -67,7 +67,7 @@ class MixId {
 }
 export const DocListItem = ({ ...props }: DocListItemProps) => {
   const contextValue = useContext(DocExplorerContext);
-  const view = useLiveData(contextValue.view$);
+  const view = useLiveData(contextValue.view$) ?? 'list';
   const groups = useLiveData(contextValue.groups$);
   const selectMode = useLiveData(contextValue.selectMode$);
   const selectedDocIds = useLiveData(contextValue.selectedDocIds$);
@@ -255,7 +255,7 @@ const Select = memo(function Select({
     </div>
   );
 });
-// Different with RawDocIcon, refer to `ExplorerPreference.showDocIcon`
+// Different with RawDocIcon, refer to `ExplorerDisplayPreference.showDocIcon`
 const DocIcon = memo(function DocIcon({
   id,
   ...props
diff --git a/packages/frontend/core/src/components/explorer/quick-actions.constants.tsx b/packages/frontend/core/src/components/explorer/quick-actions.constants.tsx
index ed77016e8..3fb603b08 100644
--- a/packages/frontend/core/src/components/explorer/quick-actions.constants.tsx
+++ b/packages/frontend/core/src/components/explorer/quick-actions.constants.tsx
@@ -8,7 +8,7 @@ import {
   QuickSplit,
   QuickTab,
 } from './docs-view/quick-actions';
-import type { ExplorerPreference } from './types';
+import type { ExplorerDisplayPreference } from './types';
 
 interface QuickActionItem {
   name: I18nString;
@@ -20,7 +20,10 @@ type ExtractPrefixKeys<Obj extends object, Prefix extends string> = {
   [Key in keyof Obj]-?: Key extends `${Prefix}${string}` ? Key : never;
 }[keyof Obj];
 
-export type QuickActionKey = ExtractPrefixKeys<ExplorerPreference, 'quick'>;
+export type QuickActionKey = ExtractPrefixKeys<
+  ExplorerDisplayPreference,
+  'quick'
+>;
 
 const QUICK_ACTION_MAP: Record<QuickActionKey, QuickActionItem> = {
   quickFavorite: {
diff --git a/packages/frontend/core/src/components/explorer/types.ts b/packages/frontend/core/src/components/explorer/types.ts
index c8609eba1..fe4fcc9cb 100644
--- a/packages/frontend/core/src/components/explorer/types.ts
+++ b/packages/frontend/core/src/components/explorer/types.ts
@@ -1,4 +1,3 @@
-import type { FilterParams } from '@affine/core/modules/collection-rules';
 import type {
   GroupByParams,
   OrderByParams,
@@ -6,8 +5,10 @@ import type {
 import type { DocCustomPropertyInfo } from '@affine/core/modules/db';
 import type { DocRecord } from '@affine/core/modules/doc';
 
-export interface ExplorerPreference {
-  filters?: FilterParams[];
+import type { DocListItemView } from './docs-view/doc-list-item';
+
+export interface ExplorerDisplayPreference {
+  view?: DocListItemView;
   groupBy?: GroupByParams;
   orderBy?: OrderByParams;
   displayProperties?: string[];
diff --git a/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page-header.tsx b/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page-header.tsx
index a300a4aff..94bc2095a 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page-header.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page-header.tsx
@@ -1,7 +1,10 @@
 import { type MenuProps } from '@affine/component';
 import { ExplorerDisplayMenuButton } from '@affine/core/components/explorer/display-menu';
 import { ViewToggle } from '@affine/core/components/explorer/display-menu/view-toggle';
+import type { DocListItemView } from '@affine/core/components/explorer/docs-view/doc-list-item';
 import { ExplorerNavigation } from '@affine/core/components/explorer/header/navigation';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
+import { useCallback } from 'react';
 
 import * as styles from './all-page-header.css';
 
@@ -13,14 +16,36 @@ const menuProps: Partial<MenuProps> = {
     sideOffset: 8,
   },
 };
-export const AllDocsHeader = () => {
+export const AllDocsHeader = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
+  const handleViewChange = useCallback(
+    (view: DocListItemView) => {
+      onDisplayPreferenceChange({ ...displayPreference, view });
+    },
+    [displayPreference, onDisplayPreferenceChange]
+  );
+
   return (
     <div className={styles.header}>
       <ExplorerNavigation active="docs" />
 
       <div className={styles.actions}>
-        <ViewToggle />
-        <ExplorerDisplayMenuButton menuProps={menuProps} />
+        <ViewToggle
+          view={displayPreference.view ?? 'list'}
+          onViewChange={handleViewChange}
+        />
+        <ExplorerDisplayMenuButton
+          menuProps={menuProps}
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={onDisplayPreferenceChange}
+        />
       </div>
     </div>
   );
diff --git a/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page.tsx b/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page.tsx
index f7b6cb70d..aadefc002 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/all-page/all-page.tsx
@@ -4,6 +4,7 @@ import {
   DocExplorerContext,
 } from '@affine/core/components/explorer/context';
 import { DocsExplorer } from '@affine/core/components/explorer/docs-view/docs-list';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
 import { Filters } from '@affine/core/components/filter';
 import {
   CollectionService,
@@ -12,9 +13,10 @@ import {
 import { CollectionRulesService } from '@affine/core/modules/collection-rules';
 import type { FilterParams } from '@affine/core/modules/collection-rules/types';
 import { FeatureFlagService } from '@affine/core/modules/feature-flag';
+import { WorkspaceLocalState } from '@affine/core/modules/workspace';
 import { useI18n } from '@affine/i18n';
 import { useLiveData, useService } from '@toeverything/infra';
-import { useCallback, useEffect, useState } from 'react';
+import { useCallback, useEffect, useMemo, useState } from 'react';
 
 import {
   ViewBody,
@@ -29,11 +31,22 @@ import { AllDocsHeader } from './all-page-header';
 import { MigrationAllDocsDataNotification } from './migration-data';
 import { PinnedCollections } from './pinned-collections';
 
+interface AllDocsStateSave extends ExplorerDisplayPreference {
+  selectedCollectionId: string | null;
+}
+
 export const AllPage = () => {
   const t = useI18n();
 
   const collectionService = useService(CollectionService);
   const pinnedCollectionService = useService(PinnedCollectionService);
+  const workspaceLocalState = useService(WorkspaceLocalState);
+
+  const [initialState] = useState(() => {
+    return workspaceLocalState.get<AllDocsStateSave>(
+      'allDocsDisplayPreference'
+    );
+  });
 
   const isCollectionDataReady = useLiveData(
     collectionService.collectionDataReady$
@@ -49,7 +62,7 @@ export const AllPage = () => {
 
   const [selectedCollectionId, setSelectedCollectionId] = useState<
     string | null
-  >(null);
+  >(initialState?.selectedCollectionId ?? null);
   const selectedCollection = useLiveData(
     selectedCollectionId
       ? collectionService.collection$(selectedCollectionId)
@@ -80,10 +93,26 @@ export const AllPage = () => {
 
   const [tempFilters, setTempFilters] = useState<FilterParams[] | null>(null);
 
-  const [explorerContextValue] = useState(createDocExplorerContext);
+  const [explorerContextValue] = useState(() =>
+    createDocExplorerContext(initialState)
+  );
 
   const groupBy = useLiveData(explorerContextValue.groupBy$);
   const orderBy = useLiveData(explorerContextValue.orderBy$);
+  const displayPreference = useLiveData(
+    explorerContextValue.displayPreference$
+  );
+
+  const allDocsStateSave = useMemo(() => {
+    return {
+      ...displayPreference,
+      selectedCollectionId,
+    };
+  }, [displayPreference, selectedCollectionId]);
+
+  useEffect(() => {
+    workspaceLocalState.set('allDocsDisplayPreference', allDocsStateSave);
+  }, [allDocsStateSave, workspaceLocalState]);
 
   const { openPromptModal } = usePromptModal();
 
@@ -187,6 +216,11 @@ export const AllPage = () => {
     setTempFilters(null);
   }, []);
 
+  const handleSelectAll = useCallback(() => {
+    setSelectedCollectionId(null);
+    setTempFilters(null);
+  }, []);
+
   const handleEditCollection = useCallback(
     (collectionId: string) => {
       const collection = collectionService.collection$(collectionId).value;
@@ -250,12 +284,22 @@ export const AllPage = () => {
     setTempFilters([params]);
   }, []);
 
+  const handleDisplayPreferenceChange = useCallback(
+    (displayPreference: ExplorerDisplayPreference) => {
+      explorerContextValue.displayPreference$.next(displayPreference);
+    },
+    [explorerContextValue]
+  );
+
   return (
     <DocExplorerContext.Provider value={explorerContextValue}>
       <ViewTitle title={t['All pages']()} />
       <ViewIcon icon="allDocs" />
       <ViewHeader>
-        <AllDocsHeader />
+        <AllDocsHeader
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={handleDisplayPreferenceChange}
+        />
       </ViewHeader>
       <ViewBody>
         <div className={styles.body}>
@@ -263,7 +307,7 @@ export const AllPage = () => {
           <div className={styles.pinnedCollection}>
             <PinnedCollections
               activeCollectionId={selectedCollectionId}
-              onActiveAll={() => setSelectedCollectionId(null)}
+              onActiveAll={handleSelectAll}
               onActiveCollection={handleSelectCollection}
               onAddFilter={handleNewTempFilter}
               onEditCollection={handleEditCollection}
diff --git a/packages/frontend/core/src/desktop/pages/workspace/all-page/pinned-collections.tsx b/packages/frontend/core/src/desktop/pages/workspace/all-page/pinned-collections.tsx
index a1f04cc5c..21fd1be04 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/all-page/pinned-collections.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/all-page/pinned-collections.tsx
@@ -108,7 +108,10 @@ export const PinnedCollections = ({
       <div
         className={styles.item}
         data-active={activeCollectionId === null ? 'true' : undefined}
-        onClick={onActiveAll}
+        onClick={() =>
+          // only fire onActiveAll if the collection is not already active
+          activeCollectionId !== null ? onActiveAll() : undefined
+        }
         role="button"
       >
         {t['com.affine.all-docs.pinned-collection.all']()}
@@ -118,7 +121,12 @@ export const PinnedCollections = ({
           key={record.collectionId}
           record={record}
           isActive={activeCollectionId === record.collectionId}
-          onClick={() => onActiveCollection(record.collectionId)}
+          onClick={() =>
+            // only fire onActiveCollection if the collection is not already active
+            activeCollectionId !== record.collectionId
+              ? onActiveCollection(record.collectionId)
+              : undefined
+          }
           onClickEdit={() => onEditCollection(record.collectionId)}
           onClickRemove={() => {
             const nextCollectionId = pinnedCollections[index - 1]?.collectionId;
diff --git a/packages/frontend/core/src/desktop/pages/workspace/collection/header.tsx b/packages/frontend/core/src/desktop/pages/workspace/collection/header.tsx
index 75efa3fbe..68ac3f3f9 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/collection/header.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/collection/header.tsx
@@ -2,15 +2,32 @@ import { FlexWrapper } from '@affine/component';
 import { ExplorerDisplayMenuButton } from '@affine/core/components/explorer/display-menu';
 import { ViewToggle } from '@affine/core/components/explorer/display-menu/view-toggle';
 import { ExplorerNavigation } from '@affine/core/components/explorer/header/navigation';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
 import { Header } from '@affine/core/components/pure/header';
 
-export const CollectionDetailHeader = () => {
+export const CollectionDetailHeader = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
   return (
     <Header
       right={
         <FlexWrapper gap={16}>
-          <ViewToggle />
-          <ExplorerDisplayMenuButton />
+          <ViewToggle
+            view={displayPreference.view ?? 'list'}
+            onViewChange={view => {
+              onDisplayPreferenceChange({ ...displayPreference, view });
+            }}
+          />
+          <ExplorerDisplayMenuButton
+            displayPreference={displayPreference}
+            onDisplayPreferenceChange={onDisplayPreferenceChange}
+          />
         </FlexWrapper>
       }
       left={<ExplorerNavigation active="collections" />}
diff --git a/packages/frontend/core/src/desktop/pages/workspace/collection/index.tsx b/packages/frontend/core/src/desktop/pages/workspace/collection/index.tsx
index 2577cec1c..298ab6301 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/collection/index.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/collection/index.tsx
@@ -5,6 +5,7 @@ import {
   DocExplorerContext,
 } from '@affine/core/components/explorer/context';
 import { DocsExplorer } from '@affine/core/components/explorer/docs-view/docs-list';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
 import {
   type Collection,
   CollectionService,
@@ -45,11 +46,21 @@ export const CollectionDetail = ({
   const isAdmin = useLiveData(permissionService.permission.isAdmin$);
   const isOwner = useLiveData(permissionService.permission.isOwner$);
 
+  const displayPreference = useLiveData(
+    explorerContextValue.displayPreference$
+  );
   const groupBy = useLiveData(explorerContextValue.groupBy$);
   const orderBy = useLiveData(explorerContextValue.orderBy$);
   const rules = useLiveData(collection.rules$);
   const allowList = useLiveData(collection.allowList$);
 
+  const handleDisplayPreferenceChange = useCallback(
+    (displayPreference: ExplorerDisplayPreference) => {
+      explorerContextValue.displayPreference$.next(displayPreference);
+    },
+    [explorerContextValue]
+  );
+
   useEffect(() => {
     const subscription = collectionRulesService
       .watch({
@@ -95,7 +106,10 @@ export const CollectionDetail = ({
   return (
     <DocExplorerContext.Provider value={explorerContextValue}>
       <ViewHeader>
-        <CollectionDetailHeader />
+        <CollectionDetailHeader
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={handleDisplayPreferenceChange}
+        />
       </ViewHeader>
       <ViewBody>
         <FlexWrapper flexDirection="column" alignItems="stretch" width="100%">
diff --git a/packages/frontend/core/src/desktop/pages/workspace/tag/header.tsx b/packages/frontend/core/src/desktop/pages/workspace/tag/header.tsx
index acc1eab42..0df1d561e 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/tag/header.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/tag/header.tsx
@@ -1,12 +1,26 @@
 import { ExplorerDisplayMenuButton } from '@affine/core/components/explorer/display-menu';
 import { ExplorerNavigation } from '@affine/core/components/explorer/header/navigation';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
 import { Header } from '@affine/core/components/pure/header';
 
-export const TagDetailHeader = () => {
+export const TagDetailHeader = ({
+  displayPreference,
+  onDisplayPreferenceChange,
+}: {
+  displayPreference: ExplorerDisplayPreference;
+  onDisplayPreferenceChange: (
+    displayPreference: ExplorerDisplayPreference
+  ) => void;
+}) => {
   return (
     <Header
       left={<ExplorerNavigation active={'tags'} />}
-      right={<ExplorerDisplayMenuButton />}
+      right={
+        <ExplorerDisplayMenuButton
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={onDisplayPreferenceChange}
+        />
+      }
     />
   );
 };
diff --git a/packages/frontend/core/src/desktop/pages/workspace/tag/index.tsx b/packages/frontend/core/src/desktop/pages/workspace/tag/index.tsx
index 6dedca3e7..c95b7ffdf 100644
--- a/packages/frontend/core/src/desktop/pages/workspace/tag/index.tsx
+++ b/packages/frontend/core/src/desktop/pages/workspace/tag/index.tsx
@@ -3,6 +3,7 @@ import {
   DocExplorerContext,
 } from '@affine/core/components/explorer/context';
 import { DocsExplorer } from '@affine/core/components/explorer/docs-view/docs-list';
+import type { ExplorerDisplayPreference } from '@affine/core/components/explorer/types';
 import { CollectionRulesService } from '@affine/core/modules/collection-rules';
 import { GlobalContextService } from '@affine/core/modules/global-context';
 import { WorkspacePermissionService } from '@affine/core/modules/permissions';
@@ -15,7 +16,7 @@ import {
   ViewTitle,
 } from '@affine/core/modules/workbench';
 import { useLiveData, useService } from '@toeverything/infra';
-import { useEffect, useState } from 'react';
+import { useCallback, useEffect, useState } from 'react';
 import { useParams } from 'react-router-dom';
 
 import { PageNotFound } from '../../404';
@@ -36,6 +37,9 @@ export const TagDetail = ({ tagId }: { tagId?: string }) => {
   const tagList = useService(TagService).tagList;
   const currentTag = useLiveData(tagList.tagByTagId$(tagId));
 
+  const displayPreference = useLiveData(
+    explorerContextValue.displayPreference$
+  );
   const groupBy = useLiveData(explorerContextValue.groupBy$);
   const orderBy = useLiveData(explorerContextValue.orderBy$);
   const groups = useLiveData(explorerContextValue.groups$);
@@ -109,12 +113,23 @@ export const TagDetail = ({ tagId }: { tagId?: string }) => {
     return <PageNotFound />;
   }
 
+  // eslint-disable-next-line react-hooks/rules-of-hooks
+  const handleDisplayPreferenceChange = useCallback(
+    (displayPreference: ExplorerDisplayPreference) => {
+      explorerContextValue.displayPreference$.next(displayPreference);
+    },
+    [explorerContextValue]
+  );
+
   return (
     <DocExplorerContext.Provider value={explorerContextValue}>
       <ViewTitle title={tagName ?? 'Untitled'} />
       <ViewIcon icon="tag" />
       <ViewHeader>
-        <TagDetailHeader />
+        <TagDetailHeader
+          displayPreference={displayPreference}
+          onDisplayPreferenceChange={handleDisplayPreferenceChange}
+        />
       </ViewHeader>
       <ViewBody>
         <div className={styles.body}>