luulam/9router
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(translator): P4 concern #6 finishReasonMap — switch-by-format, default common

Browse Source 
- concerns/finishReasonMap.js: toOpenAIFinish/fromOpenAIFinish, switch special formats, default passthrough
- Replace 3 inline switch maps (claude→oai, oai→claude, commandcode→oai)
- Golden translator tests pass, behavior identical

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
decolua
2026-06-13 21:20:22 +07:00
parent d2b0960bf7
commit 4cc667253a
4 changed files with 49 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
open-sse/translator/concerns/finishReasonMap.js Normal file
View File

@@ -0,0 +1,43 @@
// Concern #6: finish_reason / stop_reason mapping.
// One entry per direction; switch by special format, default handles common providers.
// upstream finish/stop reason → OpenAI finish_reason
export function toOpenAIFinish(reason, format) {
switch (format) {
case "claude":
switch (reason) {
case "end_turn": return "stop";
case "max_tokens": return "length";
case "tool_use": return "tool_calls";
case "stop_sequence": return "stop";
default: return "stop";
}
case "commandcode":
switch (reason) {
case "stop": return "stop";
case "length": return "length";
case "tool-calls":
case "tool_use": return "tool_calls";
case "content-filter": return "content_filter";
case "error": return "stop";
default: return reason || "stop";
}
default:
return reason || "stop";
}
}
// OpenAI finish_reason → upstream stop reason
export function fromOpenAIFinish(reason, format) {
switch (format) {
case "claude":
switch (reason) {
case "stop": return "end_turn";
case "length": return "max_tokens";
case "tool_calls": return "tool_use";
default: return "end_turn";
}
default:
return reason;
}
}

12
open-sse/translator/response/claude-to-openai.js
View File

@@ -3,6 +3,7 @@ import { FORMATS } from "../formats.js";
import { buildChunk } from "../helpers/chunkBuilder.js";
import { buildUsage } from "../helpers/usageHelper.js";
import { reasoningDelta } from "../helpers/reasoningHelper.js";
import { toOpenAIFinish } from "../concerns/finishReasonMap.js";
// Create OpenAI chunk helper
function createChunk(state, delta, finishReason = null) {
@@ -164,16 +165,7 @@ export function claudeToOpenAIResponse(chunk, state) {
return results.length > 0 ? results : null;
}
// Convert Claude stop_reason to OpenAI finish_reason
function convertStopReason(reason) {
switch (reason) {
case "end_turn": return "stop";
case "max_tokens": return "length";
case "tool_use": return "tool_calls";
case "stop_sequence": return "stop";
default: return "stop";
}
}
const convertStopReason = (reason) => toOpenAIFinish(reason, "claude");
// Register
register(FORMATS.CLAUDE, FORMATS.OPENAI, null, claudeToOpenAIResponse);

13
open-sse/translator/response/commandcode-to-openai.js
View File

@@ -19,6 +19,7 @@ import { register } from "../index.js";
import { FORMATS } from "../formats.js";
import { buildChunk } from "../helpers/chunkBuilder.js";
import { reasoningDelta } from "../helpers/reasoningHelper.js";
import { toOpenAIFinish } from "../concerns/finishReasonMap.js";
function ensureState(state, model) {
if (!state.responseId) {
@@ -43,17 +44,7 @@ function makeChunk(state, delta, finishReason = null) {
);
}
function mapFinishReason(reason) {
switch (reason) {
case "stop": return "stop";
case "length": return "length";
case "tool-calls":
case "tool_use": return "tool_calls";
case "content-filter": return "content_filter";
case "error": return "stop";
default: return reason || "stop";
}
}
const mapFinishReason = (reason) => toOpenAIFinish(reason, "commandcode");
export function convertCommandCodeToOpenAI(chunk, state) {
if (!chunk) return null;

11
open-sse/translator/response/openai-to-claude.js
View File

@@ -1,5 +1,6 @@
import { register } from "../index.js";
import { FORMATS } from "../formats.js";
import { fromOpenAIFinish } from "../concerns/finishReasonMap.js";
// Prefix for Claude OAuth tool names (must match request translator)
const CLAUDE_OAUTH_TOOL_PREFIX = "proxy_";
@@ -252,15 +253,7 @@ export function openaiToClaudeResponse(chunk, state) {
return results.length > 0 ? results : null;
}
// Convert OpenAI finish_reason to Claude stop_reason
function convertFinishReason(reason) {
switch (reason) {
case "stop": return "end_turn";
case "length": return "max_tokens";
case "tool_calls": return "tool_use";
default: return "end_turn";
}
}
const convertFinishReason = (reason) => fromOpenAIFinish(reason, "claude");
// Register
register(FORMATS.OPENAI, FORMATS.CLAUDE, null, openaiToClaudeResponse);