fix(auth): redirect active sessions from /login

/api/auth/status did not expose whether the auth cookie corresponds to a
valid dashboard session, so /login could only detect "auth disabled"
(requireLogin === false) and not "already logged in". Add authenticated
to the status response and redirect from /login when it's true.
This commit is contained in:
DaDecky
2026-08-05 10:26:57 +07:00
committed by decolua
parent 918b3c87a1
commit ae4f76c433
3 changed files with 72 additions and 1 deletions

View File

@@ -24,6 +24,7 @@ export async function GET() {
hasPassword: !!settings.password,
displayName,
loginMethod,
authenticated: !!session,
oidcName: oidcName || null,
oidcEmail: oidcEmail || null,
oidcLogin: !!session?.oidc,
@@ -37,6 +38,7 @@ export async function GET() {
hasPassword: false,
displayName: "Password user",
loginMethod: "Password",
authenticated: false,
oidcName: null,
oidcEmail: null,
oidcLogin: false,

View File

@@ -37,7 +37,7 @@ export default function LoginPage() {
if (res.ok) {
const data = await res.json();
if (data.requireLogin === false) {
if (data.authenticated === true || data.requireLogin === false) {
window.location.assign("/dashboard");
return;
}

View File

@@ -0,0 +1,69 @@
import { describe, it, expect, vi, beforeEach } from "vitest";
const mocks = vi.hoisted(() => ({
json: vi.fn((body, init) => ({
status: init?.status || 200,
body,
})),
cookies: vi.fn(),
getSettings: vi.fn(),
isOidcConfigured: vi.fn(),
getDashboardAuthSession: vi.fn(),
}));
vi.mock("next/server", () => ({
NextResponse: { json: mocks.json },
}));
vi.mock("next/headers", () => ({
cookies: mocks.cookies,
}));
vi.mock("@/lib/localDb", () => ({
getSettings: mocks.getSettings,
}));
vi.mock("@/lib/auth/oidc", () => ({
isOidcConfigured: mocks.isOidcConfigured,
}));
vi.mock("@/lib/auth/dashboardSession", () => ({
getDashboardAuthSession: mocks.getDashboardAuthSession,
}));
const { GET } = await import("../../src/app/api/auth/status/route.js");
describe("GET /api/auth/status", () => {
beforeEach(() => {
vi.clearAllMocks();
mocks.getSettings.mockResolvedValue({ requireLogin: true, authMode: "password" });
mocks.cookies.mockResolvedValue({ get: vi.fn(() => ({ value: "session-token" })) });
mocks.isOidcConfigured.mockReturnValue(false);
});
it("reports an authenticated session when the auth cookie is valid", async () => {
mocks.getDashboardAuthSession.mockResolvedValue({ authenticated: true });
const response = await GET();
expect(response.body.authenticated).toBe(true);
expect(mocks.getDashboardAuthSession).toHaveBeenCalledWith("session-token");
});
it("reports unauthenticated when the auth cookie is invalid", async () => {
mocks.getDashboardAuthSession.mockResolvedValue(null);
const response = await GET();
expect(response.body.authenticated).toBe(false);
});
it("fails closed when status dependencies throw", async () => {
mocks.getSettings.mockRejectedValue(new Error("database unavailable"));
const response = await GET();
expect(response.body.authenticated).toBe(false);
expect(response.body.requireLogin).toBe(true);
});
});