luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(electron): do not always enable devtools detach mode (#8273)

Browse Source
This commit is contained in:
pengx17
2024-09-18 04:16:51 +00:00
parent 714b7b863e
commit 7a26c76e53
2 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/frontend/apps/electron/src/main/windows-manager/main-window.ts
View File

@@ -258,9 +258,7 @@ export async function openUrlInHiddenWindow(urlObj: URL) {
}); });
if (BUILD_CONFIG.debug) { if (BUILD_CONFIG.debug) {
win.webContents.openDevTools({ win.webContents.openDevTools();
mode: 'detach',
});
} }
win.on('close', e => { win.on('close', e => {

12
packages/frontend/apps/electron/src/main/windows-manager/tab-views.ts
View File

@@ -817,9 +817,7 @@ export class WebContentViewsManager {
view.webContents.loadURL(shellViewUrl).catch(err => logger.error(err)); view.webContents.loadURL(shellViewUrl).catch(err => logger.error(err));
if (isDev) { if (isDev) {
view.webContents.openDevTools({ view.webContents.openDevTools();
mode: 'detach',
});
} }
} }
@@ -1003,17 +1001,13 @@ export const showDevTools = (id?: string) => {
getCustomThemeWindow() getCustomThemeWindow()
.then(w => { .then(w => {
if (w && w.isFocused()) { if (w && w.isFocused()) {
w.webContents.openDevTools({ w.webContents.openDevTools();
mode: 'detach',
});
} else { } else {
const view = id const view = id
? WebContentViewsManager.instance.getViewById(id) ? WebContentViewsManager.instance.getViewById(id)
: WebContentViewsManager.instance.activeWorkbenchView; : WebContentViewsManager.instance.activeWorkbenchView;
if (view) { if (view) {
view.webContents.openDevTools({ view.webContents.openDevTools();
mode: 'detach',
});
} }
} }
}) })