luulam/AFFiNE
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

refactor(core): use overcapacityMemberCount for quota checking instead of calculating the difference (#12117)

Browse Source 
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **Bug Fixes**
  - Improved accuracy of member quota warnings by updating the logic that detects when the member limit has been exceeded.
  - Enhanced test reliability by adjusting member list pagination test to better handle confirmation modals.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
JimmFly
2025-05-08 09:55:23 +00:00
parent 52253e9e82
commit d379143db3
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/frontend/core/src/modules/quota/views/quota-check.tsx
View File

@@ -57,8 +57,7 @@ export const QuotaCheck = ({
if (workspaceMeta.flavour === 'local' || !quota || isTeam) { if (workspaceMeta.flavour === 'local' || !quota || isTeam) {
return; return;
} }
const memberOverflow = quota.memberCount > quota.memberLimit; const memberOverflow = quota.overcapacityMemberCount > 0;
// remember to use real percent
const storageOverflow = usedPercent && usedPercent >= 100; const storageOverflow = usedPercent && usedPercent >= 100;
const message = getSyncPausedMessage( const message = getSyncPausedMessage(
!!isOwner, !!isOwner,

2
tests/affine-cloud/e2e/workspace.spec.ts
View File

@@ -62,8 +62,6 @@ test('should have pagination in member list', async ({ page }) => {
await page.waitForTimeout(1000); await page.waitForTimeout(1000);
await page.getByTestId('confirm-modal-cancel').click();
const firstPageMemberItemCount = await page const firstPageMemberItemCount = await page
.locator('[data-testid="member-item"]') .locator('[data-testid="member-item"]')
.count(); .count();